All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	qemu-s390x@nongnu.org, Eric Farman <farman@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Halil Pasic <pasic@linux.ibm.com>
Cc: qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] hw/s390x/s390-virtio-ccw: Improve the machine description string
Date: Fri, 06 May 2022 09:23:43 +0200	[thread overview]
Message-ID: <878rrf5dkw.fsf@redhat.com> (raw)
In-Reply-To: <20220506065026.513590-1-thuth@redhat.com>

On Fri, May 06 2022, Thomas Huth <thuth@redhat.com> wrote:

> The machine name already contains the words "ccw" and "virtio", so
> using "VirtIO-ccw" in the description likely does not really help
> the average user to get an idea what this machine type is about.
> Thus let's switch to "Virtual s390x machine" now, since "virtual
> machine" should be a familiar term, and "s390x" signals that this
> is about 64-bit guests (unlike S390 which could mean that it is
> 31-bit only).

Do we foresee any s390x machines that don't default to ccw virtio
devices in the future?

> Also expand "v" to "version, since this makes it easier to use

s/"version/"version"/ :)

> this macro also with non-numeric machine names in downstream.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  hw/s390x/s390-virtio-ccw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index 8fa488d13a..11a942a325 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -768,7 +768,7 @@ bool css_migration_enabled(void)
>      {                                                                         \
>          MachineClass *mc = MACHINE_CLASS(oc);                                 \
>          ccw_machine_##suffix##_class_options(mc);                             \
> -        mc->desc = "VirtIO-ccw based S390 machine v" verstr;                  \
> +        mc->desc = "Virtual s390x machine (version " verstr ")";      \
>          if (latest) {                                                         \
>              mc->alias = "s390-ccw-virtio";                                    \
>              mc->is_default = true;                                            \



  reply	other threads:[~2022-05-06  7:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06  6:50 [PATCH] hw/s390x/s390-virtio-ccw: Improve the machine description string Thomas Huth
2022-05-06  7:23 ` Cornelia Huck [this message]
2022-05-06 10:03   ` Thomas Huth
2022-05-06 10:22     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rrf5dkw.fsf@redhat.com \
    --to=cohuck@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.