From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F04A533E0 for ; Wed, 4 May 2022 22:18:14 +0000 (UTC) Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EDDEC240027 for ; Thu, 5 May 2022 00:09:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1651702198; bh=Vky15gD8jullIDai+eZgZhQbvam0639JS90uBzaxgfI=; h=From:To:Cc:Subject:Date:From; b=mkRxynIFvE7MwaB/ret1iB6Q32Miw4mhliv12gkQgLRM0H2PdDA0KbNYHHVLwU0mB MrU3C+N6NP1XU1JCgSc3A3buS8tsf+MNSgnrlfsOIQtQ5ZSPWAs0ID6VvvzfzLgoUe uK3+Q12bc/NLGxwuwKw1lSH4kX1D8OB0HFkywFbzn+nh6KR9i4yfOoWhsUpdh5fwIb 6yiFBM43kJ+YTWzfhBj5VmQa9INNpHP3Tzkm/5SSIvl6uVWkmh7LBV3VRvRbJvZifV rHpDIIN/4slFFGFVuP6HRIJ8hPOB5ZWL0+lVB7LmVyh7aChNx/4kqHjKqSwQjE6GPb eSPb9AqBT4IXA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Ktrbn02H7z6tn7; Thu, 5 May 2022 00:09:56 +0200 (CEST) From: Manuel Ullmann To: Holger =?utf-8?Q?Hoffst=C3=A4tte?= Cc: Manuel Ullmann , Jordan Leppert , "stable@vger.kernel.org" , "regressions@lists.linux.dev" , "davem@davemloft.net" Subject: Re: Crash on resume after suspend (5.17.5 and 5.15.36) References: <9-Ehc_xXSwdXcvZqKD5aSqsqeNj5Izco4MYEwnx5cySXVEc9-x_WC4C3kAoCqNTi-H38frroUK17iobNVnkLtW36V6VWGSQEOHXhmVMm5iQ=@protonmail.com> <87levhnlqu.fsf@posteo.de> <18466b6a-b040-c72c-e33d-fe37c5ff6a9d@applied-asynchrony.com> Date: Wed, 04 May 2022 22:10:13 +0000 In-Reply-To: <18466b6a-b040-c72c-e33d-fe37c5ff6a9d@applied-asynchrony.com> ("Holger =?utf-8?Q?Hoffst=C3=A4tte=22's?= message of "Wed, 4 May 2022 22:58:29 +0200") Message-ID: <878rrh2blm.fsf@posteo.de> Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Holger Hoffst=C3=A4tte writes: > On 2022-05-04 21:25, Manuel Ullmann wrote: >>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit= /?h=3Dlinux-5.17.y&id=3Dcbe6c3a8f8f4315b96e46e1a1c70393c06d95a4c >> Yup, that=E2=80=99s my fault and I reproduced this myself yesterday. I a= ctually >> expected this to happen and attempted to test suspend with the patch, >> but must have screwed up by kexec-rebooting into an unpatched kernel >> version or something like that. I=E2=80=99ll disable the kexec service i= n the >> future, if I ever need to prepare a patch again. >>> 05:00.0 Ethernet controller: Aquantia Corp. AQC107 NBase-T/IEEE 802.3bz= Ethernet Controller [AQtion] (rev 02) >> Yes, I have the same one. >>=20 >>> Please let me know if there is any more info I can give that will help. >> Can you confirm, that hibernation works with the patch, but not without >> it? The patch was an attempt to fix it, because I had the same behaviour > > Cannot test hibernation, but.. That=E2=80=99s unfortunate. >> with hibernation. I tried to make sense of the deep parameter in >> atl_resume_common pm function calls, but apparently it=E2=80=99s always = required >> to be true and thus obsolete. > > ..I patched 5.15.38 to pass true as deep arg everywhere, and now resume > seems to work again reliably, 5 out of 5. \o/ Thanks for confirming that my patch should work. For some reason I had the same idea. ;) >> I=E2=80=99ll leave the cleanup of that parameter to the maintainers for = mainline >> and prepare a patch. Last time I sent it against mainline. If this fixup >> of a stable patch regression should be posted differently, it would be >> nice, if someone could give me a pointer. > > Send fix to mainline first, with Fixes: tag and > Cc: stable mentioning the affected versions. Thanks for the hint. I did that. > cheers > Holger