All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: fam@euphon.net, Peter Maydell <peter.maydell@linaro.org>,
	berrange@redhat.com, qemu-devel@nongnu.org, f4bug@amsat.org,
	Eduardo Habkost <eduardo@habkost.net>,
	"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
	stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com,
	aurelien@aurel32.net
Subject: Re: [PATCH v1 22/25] tests/tcg: add float_convd test
Date: Wed, 20 Apr 2022 15:55:28 +0100	[thread overview]
Message-ID: <878rrzx0qk.fsf@linaro.org> (raw)
In-Reply-To: <278f05c9-db1e-4990-4fa7-66f080e07dda@linaro.org>


Richard Henderson <richard.henderson@linaro.org> writes:

> On 4/19/22 02:10, Alex Bennée wrote:
>> This is a simple transliteration of the float_convs test but this time
>> working with doubles. I'm used it to test the handling of vector
>> registers in gdbstub but wasn't able to find a non-ugly way to
>> automate it.
>> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
>> ---
>>   tests/tcg/multiarch/float_convd.c | 106 ++++
>>   tests/tcg/aarch64/float_convd.ref | 988 ++++++++++++++++++++++++++++++
>>   tests/tcg/arm/float_convd.ref     | 988 ++++++++++++++++++++++++++++++
>>   tests/tcg/i386/float_convd.conf   | 988 ++++++++++++++++++++++++++++++
>>   tests/tcg/x86_64/float_convd.ref  | 988 ++++++++++++++++++++++++++++++
>>   5 files changed, 4058 insertions(+)
>>   create mode 100644 tests/tcg/multiarch/float_convd.c
>>   create mode 100644 tests/tcg/aarch64/float_convd.ref
>>   create mode 100644 tests/tcg/arm/float_convd.ref
>>   create mode 100644 tests/tcg/i386/float_convd.conf
>>   create mode 100644 tests/tcg/x86_64/float_convd.ref
>
> Is it worth adjusting the current file to float_conv.c.inc, with
> #define FLOAT {float,double} in float_conv{s,d}.c before #include?
>
> But I suppose this is ok as-is.

I did consider pushing more into libs/float_helpers.c but the whole test file
is fairly simple as is.

> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
>
> r~


-- 
Alex Bennée


  reply	other threads:[~2022-04-20 15:08 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19  9:09 [PATCH v1 for 7.1 00/25] testing, docs and gdbstub pre-PR Alex Bennée
2022-04-19  9:09 ` [PATCH v1 01/25] tests/avocado: update aarch64_virt test to exercise -cpu max Alex Bennée
2022-04-19  9:09 ` [PATCH v1 02/25] docs/devel: add some notes on the binfmt-image-debian targets Alex Bennée
2022-04-19 18:30   ` Richard Henderson
2022-04-19  9:09 ` [PATCH v1 03/25] docs/devel: drop :hidden: and :includehidden: tags Alex Bennée
2022-04-19 18:33   ` Richard Henderson
2022-04-19  9:09 ` [PATCH v1 04/25] tests/docker: remove dead code for linux-user containers Alex Bennée
2022-04-19 18:34   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 05/25] tests/docker: remove test targets Alex Bennée
2022-04-19 18:35   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 06/25] tests/docker: remove dead variable Alex Bennée
2022-04-19 18:36   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 07/25] tests/docker: remove unnecessary default definitions Alex Bennée
2022-04-19 18:37   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 08/25] tests/docker: inline variable definitions or move close to use Alex Bennée
2022-04-19 18:42   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 09/25] tests/docker: remove unnecessary filtering of $(DOCKER_IMAGES) Alex Bennée
2022-04-19 18:44   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 10/25] tests/docker: simplify docker-TEST@IMAGE targets Alex Bennée
2022-04-19 18:46   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 11/25] tests/docker: do not duplicate rules for hexagon-cross Alex Bennée
2022-04-19 18:47   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 12/25] tests/tcg: add compiler test variables when using containers Alex Bennée
2022-04-19 18:48   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 13/25] tests/tcg: remove CONFIG_LINUX_USER from config-target.mak Alex Bennée
2022-04-19 18:49   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 14/25] tests/tcg: remove CONFIG_USER_ONLY " Alex Bennée
2022-04-19 18:53   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 15/25] tests/tcg: prepare Makefile.prereqs at configure time Alex Bennée
2022-04-19 18:57   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 16/25] tests/tcg: list test targets in Makefile.prereqs Alex Bennée
2022-04-19 18:58   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 17/25] tests/tcg: invoke Makefile.target directly from QEMU's makefile Alex Bennée
2022-04-19 19:04   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 18/25] tests/tcg: isolate from QEMU's config-host.mak Alex Bennée
2022-04-19 19:05   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 19/25] tests/docker: remove SKIP_DOCKER_BUILD Alex Bennée
2022-04-19 19:06   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 20/25] tests/tcg: fix non-static build Alex Bennée
2022-04-19 19:10   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 21/25] tests/tcg: remove duplicate sha512-sse case Alex Bennée
2022-04-19 19:11   ` Richard Henderson
2022-04-19  9:10 ` [PATCH v1 22/25] tests/tcg: add float_convd test Alex Bennée
2022-04-19 19:14   ` Richard Henderson
2022-04-20 14:55     ` Alex Bennée [this message]
2022-04-19  9:10 ` [PATCH v1 23/25] tests/tcg: add missing reference files for float_convs Alex Bennée
2022-04-19 19:17   ` Richard Henderson
2022-04-20 14:59     ` Alex Bennée
2022-04-19  9:10 ` [PATCH v1 24/25] target/i386: fix byte swap issue with XMM register access Alex Bennée
2022-04-19  9:10 ` [PATCH v1 25/25] tests/guest-debug: better handle gdb crashes Alex Bennée
2022-04-19 19:19   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rrzx0qk.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.