From: Chandan Babu R <chandan.babu@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 07/17] xfs: convert AGI log flags to unsigned.
Date: Mon, 11 Apr 2022 19:19:05 +0530 [thread overview]
Message-ID: <878rsbvige.fsf@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <20220411003147.2104423-8-david@fromorbit.com>
On 11 Apr 2022 at 06:01, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> 5.18 w/ std=gnu11 compiled with gcc-5 wants flags stored in unsigned
> fields to be unsigned.
>
Looks correct.
Reviewed-by: Chandan Babu R <chandan.babu@oracle.com>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/libxfs/xfs_format.h | 30 +++++++++++++++---------------
> fs/xfs/libxfs/xfs_ialloc.c | 6 +++---
> fs/xfs/libxfs/xfs_ialloc.h | 2 +-
> 3 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
> index 65e24847841e..0d6fa199a896 100644
> --- a/fs/xfs/libxfs/xfs_format.h
> +++ b/fs/xfs/libxfs/xfs_format.h
> @@ -619,22 +619,22 @@ typedef struct xfs_agi {
>
> #define XFS_AGI_CRC_OFF offsetof(struct xfs_agi, agi_crc)
>
> -#define XFS_AGI_MAGICNUM (1 << 0)
> -#define XFS_AGI_VERSIONNUM (1 << 1)
> -#define XFS_AGI_SEQNO (1 << 2)
> -#define XFS_AGI_LENGTH (1 << 3)
> -#define XFS_AGI_COUNT (1 << 4)
> -#define XFS_AGI_ROOT (1 << 5)
> -#define XFS_AGI_LEVEL (1 << 6)
> -#define XFS_AGI_FREECOUNT (1 << 7)
> -#define XFS_AGI_NEWINO (1 << 8)
> -#define XFS_AGI_DIRINO (1 << 9)
> -#define XFS_AGI_UNLINKED (1 << 10)
> +#define XFS_AGI_MAGICNUM (1u << 0)
> +#define XFS_AGI_VERSIONNUM (1u << 1)
> +#define XFS_AGI_SEQNO (1u << 2)
> +#define XFS_AGI_LENGTH (1u << 3)
> +#define XFS_AGI_COUNT (1u << 4)
> +#define XFS_AGI_ROOT (1u << 5)
> +#define XFS_AGI_LEVEL (1u << 6)
> +#define XFS_AGI_FREECOUNT (1u << 7)
> +#define XFS_AGI_NEWINO (1u << 8)
> +#define XFS_AGI_DIRINO (1u << 9)
> +#define XFS_AGI_UNLINKED (1u << 10)
> #define XFS_AGI_NUM_BITS_R1 11 /* end of the 1st agi logging region */
> -#define XFS_AGI_ALL_BITS_R1 ((1 << XFS_AGI_NUM_BITS_R1) - 1)
> -#define XFS_AGI_FREE_ROOT (1 << 11)
> -#define XFS_AGI_FREE_LEVEL (1 << 12)
> -#define XFS_AGI_IBLOCKS (1 << 13) /* both inobt/finobt block counters */
> +#define XFS_AGI_ALL_BITS_R1 ((1u << XFS_AGI_NUM_BITS_R1) - 1)
> +#define XFS_AGI_FREE_ROOT (1u << 11)
> +#define XFS_AGI_FREE_LEVEL (1u << 12)
> +#define XFS_AGI_IBLOCKS (1u << 13) /* both inobt/finobt block counters */
> #define XFS_AGI_NUM_BITS_R2 14
>
> /* disk block (xfs_daddr_t) in the AG */
> diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c
> index b418fe0c0679..54c2be6a2972 100644
> --- a/fs/xfs/libxfs/xfs_ialloc.c
> +++ b/fs/xfs/libxfs/xfs_ialloc.c
> @@ -2414,9 +2414,9 @@ xfs_imap(
> */
> void
> xfs_ialloc_log_agi(
> - xfs_trans_t *tp, /* transaction pointer */
> - struct xfs_buf *bp, /* allocation group header buffer */
> - int fields) /* bitmask of fields to log */
> + struct xfs_trans *tp,
> + struct xfs_buf *bp,
> + uint32_t fields)
> {
> int first; /* first byte number */
> int last; /* last byte number */
> diff --git a/fs/xfs/libxfs/xfs_ialloc.h b/fs/xfs/libxfs/xfs_ialloc.h
> index 8b5c2b709022..a7705b6a1fd3 100644
> --- a/fs/xfs/libxfs/xfs_ialloc.h
> +++ b/fs/xfs/libxfs/xfs_ialloc.h
> @@ -60,7 +60,7 @@ void
> xfs_ialloc_log_agi(
> struct xfs_trans *tp, /* transaction pointer */
> struct xfs_buf *bp, /* allocation group header buffer */
> - int fields); /* bitmask of fields to log */
> + uint32_t fields); /* bitmask of fields to log */
>
> /*
> * Read in the allocation group header (inode allocation section)
--
chandan
next prev parent reply other threads:[~2022-04-11 13:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 0:31 [PATCH 00/17] xfs: unsigned flags conversion for c11 Dave Chinner
2022-04-11 0:31 ` [PATCH 01/17] xfs: convert buffer flags to unsigned Dave Chinner
2022-04-11 10:05 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 02/17] xfs: convert attr type " Dave Chinner
2022-04-11 10:23 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 03/17] xfs: convert scrub " Dave Chinner
2022-04-11 10:33 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 04/17] xfs: convert bmap extent " Dave Chinner
2022-04-11 10:42 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 05/17] xfs: convert bmapi " Dave Chinner
2022-04-11 12:53 ` Chandan Babu R
2022-04-11 13:44 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 06/17] xfs: convert AGF log " Dave Chinner
2022-04-11 13:27 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 07/17] xfs: convert AGI " Dave Chinner
2022-04-11 13:49 ` Chandan Babu R [this message]
2022-04-11 0:31 ` [PATCH 08/17] xfs: convert btree buffer " Dave Chinner
2022-04-11 14:03 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 09/17] xfs: convert buffer log item " Dave Chinner
2022-04-12 7:25 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 10/17] xfs: convert da btree operations " Dave Chinner
2022-04-12 7:25 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 11/17] xfs: convert dquot " Dave Chinner
2022-04-12 7:26 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 12/17] xfs: convert log item tracepoint " Dave Chinner
2022-04-12 7:26 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 13/17] xfs: convert inode lock " Dave Chinner
2022-04-12 7:26 ` Chandan Babu R
2022-04-12 8:43 ` Dave Chinner
2022-04-21 0:44 ` [PATCH 13/17 v2] " Dave Chinner
2022-04-21 3:07 ` Alli
2022-04-21 9:15 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 14/17] xfs: convert ptag " Dave Chinner
2022-04-12 7:26 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 15/17] xfs: convert quota options " Dave Chinner
2022-04-12 7:26 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 16/17] xfs: convert shutdown reasons " Dave Chinner
2022-04-12 7:27 ` Chandan Babu R
2022-04-11 0:31 ` [PATCH 17/17] xfs: convert log ticket and iclog flags " Dave Chinner
2022-04-12 7:27 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rsbvige.fsf@debian-BULLSEYE-live-builder-AMD64 \
--to=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.