All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Jonas Jelonek <jelonek.jonas@gmail.com>,
	"linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>, "nbd\@nbd.name" <nbd@nbd.name>,
	Thomas Huehn <thomas.huehn@hs-nordhausen.de>
Subject: Re: [PATCH] ath9k: switch to rate table based lookup
Date: Mon, 29 Nov 2021 10:48:46 +0200	[thread overview]
Message-ID: <878rx7gxe9.fsf@codeaurora.org> (raw)
In-Reply-To: <87lf1aahrw.fsf@toke.dk> ("Toke \=\?utf-8\?Q\?H\=C3\=B8iland-J\?\= \=\?utf-8\?Q\?\=C3\=B8rgensen\=22's\?\= message of "Fri, 26 Nov 2021 19:33:39 +0100")

Toke Høiland-Jørgensen <toke@redhat.com> writes:

> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> Jonas Jelonek <jelonek.jonas@gmail.com> writes:
>>
>>>> And how did you test this? Are both PCI and USB devices affected?
>>>
>>> I tested this on a 8devices Rambutan with QCA9558 SoC, but didn‘t
>>> explicitly test this with a USB device. I am not sure whether the
>>> ath9k_htc is affected. First I tested this without the patch to get a
>>> reference for comparison. I connected three devices via WiFi 2.4GHz
>>> and 5GHz, generated traffic multiple times with iperf3 and captured
>>> the rc_stats for each station. Then I applied the patch and did the
>>> same again. The throughput was overall the same like without the
>>> patch, compared to the first run of each station. Rate selection
>>> worked fine, the stats were nearly identical, same rates selected in
>>> both runs.
>>
>> Thanks. Can someone review this from ath9k_htc point of view?
>
> Pretty sure ath9k_htc devices do rate control in the firmware. Certainly
> ath9k_htc sets the HAS_RATE_CONTROL flag in mac80211, and the only calls
> to ath_set_rates are from within xmit.c, which is not used by ath9k_htc.
> So I think we're fine as far as that is concerned...

Very good, thanks for checking.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      reply	other threads:[~2021-11-29  8:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 12:16 [PATCH] ath9k: switch to rate table based lookup Jonas Jelonek
2021-11-25 16:05 ` Toke Høiland-Jørgensen
2021-11-25 22:38   ` Jonas Jelonek
2021-11-26 12:01     ` Toke Høiland-Jørgensen
2021-11-26  7:07   ` Kalle Valo
     [not found]     ` <CAChE-vTktHRW1JR8s1NNnLOqfBihd=5T2qXDsQDyBeecw95U0g@mail.gmail.com>
2021-11-26 14:59       ` Kalle Valo
2021-11-26 18:33         ` Toke Høiland-Jørgensen
2021-11-29  8:48           ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rx7gxe9.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=jelonek.jonas@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=thomas.huehn@hs-nordhausen.de \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.