From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD0BC433FE for ; Fri, 1 Oct 2021 17:51:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 962B461A10 for ; Fri, 1 Oct 2021 17:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355477AbhJARwo (ORCPT ); Fri, 1 Oct 2021 13:52:44 -0400 Received: from foss.arm.com ([217.140.110.172]:49486 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355237AbhJARwn (ORCPT ); Fri, 1 Oct 2021 13:52:43 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 40986106F; Fri, 1 Oct 2021 10:50:59 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 942EC3F70D; Fri, 1 Oct 2021 10:50:57 -0700 (PDT) From: Valentin Schneider To: Frederic Weisbecker , "Paul E . McKenney" Cc: LKML , Frederic Weisbecker , Sebastian Andrzej Siewior , Peter Zijlstra , Uladzislau Rezki , Thomas Gleixner , Boqun Feng , Neeraj Upadhyay , Josh Triplett , Joel Fernandes , rcu@vger.kernel.org Subject: Re: [PATCH 07/11] rcu/nocb: Use appropriate rcu_nocb_lock_irqsave() In-Reply-To: <20210929221012.228270-8-frederic@kernel.org> References: <20210929221012.228270-1-frederic@kernel.org> <20210929221012.228270-8-frederic@kernel.org> Date: Fri, 01 Oct 2021 18:50:55 +0100 Message-ID: <878rzcmy68.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/09/21 00:10, Frederic Weisbecker wrote: > Instead of hardcoding IRQ save and nocb lock, use the consolidated > API. > > Signed-off-by: Frederic Weisbecker > Cc: Valentin Schneider > Cc: Peter Zijlstra > Cc: Sebastian Andrzej Siewior > Cc: Josh Triplett > Cc: Joel Fernandes > Cc: Boqun Feng > Cc: Neeraj Upadhyay > Cc: Uladzislau Rezki > Cc: Thomas Gleixner Just one comment nit below. Reviewed-by: Valentin Schneider > --- > kernel/rcu/tree.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index b1fc6e498d90..1971a4e15e96 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -2492,8 +2492,7 @@ static void rcu_do_batch(struct rcu_data *rdp) While at it: - * Extract the list of ready callbacks, disabling to prevent +- * Extract the list of ready callbacks, disabling IRQs to prevent > * races with call_rcu() from interrupt handlers. Leave the > * callback counts, as rcu_barrier() needs to be conservative. > */ > - local_irq_save(flags); > - rcu_nocb_lock(rdp); > + rcu_nocb_lock_irqsave(rdp, flags); > WARN_ON_ONCE(cpu_is_offline(smp_processor_id())); > pending = rcu_segcblist_n_cbs(&rdp->cblist); > div = READ_ONCE(rcu_divisor);