From: Richard Palethorpe <rpalethorpe@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] msgrcv07: Check negative msg type filters
Date: Fri, 24 Sep 2021 11:30:52 +0100 [thread overview]
Message-ID: <878rzml0yr.fsf@suse.de> (raw)
In-Reply-To: <YU2n6tamyCf13OS5@pevik>
Hello Petr,
Petr Vorel <pvorel@suse.cz> writes:
> Hi Richie,
>
> ...
>> +++ b/testcases/kernel/syscalls/ipc/msgrcv/msgrcv07.c
>> @@ -232,6 +232,13 @@ static void test_negative_msgtyp(void)
>> "-msgtyp didn't get the first message in the queue with the lowest type");
>> }
>
>> + TST_EXP_FAIL(msgrcv(queue_id, &rcv_buf, MSGSIZE, -MSGTYPE1, IPC_NOWAIT),
>> + ENOMSG,
>> + "-msgtype didn't recv next lowest msg");
>> + TST_EXP_FAIL(msgrcv(queue_id, &rcv_buf, MSGSIZE, -MSGTYPE1, MSG_EXCEPT | IPC_NOWAIT),
>> + ENOMSG,
>> + "-msgtype (with except) didn't recv next lowest msg");
> nit: I'd use msgtyp instead of msgtype (although it looks like typo, it's used
> without 'e' as a parametr name in man msgop(2) and also throughout this test
> (obviously can be changed during merge).
Sure, sounds good.
>
> Kind regards,
> Petr
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-09-24 10:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 9:21 [LTP] [PATCH 1/2] msgrcv07: Check negative msg type filters Richard Palethorpe via ltp
2021-09-24 9:21 ` [LTP] [PATCH 2/2] msgrcv07: Cleanup indentation Richard Palethorpe via ltp
2021-09-24 10:22 ` Petr Vorel
2021-09-24 10:21 ` [LTP] [PATCH 1/2] msgrcv07: Check negative msg type filters Petr Vorel
2021-09-24 10:26 ` Petr Vorel
2021-09-24 10:30 ` Richard Palethorpe [this message]
2021-10-08 14:14 ` Cyril Hrubis
2021-10-11 8:46 ` Richard Palethorpe
2021-10-11 12:57 ` Cyril Hrubis
2021-10-13 6:56 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rzml0yr.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.