From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4323C433EF for ; Wed, 22 Sep 2021 13:12:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 735E061100 for ; Wed, 22 Sep 2021 13:12:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 735E061100 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:46910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT22v-0000OF-F7 for qemu-devel@archiver.kernel.org; Wed, 22 Sep 2021 09:12:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT1y4-0002zs-4r for qemu-devel@nongnu.org; Wed, 22 Sep 2021 09:07:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT1y0-0000KC-C9 for qemu-devel@nongnu.org; Wed, 22 Sep 2021 09:07:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632316035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aDM7xOqS5HjF6fVHT1+JkA7AXGph9YObLe5E6VBatXs=; b=INdXEYE3tcFKxQWLa5TEBDRXP1ejH7hvyqCZcAtLhvGhO1kGgJEHVD0+ABUe61u+BmvUZK oLN4IUKEw0sLfxcmFrzaKwbRou/Wx+XdSq6mFzAgkOf/sxQqfWwi2RAvxWubLqBrV86qGp qZPIgeOU9yp0yl9BLlWbP3+7AvKCFBI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-444-mMVwcUf8Ory4Xo0VrS8Q4A-1; Wed, 22 Sep 2021 09:07:14 -0400 X-MC-Unique: mMVwcUf8Ory4Xo0VrS8Q4A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 059C784A5E7; Wed, 22 Sep 2021 13:07:13 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-14.ams2.redhat.com [10.36.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CBF145DEB8; Wed, 22 Sep 2021 13:07:12 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 646F9113865F; Wed, 22 Sep 2021 15:07:11 +0200 (CEST) From: Markus Armbruster To: BALATON Zoltan Subject: Re: ensuring a machine's buses have unique names References: <87czq0l2mn.fsf@dusky.pond.sub.org> <87mtoe4g40.fsf@dusky.pond.sub.org> <71bb7b84-28a3-dd4b-d375-4b2494832655@eik.bme.hu> <87y27przt6.fsf@dusky.pond.sub.org> <79a46e17-ddae-eab8-9ff6-80c3a64d0cb@eik.bme.hu> Date: Wed, 22 Sep 2021 15:07:11 +0200 In-Reply-To: <79a46e17-ddae-eab8-9ff6-80c3a64d0cb@eik.bme.hu> (BALATON Zoltan's message of "Wed, 22 Sep 2021 11:58:24 +0200 (CEST)") Message-ID: <878rzokbcw.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.472, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Philippe =?utf-8?Q?Mathieu-?= =?utf-8?Q?Daud=C3=A9?= , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" BALATON Zoltan writes: > On Wed, 22 Sep 2021, Markus Armbruster wrote: >> BALATON Zoltan writes: >>> To me it looks like device code can't really set a globally unique >>> name on creating the bus without getting some help from upper >>> levels. So maybe naming busses should be done by qdev (or whatever is >>> handling this) instead of passing the name as an argument to >>> qbus_create or only use that name as a unique component within the >>> device and append it to a unique name for the device. >> >> Have you read the whole thread? qdev does come up with a name when > > No I haven't. This just got my attention because I'm responsible for > adding ati-vga.ddc and sm501.i2c and some ppc440 stuff so I was > wondering what could I do better bur otherwise I did not check the > whole thread so just ignore what I said if it's not useful in this > context. I wouldn't call it "not useful". What you could do better in future code: pass a null bus name. This is not obvious. As Peter noted "we created a family of easy-to-misuse APIs". [...]