From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36DABC433EF for ; Thu, 9 Sep 2021 08:16:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E04EB60FE3 for ; Thu, 9 Sep 2021 08:16:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E04EB60FE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:49070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOFEN-0003Qd-51 for qemu-devel@archiver.kernel.org; Thu, 09 Sep 2021 04:16:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOFBk-0001Fg-Md for qemu-devel@nongnu.org; Thu, 09 Sep 2021 04:13:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:50208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOFBh-0000sl-Pr for qemu-devel@nongnu.org; Thu, 09 Sep 2021 04:13:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631175216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jYXDQR+pORKNgcMJKDuBa2NvBT5zDkMlQWRe8f24o3E=; b=i24zXr3UhepzSxOb9yx6keSAhDAmhSxUlNANZ22qZhMWZKpkrn/2KgvuRtJwV8RYmePK1A YEfSZKDI3heEUYqMF8UOKQoOyRUwesuVJuH1hcWry0AvdBrJH7AXGwUP1+JRrSefgXPMW8 Dl1+hmVpGTjdUgRSUKst5tjOfWxsNJ0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-BfRTgLTJOE6_Knw27Ov6ig-1; Thu, 09 Sep 2021 04:13:34 -0400 X-MC-Unique: BfRTgLTJOE6_Knw27Ov6ig-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AEC76362F8; Thu, 9 Sep 2021 08:13:33 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-14.ams2.redhat.com [10.36.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80DA46A904; Thu, 9 Sep 2021 08:13:33 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3B6121138606; Thu, 9 Sep 2021 10:13:32 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Subject: Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all References: <20210908103711.683940-1-berrange@redhat.com> <875yvbrtnq.fsf@dusky.pond.sub.org> <87lf46pd62.fsf@dusky.pond.sub.org> Date: Thu, 09 Sep 2021 10:13:32 +0200 In-Reply-To: <87lf46pd62.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Thu, 09 Sep 2021 06:48:21 +0200") Message-ID: <878s06p3o3.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.393, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Eric Blake , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Markus Armbruster writes: [...] > Limitations: > > 1. If we convert a long-running HMP command to this technique, we print > its output only after it completed its work. We also end up with a > long-running QMP command, which is bad, because it stops the main > loop and makes the QMP monitor unresponsive (except for OOB commands, > if the client is careful). The former can be mitigated with > 'coroutine': true. The latter can't. > > 2. We can't prompt for input. > > The only current use I can see is HMP "change vnc passwd" prompting > for a password. Except you currently have to say "change vnc passwd > wtf" to get it to prompt (suspect logic error in commit cfb5387a1de). Subject: [PATCH 1/2] hmp: Unbreak "change vnc" Message-Id: <20210909081219.308065-2-armbru@redhat.com> > > > [...]