From: Kalle Valo <kvalo@codeaurora.org>
To: chris.chiu@canonical.com
Cc: Jes.Sorensen@gmail.com, davem@davemloft.net, kuba@kernel.org,
code@reto-schneider.ch, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rtl8xxxu: unset the hw capability HAS_RATE_CONTROL
Date: Thu, 03 Jun 2021 12:51:00 +0300 [thread overview]
Message-ID: <878s3r1dkr.fsf@codeaurora.org> (raw)
In-Reply-To: <20210531090254.86830-2-chris.chiu@canonical.com> (chris chiu's message of "Mon, 31 May 2021 17:02:53 +0800")
chris.chiu@canonical.com writes:
> From: Chris Chiu <chris.chiu@canonical.com>
>
> The HAS_RATE_CONTROL hw capability needs to be unset for the rate
> control of mac80211 to work. Since the ieee80211_start_tx_ba_session
> is started by the method .get_rate of rate_control_ops. We need to
> unset it so the ampdu can be handled by mac80211.
The commit log is not really describing in detail _why_ you are doing
this. Switching the rate control from hardware/firmware to mac80211 is a
major change and I want to see a good explanation why this is the right
thing to do and does not cause any regressions.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-06-03 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 9:02 [PATCH 0/2] Make ampdu tx work correctly chris.chiu
2021-05-31 9:02 ` [PATCH 1/2] rtl8xxxu: unset the hw capability HAS_RATE_CONTROL chris.chiu
2021-06-03 9:51 ` Kalle Valo [this message]
2021-05-31 9:02 ` [PATCH 2/2] rtl8xxxu: Fix ampdu_action to get block ack session work chris.chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s3r1dkr.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Jes.Sorensen@gmail.com \
--cc=chris.chiu@canonical.com \
--cc=code@reto-schneider.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.