From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78BB3C433ED for ; Mon, 17 May 2021 22:27:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49EDF611BF for ; Mon, 17 May 2021 22:27:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242445AbhEQW2h (ORCPT ); Mon, 17 May 2021 18:28:37 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:45557 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234910AbhEQW2g (ORCPT ); Mon, 17 May 2021 18:28:36 -0400 Date: 18 May 2021 07:27:16 +0900 X-IronPort-AV: E=Sophos;i="5.82,307,1613401200"; d="scan'208";a="81415967" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 18 May 2021 07:27:16 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id DB2B74003EC1; Tue, 18 May 2021 07:27:16 +0900 (JST) Message-ID: <878s4dc7y3.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Geert Uytterhoeven Cc: Magnus , Linux-Renesas , Kazuya Mizuguchi , Yoshihiro Shimoda , hoai.luu.ub@renesas.com, Takeshi Kihara , Harunobu Kurokawa , Khiem Nguyen , Hien Dang Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a77995: add R-Car Sound support In-Reply-To: References: <87k0nyci2t.wl-kuninori.morimoto.gx@renesas.com> <87h7j2ci1k.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert > > From: Kuninori Morimoto > > > > This patch adds R-Car Sound and Audio-DMAC support for D3. > > > > 1st note is that D3 doesn't have audio-clk-c, but is > > required from driver. This patch uses null-clk for it. > > > > 2nd note is that D3 has SSI3/4 and SRC5/6 only, but driver > > requres from SSI0/SRC0. This patch has disabled SSI/SRC for it. > > I think it would be better to fix the driver instead. We already have this kind of SoC before. And I guess it has these, but just not counnected. It is Hardware side condition. > > + /* > > + * R8A77995 doesn't have audio_clk_c, * but is required from driver. > > + * Create NULL clock for it. > > + */ > > + null_clk: null_clk { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <0>; > > + }; > > Please do not add nodes not matching the hardware description, but fix > the driver instead. ("DT describes hardware, not software policy"). Yeah, I agree. Will fix driver first, and repost SoC patch, again. Thank you for your help !! Best regards --- Kuninori Morimoto