From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E345C433DB for ; Thu, 25 Mar 2021 15:47:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3DDD61A17 for ; Thu, 25 Mar 2021 15:47:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3DDD61A17 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPSCn-0005eW-UP for qemu-devel@archiver.kernel.org; Thu, 25 Mar 2021 11:47:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPS7M-00072N-HW for qemu-devel@nongnu.org; Thu, 25 Mar 2021 11:41:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPS7K-0001PA-QN for qemu-devel@nongnu.org; Thu, 25 Mar 2021 11:41:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616686909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YqLiT+Vuwz91Yo5hDAQzXuZ4RZ8NhyJSp+E0z/tCyfs=; b=evCIUKyUMzeQOvGKF3OQ0L70asul5S+SPmMZ9eLAAWLS7vqNRIjFjIkVScXJmvpup1/qbE WiRJCziwgcUiHec5XolHYEWXzSrqxDEGpi7KzZuL3sAnXPPSKccrXZzo1St3gea/y/NWkG qh4HtlLvmI1sdOztnwFXcEx0moSzhRk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-OIxnHkWNNQqO7ykyL0GV5g-1; Thu, 25 Mar 2021 11:41:47 -0400 X-MC-Unique: OIxnHkWNNQqO7ykyL0GV5g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F16F107AFF7; Thu, 25 Mar 2021 15:41:47 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3AE060854; Thu, 25 Mar 2021 15:41:46 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 74E8211327E1; Thu, 25 Mar 2021 16:41:45 +0100 (CET) From: Markus Armbruster To: John Snow Subject: Re: [PATCH v4 01/19] qapi/expr: Comment cleanup References: <20210325060356.4040114-1-jsnow@redhat.com> <20210325060356.4040114-2-jsnow@redhat.com> Date: Thu, 25 Mar 2021 16:41:45 +0100 In-Reply-To: <20210325060356.4040114-2-jsnow@redhat.com> (John Snow's message of "Thu, 25 Mar 2021 02:03:38 -0400") Message-ID: <878s6bme9y.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Cleber Rosa , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > Fixes: 0825f62c842 For a slightly peculiar value of "fixes" ;) > Signed-off-by: John Snow > --- > scripts/qapi/expr.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py > index 540b3982b1..c207481f7e 100644 > --- a/scripts/qapi/expr.py > +++ b/scripts/qapi/expr.py > @@ -241,7 +241,7 @@ def check_enum(expr, info): > source = "%s '%s'" % (source, member_name) > # Enum members may start with a digit > if member_name[0].isdigit(): > - member_name = 'd' + member_name # Hack: hide the digit > + member_name = 'd' + member_name # Hack: hide the digit > check_name_lower(member_name, info, source, > permit_upper=permissive, > permit_underscore=permissive)