From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95939C433E0 for ; Wed, 5 Aug 2020 08:43:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5982E21744 for ; Wed, 5 Aug 2020 08:43:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RYEaX2wR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5982E21744 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3F0s-0006RZ-AM for qemu-devel@archiver.kernel.org; Wed, 05 Aug 2020 04:43:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3F0I-00062L-CY for qemu-devel@nongnu.org; Wed, 05 Aug 2020 04:42:30 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:45484 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k3F0G-0007wJ-OD for qemu-devel@nongnu.org; Wed, 05 Aug 2020 04:42:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596616947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2/CAYCy0r5vD0lC/OXz0VUZo7AT4gVOUIMsFASm0M6Y=; b=RYEaX2wRr7fy3YDve6oCZFdgpQxHKUXIpXMgN6Zfm2V/FssHSFB7qdnDVMT6mGAMFUPt0g g5AvKGcym44NIpQ7h9tMcxwUbycAP1de5nEEK4SV/z8B3tGDXlCIdShb1aP33+05aQNYPX 6MnQjE5sGS9PSJGKirUguwT84aDjLDo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-228-yK1VOcheNI2JTCODre0bVQ-1; Wed, 05 Aug 2020 04:42:26 -0400 X-MC-Unique: yK1VOcheNI2JTCODre0bVQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3BED618C63C1; Wed, 5 Aug 2020 08:42:25 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2E92C1001901; Wed, 5 Aug 2020 08:42:14 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B88331141D60; Wed, 5 Aug 2020 10:42:12 +0200 (CEST) From: Markus Armbruster To: Paolo Bonzini Subject: Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline) References: <20200729185024.121766-1-abologna@redhat.com> <87ime52wxd.fsf@dusky.pond.sub.org> <20200730093732.GB3477223@redhat.com> <87k0ylz0ep.fsf@dusky.pond.sub.org> <20200730132446.GL3477223@redhat.com> <875za33ku1.fsf@dusky.pond.sub.org> <20200731150738.GB3660103@redhat.com> <2cf1a431-9d2c-8ad6-446e-f10b36219764@redhat.com> <87d048i1m2.fsf@dusky.pond.sub.org> <83bbe0b0-c5e0-e3b7-5ba1-5946098370d5@redhat.com> <87ft94klyl.fsf@dusky.pond.sub.org> <490a0786-73f3-411e-4dfe-8c2ae90de251@redhat.com> <87y2mvhg3k.fsf@dusky.pond.sub.org> Date: Wed, 05 Aug 2020 10:42:12 +0200 In-Reply-To: <87y2mvhg3k.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Mon, 03 Aug 2020 18:03:11 +0200") Message-ID: <878set5vrv.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/05 04:10:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" , Eduardo Habkost , qemu-block@nongnu.org, Juan Quintela , Jason Wang , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Yuval Shaia , Gerd Hoffmann , Andrea Bolognani , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , John Snow , Michael Roth , "Dr. David Alan Gilbert" , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Markus Armbruster writes: > Paolo Bonzini writes: [...] >> That said, after a bit more research I'm skeptical about the possibility >> of using an off-the-shelf parser because most of them either don't >> support comments, or are based on YAJL which simply discards comments. >> >> Since '//' comments are harder to parse than "#" comments, this would >> actually _add_ code instead of removing it. Also since our doc comment >> syntax uses "##" as a delimiter, we'd have to bikeshed what the doc >> comments would look like ("//!", "///", etc.). > > Doc comments don't have to be comments in the schema language. They > could be doc strings. Requires decent support for long strings, which > JSON does not provide. There's another complication besides multi-line strings: funny characters. Since QAPI schema strings are all names, and names are restricted to ASCII letters, digits, hyphen, and underscore, we limit strings to printable ASCII, so we don't have to deal with control characters, escape sequences, surrogate pairs, and all that crap. Comments are UTF-8. [...]