From: Kalle Valo <firstname.lastname@example.org> To: Brian Norris <email@example.com> Cc: Navid Emamdoost <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, Kangjie Lu <email@example.com>, QCA ath9k Development <firstname.lastname@example.org>, "David S. Miller" <email@example.com>, linux-wireless <firstname.lastname@example.org>, "\<netdev\@vger.kernel.org\>" <email@example.com>, Linux Kernel <firstname.lastname@example.org> Subject: Re: [PATCH] ath9k: release allocated buffer if timed out Date: Wed, 13 May 2020 10:05:00 +0300 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <CA+ASDXMnp-GTkrT7B5O+dtopJUmGBay=Tn=-nf1LW1MtaVOrfirstname.lastname@example.org> (Brian Norris's message of "Tue, 12 May 2020 09:56:47 -0700") Brian Norris <email@example.com> writes: > On Fri, Sep 6, 2019 at 11:59 AM Navid Emamdoost > <firstname.lastname@example.org> wrote: >> >> In ath9k_wmi_cmd, the allocated network buffer needs to be released >> if timeout happens. Otherwise memory will be leaked. >> >> Signed-off-by: Navid Emamdoost <email@example.com> > > I wonder, did you actually test your patches? I ask, because it seems > that all your patches are of the same mechanical variety (produced by > some sort of research project?), and if I look around a bit, I see > several mistakes and regressions noted on your other patches. And > recently, I see someone reporting a 5.4 kernel regression, which looks > a lot like it was caused by this patch: > > https://bugzilla.kernel.org/show_bug.cgi?id=207703#c1 > > I'll propose a revert, if there's no evidence this was actually tested > or otherwise confirmed to fix a real bug. Actually it's already reverted in -next, nobody just realised that it's a regression from commit 728c1e2a05e4: ced21a4c726b ath9k: Fix use-after-free Read in htc_connect_service v5.8-rc1 should be the first release having the fix. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-05-13 7:05 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-06 18:59 Navid Emamdoost 2019-09-10 13:32 ` Kalle Valo 2020-05-12 16:56 ` Brian Norris 2020-05-13 3:24 ` Navid Emamdoost 2020-05-13 19:12 ` Brian Norris 2020-05-13 7:05 ` Kalle Valo [this message] 2020-05-13 19:02 ` Brian Norris 2020-05-20 20:59 ` Brian Norris 2020-05-22 10:34 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] ath9k: release allocated buffer if timed out' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.