From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65833C43141 for ; Mon, 2 Dec 2019 10:30:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45AF42070B for ; Mon, 2 Dec 2019 10:30:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727573AbfLBKa3 (ORCPT ); Mon, 2 Dec 2019 05:30:29 -0500 Received: from mga01.intel.com ([192.55.52.88]:10411 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727567AbfLBKa2 (ORCPT ); Mon, 2 Dec 2019 05:30:28 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 02:30:28 -0800 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="204505581" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 02:30:25 -0800 From: Jani Nikula To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Chris Wilson , Martin Peres , Joonas Lahtinen , Rodrigo Vivi , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: Update bug URL to point at gitlab issues In-Reply-To: <20191125104248.1690891-1-chris@chris-wilson.co.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191125104248.1690891-1-chris@chris-wilson.co.uk> Date: Mon, 02 Dec 2019 12:30:22 +0200 Message-ID: <878snvkojl.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, 25 Nov 2019, Chris Wilson wrote: > We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so > update the user instructions accordingly. > > Signed-off-by: Chris Wilson > Cc: Martin Peres > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Jani Nikula > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- > drivers/gpu/drm/i915/i915_utils.c | 3 +-- > drivers/gpu/drm/i915/i915_utils.h | 2 ++ > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index 2b30a45fa25c..1cf53fd4fe66 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915, > if (!xchg(&warned, true) && > ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) { > pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n"); > - pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n"); > + pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n"); > pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n"); > pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n"); > pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n", > diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c > index c47261ae86ea..9b68b21becf1 100644 > --- a/drivers/gpu/drm/i915/i915_utils.c > +++ b/drivers/gpu/drm/i915/i915_utils.c > @@ -8,8 +8,7 @@ > #include "i915_drv.h" > #include "i915_utils.h" > > -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI" > -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \ > +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \ > "providing the dmesg log by booting with drm.debug=0xf" Space between URL and "providing"? > > void > diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h > index 04139ba1191e..13674b016092 100644 > --- a/drivers/gpu/drm/i915/i915_utils.h > +++ b/drivers/gpu/drm/i915/i915_utils.h > @@ -34,6 +34,8 @@ > struct drm_i915_private; > struct timer_list; > > +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?" Do we really need the question mark? BR, Jani. > + > #undef WARN_ON > /* Many gcc seem to no see through this and fall over :( */ > #if 0 -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Update bug URL to point at gitlab issues Date: Mon, 02 Dec 2019 12:30:22 +0200 Message-ID: <878snvkojl.fsf@intel.com> References: <20191125104248.1690891-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20191125104248.1690891-1-chris@chris-wilson.co.uk> Sender: stable-owner@vger.kernel.org To: intel-gfx@lists.freedesktop.org Cc: Chris Wilson , Martin Peres , Joonas Lahtinen , Rodrigo Vivi , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 25 Nov 2019, Chris Wilson wrote: > We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so > update the user instructions accordingly. > > Signed-off-by: Chris Wilson > Cc: Martin Peres > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Jani Nikula > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- > drivers/gpu/drm/i915/i915_utils.c | 3 +-- > drivers/gpu/drm/i915/i915_utils.h | 2 ++ > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index 2b30a45fa25c..1cf53fd4fe66 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915, > if (!xchg(&warned, true) && > ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) { > pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n"); > - pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n"); > + pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n"); > pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n"); > pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n"); > pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n", > diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c > index c47261ae86ea..9b68b21becf1 100644 > --- a/drivers/gpu/drm/i915/i915_utils.c > +++ b/drivers/gpu/drm/i915/i915_utils.c > @@ -8,8 +8,7 @@ > #include "i915_drv.h" > #include "i915_utils.h" > > -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI" > -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \ > +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \ > "providing the dmesg log by booting with drm.debug=0xf" Space between URL and "providing"? > > void > diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h > index 04139ba1191e..13674b016092 100644 > --- a/drivers/gpu/drm/i915/i915_utils.h > +++ b/drivers/gpu/drm/i915/i915_utils.h > @@ -34,6 +34,8 @@ > struct drm_i915_private; > struct timer_list; > > +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?" Do we really need the question mark? BR, Jani. > + > #undef WARN_ON > /* Many gcc seem to no see through this and fall over :( */ > #if 0 -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C83CC432C0 for ; Mon, 2 Dec 2019 10:30:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E156320718 for ; Mon, 2 Dec 2019 10:30:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E156320718 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 78D486E0E3; Mon, 2 Dec 2019 10:30:29 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id A749E6E0E3 for ; Mon, 2 Dec 2019 10:30:28 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 02:30:28 -0800 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="204505581" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 02:30:25 -0800 From: Jani Nikula To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20191125104248.1690891-1-chris@chris-wilson.co.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191125104248.1690891-1-chris@chris-wilson.co.uk> Date: Mon, 02 Dec 2019 12:30:22 +0200 Message-ID: <878snvkojl.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update bug URL to point at gitlab issues X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191202103022.9qYNRUXvZmLuwE0JPqkGKB17NFfsW6IVGtuZQfs9c7k@z> T24gTW9uLCAyNSBOb3YgMjAxOSwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IFdlIGFyZSBtb3Zpbmcgb3VyIGlzc3VlIHRyYWNraW5nIG92ZXIgZnJvbSBi dWdzLmZkLm8gdG8gZ2l0bGFiLmZkLm8sIHNvCj4gdXBkYXRlIHRoZSB1c2VyIGluc3RydWN0aW9u cyBhY2NvcmRpbmdseS4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+IENjOiBNYXJ0aW4gUGVyZXMgPG1hcnRpbi5wZXJlc0BsaW51eC5p bnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4Lmlu dGVsLmNvbT4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IENj OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IENjOiBzdGFibGVAdmdlci5r ZXJuZWwub3JnCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMg fCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdXRpbHMuYyAgICAgfCAzICstLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxzLmggICAgIHwgMiArKwo+ICAzIGZpbGVz IGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+IGluZGV4IDJiMzBhNDVmYTI1Yy4uMWNmNTNmZDRmZTY2 IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jCj4gQEAgLTE4MTcsNyAr MTgxNyw3IEBAIHZvaWQgaTkxNV9jYXB0dXJlX2Vycm9yX3N0YXRlKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICppOTE1LAo+ICAJaWYgKCF4Y2hnKCZ3YXJuZWQsIHRydWUpICYmCj4gIAkgICAga3Rp bWVfZ2V0X3JlYWxfc2Vjb25kcygpIC0gRFJJVkVSX1RJTUVTVEFNUCA8IERBWV9BU19TRUNPTkRT KDE4MCkpIHsKPiAgCQlwcl9pbmZvKCJHUFUgaGFuZ3MgY2FuIGluZGljYXRlIGEgYnVnIGFueXdo ZXJlIGluIHRoZSBlbnRpcmUgZ2Z4IHN0YWNrLCBpbmNsdWRpbmcgdXNlcnNwYWNlLlxuIik7Cj4g LQkJcHJfaW5mbygiUGxlYXNlIGZpbGUgYSBfbmV3XyBidWcgcmVwb3J0IG9uIGJ1Z3MuZnJlZWRl c2t0b3Aub3JnIGFnYWluc3QgRFJJIC0+IERSTS9JbnRlbFxuIik7Cj4gKwkJcHJfaW5mbygiUGxl YXNlIGZpbGUgYSBfbmV3XyBidWcgcmVwb3J0IG9uICIgRkRPX0JVR19VUkwgIlxuIik7Cj4gIAkJ cHJfaW5mbygiZHJtL2k5MTUgZGV2ZWxvcGVycyBjYW4gdGhlbiByZWFzc2lnbiB0byB0aGUgcmln aHQgY29tcG9uZW50IGlmIGl0J3Mgbm90IGEga2VybmVsIGlzc3VlLlxuIik7Cj4gIAkJcHJfaW5m bygiVGhlIEdQVSBjcmFzaCBkdW1wIGlzIHJlcXVpcmVkIHRvIGFuYWx5emUgR1BVIGhhbmdzLCBz byBwbGVhc2UgYWx3YXlzIGF0dGFjaCBpdC5cbiIpOwo+ICAJCXByX2luZm8oIkdQVSBjcmFzaCBk dW1wIHNhdmVkIHRvIC9zeXMvY2xhc3MvZHJtL2NhcmQlZC9lcnJvclxuIiwKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV91dGlscy5jCj4gaW5kZXggYzQ3MjYxYWU4NmVhLi45YjY4YjIxYmVjZjEgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5jCj4gQEAgLTgsOCArOCw3IEBACj4gICNpbmNsdWRl ICJpOTE1X2Rydi5oIgo+ICAjaW5jbHVkZSAiaTkxNV91dGlscy5oIgo+ICAKPiAtI2RlZmluZSBG RE9fQlVHX1VSTCAiaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9lbnRlcl9idWcuY2dpP3By b2R1Y3Q9RFJJIgo+IC0jZGVmaW5lIEZET19CVUdfTVNHICJQbGVhc2UgZmlsZSBhIGJ1ZyBhdCAi IEZET19CVUdfVVJMICIgYWdhaW5zdCBEUk0vSW50ZWwgIiBcCj4gKyNkZWZpbmUgRkRPX0JVR19N U0cgIlBsZWFzZSBmaWxlIGEgYnVnIGF0ICIgRkRPX0JVR19VUkwgXAo+ICAJCSAgICAicHJvdmlk aW5nIHRoZSBkbWVzZyBsb2cgYnkgYm9vdGluZyB3aXRoIGRybS5kZWJ1Zz0weGYiCgpTcGFjZSBi ZXR3ZWVuIFVSTCBhbmQgInByb3ZpZGluZyI/Cgo+ICAKPiAgdm9pZAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxzLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3V0aWxzLmgKPiBpbmRleCAwNDEzOWJhMTE5MWUuLjEzNjc0YjAxNjA5MiAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxzLmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3V0aWxzLmgKPiBAQCAtMzQsNiArMzQsOCBAQAo+ICBzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZTsKPiAgc3RydWN0IHRpbWVyX2xpc3Q7Cj4gIAo+ICsjZGVmaW5lIEZET19C VUdfVVJMICJodHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5vcmcvZHJtL2ludGVsL2lzc3Vlcy9u ZXc/IgoKRG8gd2UgcmVhbGx5IG5lZWQgdGhlIHF1ZXN0aW9uIG1hcms/CgpCUiwKSmFuaS4KCj4g Kwo+ICAjdW5kZWYgV0FSTl9PTgo+ICAvKiBNYW55IGdjYyBzZWVtIHRvIG5vIHNlZSB0aHJvdWdo IHRoaXMgYW5kIGZhbGwgb3ZlciA6KCAqLwo+ICAjaWYgMAoKLS0gCkphbmkgTmlrdWxhLCBJbnRl bCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4