From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE46FFA3728 for ; Wed, 16 Oct 2019 23:50:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF2162168B for ; Wed, 16 Oct 2019 23:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391432AbfJPXu5 (ORCPT ); Wed, 16 Oct 2019 19:50:57 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:25929 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728701AbfJPXu5 (ORCPT ); Wed, 16 Oct 2019 19:50:57 -0400 Date: 17 Oct 2019 08:50:54 +0900 X-IronPort-AV: E=Sophos;i="5.67,305,1566831600"; d="scan'208";a="29271370" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 17 Oct 2019 08:50:54 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 067A44008C75; Thu, 17 Oct 2019 08:50:43 +0900 (JST) Message-ID: <878spkuu5o.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Eugeniu Rosca Cc: Linux-Renesas , Takashi Iwai , Jaroslav Kysela , Mark Brown , Liam Girdwood , , , Eugeniu Rosca , Junya Monden , Andrew Gabbasov , Jiada Wang , Timo Wischer , Subject: Re: [PATCH] ASoC: rsnd: Reinitialize bit clock inversion flag for every format setting In-Reply-To: <20191016124255.7442-1-erosca@de.adit-jv.com> References: <20191016124255.7442-1-erosca@de.adit-jv.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi > Unlike other format-related DAI parameters, rdai->bit_clk_inv flag > is not properly re-initialized when setting format for new stream > processing. The inversion, if requested, is then applied not to default, > but to a previous value, which leads to SCKP bit in SSICR register being > set incorrectly. > Fix this by re-setting the flag to its initial value, determined by format. > > Fixes: 1a7889ca8aba3 ("ASoC: rsnd: fixup SND_SOC_DAIFMT_xB_xF behavior") > Cc: Andrew Gabbasov > Cc: Jiada Wang > Cc: Timo Wischer > Cc: stable@vger.kernel.org # v3.17+ > Signed-off-by: Junya Monden > Signed-off-by: Eugeniu Rosca > --- Acked-by: Kuninori Morimoto From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B82ECE599 for ; Wed, 16 Oct 2019 23:51:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1256021848 for ; Wed, 16 Oct 2019 23:51:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="F4j3cG47" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1256021848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D630B823; Thu, 17 Oct 2019 01:51:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D630B823 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1571269916; bh=O5+0lujfMkdBtBSJg318VVGBKo6VVmjW1FPan6UPMcE=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=F4j3cG4789ZFgHOQUlQlUWsPdZ2Z9kLy8SpbxplEpcSx4H2aU6tcoLsUtlxVwg4Ux 16J0xg+JMxkqs6M7U2jN08Q7CraSOoOSxEVz7nyYk8Q1kySq0kklB326SqdbzICKwZ iTZPXP6F+SPU26zjC8IMfuIhVfPMc5FhWz/kliDs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 562C3F80323; Thu, 17 Oct 2019 01:51:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 407A3F80362; Thu, 17 Oct 2019 01:51:04 +0200 (CEST) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id 9D4E7F80322 for ; Thu, 17 Oct 2019 01:50:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9D4E7F80322 Date: 17 Oct 2019 08:50:54 +0900 X-IronPort-AV: E=Sophos;i="5.67,305,1566831600"; d="scan'208";a="29271370" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 17 Oct 2019 08:50:54 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 067A44008C75; Thu, 17 Oct 2019 08:50:43 +0900 (JST) Message-ID: <878spkuu5o.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Eugeniu Rosca In-Reply-To: <20191016124255.7442-1-erosca@de.adit-jv.com> References: <20191016124255.7442-1-erosca@de.adit-jv.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Timo Wischer , alsa-devel@alsa-project.org, Andrew Gabbasov , Eugeniu Rosca , Jiada Wang , linux-kernel@vger.kernel.org, Liam Girdwood , stable@vger.kernel.org, Takashi Iwai , Linux-Renesas , Mark Brown , Junya Monden Subject: Re: [alsa-devel] [PATCH] ASoC: rsnd: Reinitialize bit clock inversion flag for every format setting X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi > Unlike other format-related DAI parameters, rdai->bit_clk_inv flag > is not properly re-initialized when setting format for new stream > processing. The inversion, if requested, is then applied not to default, > but to a previous value, which leads to SCKP bit in SSICR register being > set incorrectly. > Fix this by re-setting the flag to its initial value, determined by format. > > Fixes: 1a7889ca8aba3 ("ASoC: rsnd: fixup SND_SOC_DAIFMT_xB_xF behavior") > Cc: Andrew Gabbasov > Cc: Jiada Wang > Cc: Timo Wischer > Cc: stable@vger.kernel.org # v3.17+ > Signed-off-by: Junya Monden > Signed-off-by: Eugeniu Rosca > --- Acked-by: Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel