From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Keith Packard" <keithp@keithp.com>
Subject: Re: [PATCH 3/3] drm/lease: look at ->universal_planes only once
Date: Fri, 02 Nov 2018 08:04:32 -0700
Message-ID: <878t2btta7.fsf@keithp.com>
References: <20181102132543.16486-1-daniel.vetter@ffwll.ch>
 <20181102132543.16486-3-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1766621460=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20181102132543.16486-3-daniel.vetter@ffwll.ch>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com>
List-Id: dri-devel@lists.freedesktop.org

--===============1766621460==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Daniel Vetter <daniel.vetter@ffwll.ch> writes:

> @@ -359,7 +359,8 @@ void drm_lease_revoke(struct drm_master *top)
>  static int validate_lease(struct drm_device *dev,
>  			  struct drm_file *lessor_priv,
>  			  int object_count,
> -			  struct drm_mode_object **objects)
> +			  struct drm_mode_object **objects,
> +			  bool universal_planes)

It looks like you can remove the lessor_priv argument here, which would
ensure that we didn't reference any fields in it in the future.

=2D-=20
=2Dkeith

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlvcZ4AACgkQ2yIaaQAA
ABHIZw//fh5NDilmv690OdvpiniaZDweoEWkPfIqdaJJOBq2vcVhxRxymzQxX+/y
BHSSJwFhwlHwQc1H86uETD/u1h1AvSv+GD47Bn+33hBtuSSgf9yQEcisTrVwl+uw
YzNZ3CM8EJkmAUxQpDcNYKCjxFYpJ6AOn22onikwcU09SarGMrMt5M/GVDVQ4DjE
EqGgDnYrrLLAkg6H6TI5TEMfA5TsuuHB05VdUSLVeaZ3T73UqFUYI/KLOQAw7JZa
260DiIRfiL3N3+BvHoV757AwdvagZm/ELBx20hw6mhxOZTpZzAfx5qd3dFgx4eqU
wtSGDfFWZolMy0q2QPJs8+QqxZlH6uTIQjzzKlEtABhJPrRPIXjtYVDb5p4KFCq8
6wqb4nzlh9xGrrlNihDAPrgkXSadJECQw4fDuYuoTCSkX6u3atV2KRTqFaspGRTT
e1nubuaB2Ad27/mwsI4u3xOURqaXCcEALMYeUxW6CcriRrZ1YlLVTtb4eYyuBXUl
7kSoNXH5IGA3Fm1RteCaDbEBj6Mh713t/Nb0HCLxGPKjCp+VgPZnZ17GnrBAD9jG
AZAkM1uwwnxfU6uBToyz2t1neVhbxfInSp4ne1tCmgbCgZKX0q1X0OCwdVBrGeFx
aF3oRE9LDf5awhlpNKVnVkASg9swUEKgy0WlhpFImZ+gSouA3zo=
=fXKP
-----END PGP SIGNATURE-----
--=-=-=--

--===============1766621460==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============1766621460==--