From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [PATCH net-next 01/19] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE Date: Tue, 09 Oct 2018 15:37:47 +0200 Message-ID: <878t379r6c.fsf@miraculix.mork.no> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: "David S . Miller" , "linux-usb\@vger.kernel.org" , "netdev\@vger.kernel.org" , Dmitry Bezrukov To: Igor Russkikh Return-path: Received: from canardo.mork.no ([148.122.252.1]:35187 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726522AbeJIUy7 (ORCPT ); Tue, 9 Oct 2018 16:54:59 -0400 In-Reply-To: (Igor Russkikh's message of "Fri, 5 Oct 2018 10:24:39 +0000") Sender: netdev-owner@vger.kernel.org List-ID: Igor Russkikh writes: >> +static const struct driver_info aqc111_info =3D { > + .description =3D "Aquantia AQtion USB to 5GbE Controller", > +}; > + > +#define AQC111_USB_ETH_DEV(vid, pid, table) \ > + .match_flags =3D USB_DEVICE_ID_MATCH_DEVICE | \ > + USB_DEVICE_ID_MATCH_INT_CLASS, \ > + USB_DEVICE(vid, pid), \ > + .bInterfaceClass =3D USB_CLASS_VENDOR_SPEC, \ > + .driver_info =3D (unsigned long)&table, \ > +}, \ > +{ \ > + .match_flags =3D USB_DEVICE_ID_MATCH_DEVICE | \ > + USB_DEVICE_ID_MATCH_INT_INFO, \ > + USB_DEVICE(vid, pid), \ > + .bInterfaceClass =3D USB_CLASS_COMM, \ > + .bInterfaceSubClass =3D USB_CDC_SUBCLASS_ETHERNET, \ > + .bInterfaceProtocol =3D USB_CDC_PROTO_NONE > + Is the missing .driver_info for the CDC class intentional? If so, then why include it at all? Bj=C3=B8rn From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [net-next,01/19] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE From: =?utf-8?q?Bj=C3=B8rn_Mork?= Message-Id: <878t379r6c.fsf@miraculix.mork.no> Date: Tue, 09 Oct 2018 15:37:47 +0200 To: Igor Russkikh Cc: "David S . Miller" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , Dmitry Bezrukov List-ID: SWdvciBSdXNza2lraCA8SWdvci5SdXNza2lraEBhcXVhbnRpYS5jb20+IHdyaXRlczoKCj4+ICtz dGF0aWMgY29uc3Qgc3RydWN0IGRyaXZlcl9pbmZvIGFxYzExMV9pbmZvID0gewo+ICsJLmRlc2Ny aXB0aW9uCT0gIkFxdWFudGlhIEFRdGlvbiBVU0IgdG8gNUdiRSBDb250cm9sbGVyIiwKPiArfTsK PiArCj4gKyNkZWZpbmUgQVFDMTExX1VTQl9FVEhfREVWKHZpZCwgcGlkLCB0YWJsZSkgXAo+ICsJ Lm1hdGNoX2ZsYWdzID0gVVNCX0RFVklDRV9JRF9NQVRDSF9ERVZJQ0UgfCBcCj4gKwkJCVVTQl9E RVZJQ0VfSURfTUFUQ0hfSU5UX0NMQVNTLCBcCj4gKwlVU0JfREVWSUNFKHZpZCwgcGlkKSwgXAo+ ICsJLmJJbnRlcmZhY2VDbGFzcyA9IFVTQl9DTEFTU19WRU5ET1JfU1BFQywgXAo+ICsJLmRyaXZl cl9pbmZvID0gKHVuc2lnbmVkIGxvbmcpJnRhYmxlLCBcCj4gK30sIFwKPiAreyBcCj4gKwkubWF0 Y2hfZmxhZ3MgPSBVU0JfREVWSUNFX0lEX01BVENIX0RFVklDRSB8IFwKPiArCQkJVVNCX0RFVklD RV9JRF9NQVRDSF9JTlRfSU5GTywgXAo+ICsJVVNCX0RFVklDRSh2aWQsIHBpZCksIFwKPiArCS5i SW50ZXJmYWNlQ2xhc3MgPSBVU0JfQ0xBU1NfQ09NTSwgXAo+ICsJLmJJbnRlcmZhY2VTdWJDbGFz cyA9IFVTQl9DRENfU1VCQ0xBU1NfRVRIRVJORVQsIFwKPiArCS5iSW50ZXJmYWNlUHJvdG9jb2wg PSBVU0JfQ0RDX1BST1RPX05PTkUKPiArCgpJcyB0aGUgbWlzc2luZyAuZHJpdmVyX2luZm8gZm9y IHRoZSBDREMgY2xhc3MgaW50ZW50aW9uYWw/ICBJZiBzbywgdGhlbgp3aHkgaW5jbHVkZSBpdCBh dCBhbGw/CgoKCkJqw7hybgo=