From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751312AbeBVUIM (ORCPT ); Thu, 22 Feb 2018 15:08:12 -0500 Received: from anholt.net ([50.246.234.109]:35688 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbeBVUIL (ORCPT ); Thu, 22 Feb 2018 15:08:11 -0500 From: Eric Anholt To: Arnd Bergmann Cc: Arnd Bergmann , David Airlie , Linus Walleij , Daniel Vetter , Stephen Boyd , Tom Cooksey , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/p[111: add CONFIG_OF dependency In-Reply-To: <20180222162420.2825703-1-arnd@arndb.de> References: <20180222162420.2825703-1-arnd@arndb.de> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Thu, 22 Feb 2018 12:08:08 -0800 Message-ID: <878tbkaitz.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Arnd Bergmann writes: > We cannot select a symbol without meeting its other dependencies: > > warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) > drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': > drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has no member named 'of_node' > vga->bridge.of_node = pdev->dev.of_node; > ^ > > Here it seems reasonable to depend on CONFIG_OF, as all platforms > using this driver already require that anyway. Looks like we'll be going with https://patchwork.freedesktop.org/patch/205580/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlqPIygACgkQtdYpNtH8 nugBJQ//Q4AzkWW4EpUVzY0YWgKs0fvcC0IiH0PDba6Z4WLKAAkC0fxHNlh65MwW 8OklOV5aaoikY0DmSs15ls0CIr5kFReGllTav/u+Os0oHLfehh9uAm9m4VXbkNsU hCD6uQx56Jq4uXgxlYeM602aKlOChz+cFyhtuUneRGzqrQtPrl5T4hZ+59gUra6l F4RRg/K9BsHNiarcAO5O8Ttz1ZTNSRzj2k2g+AM0iyFaTGhpN29Nls4oavJSFTSC NG46D0t0Ogzr7EGRE4RX7dpsMds3/6XE8P+NWEgOCGtb4PkOmFtttG25WtgbKU4J LelbcGMRBMO8wd5Z6Ajp3U0jdn7JLPmhK+jUxmoLGMZbwj2+F9O7RePSoj7l2SF7 XdUUBdqMQoIHu4rTEljZiTb7TtnWzPxYpYYxJG911VQUQJR75w76LzpDWPz47Ipf YAmcDa22xMTHQ0ec4nwsEtHm1xdWpHHByDCcWVNb8J76Bw013Gs8fRP3XKT7IgX7 21Zqju0rAZrD9qDJo/CpK90PUk6yCGpGysmGOjD35lznPTUsY/umL9RnZrUGa6j9 fift1TRKXUitpCUWxls3H25X2OFyDYn6K+OsyR9yJIVY75LEN+8XTes830rouMqL goVDDVQf5X3TliN6p5grdelA7feKzt3mNNE4cIbst1AEs+i68Is= =QxGZ -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/p[111: add CONFIG_OF dependency Date: Thu, 22 Feb 2018 12:08:08 -0800 Message-ID: <878tbkaitz.fsf@anholt.net> References: <20180222162420.2825703-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1927338845==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CB0E6E0F9 for ; Thu, 22 Feb 2018 20:08:11 +0000 (UTC) In-Reply-To: <20180222162420.2825703-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Cc: Arnd Bergmann , David Airlie , Daniel Vetter , Stephen Boyd , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1927338845== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Arnd Bergmann writes: > We cannot select a symbol without meeting its other dependencies: > > warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) > drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': > drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has no member named 'of_node' > vga->bridge.of_node = pdev->dev.of_node; > ^ > > Here it seems reasonable to depend on CONFIG_OF, as all platforms > using this driver already require that anyway. Looks like we'll be going with https://patchwork.freedesktop.org/patch/205580/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlqPIygACgkQtdYpNtH8 nugBJQ//Q4AzkWW4EpUVzY0YWgKs0fvcC0IiH0PDba6Z4WLKAAkC0fxHNlh65MwW 8OklOV5aaoikY0DmSs15ls0CIr5kFReGllTav/u+Os0oHLfehh9uAm9m4VXbkNsU hCD6uQx56Jq4uXgxlYeM602aKlOChz+cFyhtuUneRGzqrQtPrl5T4hZ+59gUra6l F4RRg/K9BsHNiarcAO5O8Ttz1ZTNSRzj2k2g+AM0iyFaTGhpN29Nls4oavJSFTSC NG46D0t0Ogzr7EGRE4RX7dpsMds3/6XE8P+NWEgOCGtb4PkOmFtttG25WtgbKU4J LelbcGMRBMO8wd5Z6Ajp3U0jdn7JLPmhK+jUxmoLGMZbwj2+F9O7RePSoj7l2SF7 XdUUBdqMQoIHu4rTEljZiTb7TtnWzPxYpYYxJG911VQUQJR75w76LzpDWPz47Ipf YAmcDa22xMTHQ0ec4nwsEtHm1xdWpHHByDCcWVNb8J76Bw013Gs8fRP3XKT7IgX7 21Zqju0rAZrD9qDJo/CpK90PUk6yCGpGysmGOjD35lznPTUsY/umL9RnZrUGa6j9 fift1TRKXUitpCUWxls3H25X2OFyDYn6K+OsyR9yJIVY75LEN+8XTes830rouMqL goVDDVQf5X3TliN6p5grdelA7feKzt3mNNE4cIbst1AEs+i68Is= =QxGZ -----END PGP SIGNATURE----- --=-=-=-- --===============1927338845== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1927338845==--