From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2268niIaiK1z3kwL50++1PEbUBXmuGoH2tKAJxP2PVRFo8cPRK/cy1MTHK7x5XXdXirN7dTx ARC-Seal: i=1; a=rsa-sha256; t=1517399488; cv=none; d=google.com; s=arc-20160816; b=ebMYctYgqXs5AQvwzn9+AV/E/xNBH3gJZEmGUvmlOemL8iYZ2Kck7dDIz9j3m59THg UB97pzAY5w6RxIn/BLRZqfzZwh2EEQM5o0y4onmbF5DtywLQvzRBQh4Cd6JLXDsRWnFp SDfwK7fucNhyyvT9DLi5pOv2s1qhlJavoc9hxudP+SiBUSP/xRjyjh6CoAG/ehxNlJnF BN4ztwGfVmNHCxb7Ny6VegAN6z+ILAakodX5qdZe96OxOElKQBPT7t0d+ILNAQNVk9QK wtA3HmLC9fUF2WgjpcSEGUYU4I/dqXdLfq2PuLmvLCc/KRk0dfOl6OiNG7bu4NhNpQMO tmFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:message-id:date:references:organization:in-reply-to :subject:cc:to:from:arc-authentication-results; bh=sDbVNVIZwNQ7pEdMofMPrY6f8cgJci8xslhdeQ6wfdE=; b=rp+LESXy+hsLzGw42SIQaJjjurPOwM2JkXFMLCML/zaITLhNn8e7kDiLX3jjWYgkaU WvOl8rbn8WT5UY+OIv8JOOCfopRzGF2M+Qh20gIaGAnDPDdAZr12XJu9ESIMhJVrkPND A7giCP3LtakxmU3L5EetGKwUjWCi/Vz6IbCV/HOcbPS0hqcKImgiqbp0UhUfMWKqU0gH j9uq8HXAEsO3RzSjLhUURNUNkxx9FzToVlaWtua98ywSS9UoAFXDfRbMcKFM3a7lC0Hl HNgZGFJHhpE4/vk1GAPbF4uuGt9tczul9WOcp/TzzF/L4t+yc9K1N3l/vrfJI4YfWtY5 FSqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of jani.nikula@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=jani.nikula@intel.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of jani.nikula@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=jani.nikula@intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,439,1511856000"; d="scan'208";a="26917323" From: Jani Nikula To: Daniel Thompson , Aishwarya Pant Cc: Milo Kim , linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jingoo Han , Jonathan Corbet , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Julia Lawall , Greg KH , Lee Jones Subject: Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes In-Reply-To: <20180131110727.rmmwyqzwozwhda6z@oak.lan> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <6523e26889d3dd65e90ea27c0d302a95aeb9da8b.1516978005.git.aishpant@gmail.com> <20180131110727.rmmwyqzwozwhda6z@oak.lan> Date: Wed, 31 Jan 2018 13:51:21 +0200 Message-ID: <878tceckli.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590666949916676069?= X-GMAIL-MSGID: =?utf-8?q?1591108686008944068?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, 31 Jan 2018, Daniel Thompson wrote: > On Fri, Jan 26, 2018 at 08:20:08PM +0530, Aishwarya Pant wrote: >> Add documentation for sysfs interfaces of lp8788 backlight driver by >> looking through the code and the git commit history. >> >> Signed-off-by: Aishwarya Pant >> --- >> Documentation/ABI/testing/sysfs-class-backlight-lp8788 | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp8788 >> >> diff --git a/Documentation/ABI/testing/sysfs-class-backlight-lp8788 b/Documentation/ABI/testing/sysfs-class-backlight-lp8788 >> new file mode 100644 >> index 000000000000..c0e565c8d63d >> --- /dev/null >> +++ b/Documentation/ABI/testing/sysfs-class-backlight-lp8788 >> @@ -0,0 +1,10 @@ >> +sysfs interface for Texas Instruments lp8788 mfd backlight driver >> +----------------------------------------------------------------- >> + >> +What: /sys/class/backlight//bl_ctl_mode >> +Date: Feb, 2013 >> +KernelVersion: v3.10 >> +Contact: Milo Kim >> +Description: >> + (RO) Displays whether the brightness is controlled by the PWM >> + input("PWM based") or the I2C register("Register based"). > > I rather dislike drivers with this type of "bonus" sysfs controls. I'm > struggling to come up with any reason why the userspace would want to > read this control (and I think bl_ctl_mode gets the fewest hits after > searching with google hits of any search I've tried) . It looks to me > like this is debug information that should never have gone into sysfs > at all. Agreed. I think the same holds for the other extra sysfs attributes. At worst, having these prevents the backlight class from adding the names later on, which is just backwards. BR, Jani. > > So I think this is either something that should go directly into > ABI/obsolete (with a fairly short expiry time) or perhaps simply > remove the property entirely. > > > Daniel. > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Wed, 31 Jan 2018 11:51:21 +0000 Subject: Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes Message-Id: <878tceckli.fsf@intel.com> List-Id: References: <6523e26889d3dd65e90ea27c0d302a95aeb9da8b.1516978005.git.aishpant@gmail.com> <20180131110727.rmmwyqzwozwhda6z@oak.lan> In-Reply-To: <20180131110727.rmmwyqzwozwhda6z@oak.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Thompson , Aishwarya Pant Cc: Milo Kim , linux-fbdev@vger.kernel.org, Jonathan Corbet , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Julia Lawall , Greg KH , Lee Jones On Wed, 31 Jan 2018, Daniel Thompson wrote: > On Fri, Jan 26, 2018 at 08:20:08PM +0530, Aishwarya Pant wrote: >> Add documentation for sysfs interfaces of lp8788 backlight driver by >> looking through the code and the git commit history. >> >> Signed-off-by: Aishwarya Pant >> --- >> Documentation/ABI/testing/sysfs-class-backlight-lp8788 | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp8788 >> >> diff --git a/Documentation/ABI/testing/sysfs-class-backlight-lp8788 b/Documentation/ABI/testing/sysfs-class-backlight-lp8788 >> new file mode 100644 >> index 000000000000..c0e565c8d63d >> --- /dev/null >> +++ b/Documentation/ABI/testing/sysfs-class-backlight-lp8788 >> @@ -0,0 +1,10 @@ >> +sysfs interface for Texas Instruments lp8788 mfd backlight driver >> +----------------------------------------------------------------- >> + >> +What: /sys/class/backlight//bl_ctl_mode >> +Date: Feb, 2013 >> +KernelVersion: v3.10 >> +Contact: Milo Kim >> +Description: >> + (RO) Displays whether the brightness is controlled by the PWM >> + input("PWM based") or the I2C register("Register based"). > > I rather dislike drivers with this type of "bonus" sysfs controls. I'm > struggling to come up with any reason why the userspace would want to > read this control (and I think bl_ctl_mode gets the fewest hits after > searching with google hits of any search I've tried) . It looks to me > like this is debug information that should never have gone into sysfs > at all. Agreed. I think the same holds for the other extra sysfs attributes. At worst, having these prevents the backlight class from adding the names later on, which is just backwards. BR, Jani. > > So I think this is either something that should go directly into > ABI/obsolete (with a fairly short expiry time) or perhaps simply > remove the property entirely. > > > Daniel. > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes Date: Wed, 31 Jan 2018 13:51:21 +0200 Message-ID: <878tceckli.fsf@intel.com> References: <6523e26889d3dd65e90ea27c0d302a95aeb9da8b.1516978005.git.aishpant@gmail.com> <20180131110727.rmmwyqzwozwhda6z@oak.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8469F6E595 for ; Wed, 31 Jan 2018 11:51:28 +0000 (UTC) In-Reply-To: <20180131110727.rmmwyqzwozwhda6z@oak.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Thompson , Aishwarya Pant Cc: Milo Kim , linux-fbdev@vger.kernel.org, Jonathan Corbet , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Julia Lawall , Greg KH , Lee Jones List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAzMSBKYW4gMjAxOCwgRGFuaWVsIFRob21wc29uIDxkYW5pZWwudGhvbXBzb25AbGlu YXJvLm9yZz4gd3JvdGU6Cj4gT24gRnJpLCBKYW4gMjYsIDIwMTggYXQgMDg6MjA6MDhQTSArMDUz MCwgQWlzaHdhcnlhIFBhbnQgd3JvdGU6Cj4+IEFkZCBkb2N1bWVudGF0aW9uIGZvciBzeXNmcyBp bnRlcmZhY2VzIG9mIGxwODc4OCBiYWNrbGlnaHQgZHJpdmVyIGJ5Cj4+IGxvb2tpbmcgdGhyb3Vn aCB0aGUgY29kZSBhbmQgdGhlIGdpdCBjb21taXQgaGlzdG9yeS4KPj4gCj4+IFNpZ25lZC1vZmYt Ynk6IEFpc2h3YXJ5YSBQYW50IDxhaXNocGFudEBnbWFpbC5jb20+Cj4+IC0tLQo+PiAgRG9jdW1l bnRhdGlvbi9BQkkvdGVzdGluZy9zeXNmcy1jbGFzcy1iYWNrbGlnaHQtbHA4Nzg4IHwgMTAgKysr KysrKysrKwo+PiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKykKPj4gIGNyZWF0ZSBt b2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL3N5c2ZzLWNsYXNzLWJhY2tsaWdo dC1scDg3ODgKPj4gCj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL3N5 c2ZzLWNsYXNzLWJhY2tsaWdodC1scDg3ODggYi9Eb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL3N5 c2ZzLWNsYXNzLWJhY2tsaWdodC1scDg3ODgKPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPj4gaW5k ZXggMDAwMDAwMDAwMDAwLi5jMGU1NjVjOGQ2M2QKPj4gLS0tIC9kZXYvbnVsbAo+PiArKysgYi9E b2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL3N5c2ZzLWNsYXNzLWJhY2tsaWdodC1scDg3ODgKPj4g QEAgLTAsMCArMSwxMCBAQAo+PiArc3lzZnMgaW50ZXJmYWNlIGZvciBUZXhhcyBJbnN0cnVtZW50 cyBscDg3ODggbWZkIGJhY2tsaWdodCBkcml2ZXIKPj4gKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+ICsKPj4gK1doYXQ6 CQkvc3lzL2NsYXNzL2JhY2tsaWdodC88YmFja2xpZ2h0Pi9ibF9jdGxfbW9kZQo+PiArRGF0ZToJ CUZlYiwgMjAxMwo+PiArS2VybmVsVmVyc2lvbjoJdjMuMTAKPj4gK0NvbnRhY3Q6CU1pbG8gS2lt IDxtaWxvLmtpbUB0aS5jb20+Cj4+ICtEZXNjcmlwdGlvbjoKPj4gKwkJKFJPKSBEaXNwbGF5cyB3 aGV0aGVyIHRoZSBicmlnaHRuZXNzIGlzIGNvbnRyb2xsZWQgYnkgdGhlIFBXTQo+PiArCQlpbnB1 dCgiUFdNIGJhc2VkIikgb3IgdGhlIEkyQyByZWdpc3RlcigiUmVnaXN0ZXIgYmFzZWQiKS4KPgo+ IEkgcmF0aGVyIGRpc2xpa2UgZHJpdmVycyB3aXRoIHRoaXMgdHlwZSBvZiAiYm9udXMiIHN5c2Zz IGNvbnRyb2xzLiBJJ20KPiBzdHJ1Z2dsaW5nIHRvIGNvbWUgdXAgd2l0aCBhbnkgcmVhc29uIHdo eSB0aGUgdXNlcnNwYWNlIHdvdWxkIHdhbnQgdG8KPiByZWFkIHRoaXMgY29udHJvbCAoYW5kIEkg dGhpbmsgYmxfY3RsX21vZGUgZ2V0cyB0aGUgZmV3ZXN0IGhpdHMgYWZ0ZXIKPiBzZWFyY2hpbmcg d2l0aCBnb29nbGUgaGl0cyBvZiBhbnkgc2VhcmNoIEkndmUgdHJpZWQpIC4gSXQgbG9va3MgdG8g bWUgCj4gbGlrZSB0aGlzIGlzIGRlYnVnIGluZm9ybWF0aW9uIHRoYXQgc2hvdWxkIG5ldmVyIGhh dmUgZ29uZSBpbnRvIHN5c2ZzIAo+IGF0IGFsbC4KCkFncmVlZC4gSSB0aGluayB0aGUgc2FtZSBo b2xkcyBmb3IgdGhlIG90aGVyIGV4dHJhIHN5c2ZzIGF0dHJpYnV0ZXMuIEF0CndvcnN0LCBoYXZp bmcgdGhlc2UgcHJldmVudHMgdGhlIGJhY2tsaWdodCBjbGFzcyBmcm9tIGFkZGluZyB0aGUgbmFt ZXMKbGF0ZXIgb24sIHdoaWNoIGlzIGp1c3QgYmFja3dhcmRzLgoKQlIsCkphbmkuCgoKPgo+IFNv IEkgdGhpbmsgdGhpcyBpcyBlaXRoZXIgc29tZXRoaW5nIHRoYXQgc2hvdWxkIGdvIGRpcmVjdGx5 IGludG8KPiBBQkkvb2Jzb2xldGUgKHdpdGggYSBmYWlybHkgc2hvcnQgZXhwaXJ5IHRpbWUpIG9y IHBlcmhhcHMgc2ltcGx5Cj4gcmVtb3ZlIHRoZSBwcm9wZXJ0eSBlbnRpcmVseS4KPgo+Cj4gRGFu aWVsLgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g ZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK