From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSIoe-0001fE-Hp for qemu-devel@nongnu.org; Tue, 04 Jul 2017 04:04:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSIob-0004LQ-Dp for qemu-devel@nongnu.org; Tue, 04 Jul 2017 04:04:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34700) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dSIob-0004KX-6f for qemu-devel@nongnu.org; Tue, 04 Jul 2017 04:04:09 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D7DBA80F79 for ; Tue, 4 Jul 2017 08:04:07 +0000 (UTC) From: Markus Armbruster References: <1499049848-18012-1-git-send-email-peterx@redhat.com> <1499049848-18012-5-git-send-email-peterx@redhat.com> Date: Tue, 04 Jul 2017 10:04:01 +0200 In-Reply-To: <1499049848-18012-5-git-send-email-peterx@redhat.com> (Peter Xu's message of "Mon, 3 Jul 2017 10:44:08 +0800") Message-ID: <878tk4sk5q.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 4/4] doc: update TYPE_MIGRATION documents List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Laurent Vivier , Eduardo Habkost , "Dr . David Alan Gilbert" , Juan Quintela Peter Xu writes: > [Peter collected Eduardo's patch comment and formatted into patch] > > Suggested-by: Eduardo Habkost > Signed-off-by: Peter Xu > --- > migration/migration.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index dbdc121..6c64b99 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -2052,12 +2052,15 @@ static void migration_instance_init(Object *obj) > static const TypeInfo migration_type = { > .name = TYPE_MIGRATION, > /* > - * NOTE: "migration" itself is not really a device. We used > - * TYPE_DEVICE here only to leverage some existing QDev features > - * like "-global" properties, and HW_COMPAT_* fields (which are > - * finally applied as global properties as well). If one day the > - * global property feature can be migrated from QDev to QObject in > - * general, then we can switch to QObject as well. > + * NOTE: > + * > + * TYPE_MIGRATION is not really a device, as the object is not > + * created using qdev_create(), it is not attached to the qdev > + * device tree, and it is never realized. > + * > + * If one day we allow non-device QOM objects to use the global > + * property system, we can switch this from TYPE_DEVICE to > + * TYPE_OBJECT. Suggest to turn this paragraph into a TODO: * TODO Make this TYPE_OBJECT once QOM provides something like * TYPE_DEVICE's "-global" properties. > */ > .parent = TYPE_DEVICE, > .class_init = migration_class_init,