From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:47274 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbdF0OFu (ORCPT ); Tue, 27 Jun 2017 10:05:50 -0400 From: Kalle Valo To: Arend van Spriel Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH 2/4] brcmfmac: use atomic_t for statistic counter in struct brcmf_bus References: <1498125664-25980-1-git-send-email-arend.vanspriel@broadcom.com> <1498125664-25980-3-git-send-email-arend.vanspriel@broadcom.com> Date: Tue, 27 Jun 2017 17:05:45 +0300 In-Reply-To: <1498125664-25980-3-git-send-email-arend.vanspriel@broadcom.com> (Arend van Spriel's message of "Thu, 22 Jun 2017 11:01:02 +0100") Message-ID: <878tkd5xvq.fsf@purkki.adurom.net> (sfid-20170627_160553_415465_E1BCE187) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Arend van Spriel writes: > The statistic counter is used in common layer and in the bus layer > in different thread contexts so change to use atomic operations. > > Reviewed-by: Hante Meuleman > Reviewed-by: Pieter-Paul Giesberts > Reviewed-by: Franky Lin > Signed-off-by: Arend van Spriel > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h | 2 +- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h > index e2c895b..e1a4d9e 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h > @@ -138,7 +138,7 @@ struct brcmf_bus { > struct brcmf_pub *drvr; > enum brcmf_bus_state state; > uint maxctl; > - unsigned long tx_realloc; > + atomic_t tx_realloc; > u32 chip; > u32 chiprev; > bool always_use_fws_queue; > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > index 81f9594..a280536 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > @@ -2046,7 +2046,7 @@ static int brcmf_sdio_txpkt_hdalign(struct brcmf_sdio *bus, struct sk_buff *pkt) > head_pad = ((unsigned long)dat_buf % bus->head_align); > if (head_pad) { > if (skb_headroom(pkt) < head_pad) { > - bus->sdiodev->bus_if->tx_realloc++; > + atomic_inc(&bus->sdiodev->bus_if->tx_realloc); What's the point of this field? AFAICS it's only incremented but never read. What am I missing? -- Kalle Valo