From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:50261 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965361AbdCWQLK (ORCPT ); Thu, 23 Mar 2017 12:11:10 -0400 From: Kalle Valo To: Erik Stromdahl CC: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Subject: Re: [RFC v4 06/21] ath10k: sdio support Date: Thu, 23 Mar 2017 16:10:45 +0000 Message-ID: <878tnwynwb.fsf@kamboji.qca.qualcomm.com> (sfid-20170323_171123_105578_CCD3780E) References: <1487693741-10042-1-git-send-email-erik.stromdahl@gmail.com> <1487693741-10042-7-git-send-email-erik.stromdahl@gmail.com> <8760jh2uy8.fsf@kamboji.qca.qualcomm.com> <871su52th2.fsf@kamboji.qca.qualcomm.com> <2528f323-6ec7-915c-d98b-615db04510e9@gmail.com> <877f3qyc5g.fsf@kamboji.qca.qualcomm.com> <29c3dd40-c3ac-746e-d8ef-cb072c58578a@gmail.com> <87y3w5tvkq.fsf@kamboji.qca.qualcomm.com> In-Reply-To: (Erik Stromdahl's message of "Fri, 17 Mar 2017 16:54:08 +0100") Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Erik Stromdahl writes: > On 2017-03-16 10:33, Kalle Valo wrote: >> Erik Stromdahl writes: >> >>>> There seems to be same pattern for reading four bytes, what if we shou= ld >>>> add a helper for that? Something like ath10k_sdio_read32()? It could >>>> handle the kmalloc and switch endianess also. >>>> >>>> But please don't make any chances to sdio.c for the moment, let me >>>> submit v5 first. >>>> >>> I notice that you have submitted v5 (and v6) of the sdio patches. Great= ! >>> >>> I assume you will add them to master-pending soon so I will try out >>> everything (usb too) as soon as they are on master-pending. >> >> v6 is now in master-pending. >> > > I have added my usb patches on top of sdio v6 and everything works as exp= ected > (both usb and sdio). > > Your changes does not seem to have broken anything. Great, thanks for testing. I'll try to send v7 tomorrow and hopefully you have time to test that also. And naturally others are also welcome to provide feedback and test results. --=20 Kalle Valo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cr5KQ-0004z7-Db for ath10k@lists.infradead.org; Thu, 23 Mar 2017 16:11:12 +0000 From: Kalle Valo Subject: Re: [RFC v4 06/21] ath10k: sdio support Date: Thu, 23 Mar 2017 16:10:45 +0000 Message-ID: <878tnwynwb.fsf@kamboji.qca.qualcomm.com> References: <1487693741-10042-1-git-send-email-erik.stromdahl@gmail.com> <1487693741-10042-7-git-send-email-erik.stromdahl@gmail.com> <8760jh2uy8.fsf@kamboji.qca.qualcomm.com> <871su52th2.fsf@kamboji.qca.qualcomm.com> <2528f323-6ec7-915c-d98b-615db04510e9@gmail.com> <877f3qyc5g.fsf@kamboji.qca.qualcomm.com> <29c3dd40-c3ac-746e-d8ef-cb072c58578a@gmail.com> <87y3w5tvkq.fsf@kamboji.qca.qualcomm.com> In-Reply-To: (Erik Stromdahl's message of "Fri, 17 Mar 2017 16:54:08 +0100") Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Erik Stromdahl Cc: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Erik Stromdahl writes: > On 2017-03-16 10:33, Kalle Valo wrote: >> Erik Stromdahl writes: >> >>>> There seems to be same pattern for reading four bytes, what if we should >>>> add a helper for that? Something like ath10k_sdio_read32()? It could >>>> handle the kmalloc and switch endianess also. >>>> >>>> But please don't make any chances to sdio.c for the moment, let me >>>> submit v5 first. >>>> >>> I notice that you have submitted v5 (and v6) of the sdio patches. Great! >>> >>> I assume you will add them to master-pending soon so I will try out >>> everything (usb too) as soon as they are on master-pending. >> >> v6 is now in master-pending. >> > > I have added my usb patches on top of sdio v6 and everything works as expected > (both usb and sdio). > > Your changes does not seem to have broken anything. Great, thanks for testing. I'll try to send v7 tomorrow and hopefully you have time to test that also. And naturally others are also welcome to provide feedback and test results. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k