From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45004)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1cBGXC-0000G7-4j
	for qemu-devel@nongnu.org; Mon, 28 Nov 2016 02:39:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1cBGX7-0002xG-8i
	for qemu-devel@nongnu.org; Mon, 28 Nov 2016 02:39:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58436)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1cBGX7-0002wX-2E
	for qemu-devel@nongnu.org; Mon, 28 Nov 2016 02:39:25 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1480108791-16178-1-git-send-email-yuval.shaia@oracle.com>
Date: Mon, 28 Nov 2016 08:39:21 +0100
In-Reply-To: <1480108791-16178-1-git-send-email-yuval.shaia@oracle.com> (Yuval
	Shaia's message of "Fri, 25 Nov 2016 23:19:51 +0200")
Message-ID: <878ts459zq.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] {disas,
 slirp}: Replace min/max with MIN/MAX macros
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yuval Shaia <yuval.shaia@oracle.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, samuel.thibault@ens-lyon.org, jan.kiszka@siemens.com

The "{disas, slirp}: " prefix is unusual.  Better: "disas, slirp: ".
But I'd instead split the patch into the slirp part, where you really
replace stuff, and the disas part, where you merely drop an unused macro
definition.