From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn6IH-00061p-W6 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:52:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn6IC-0005SF-1k for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:52:12 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn6IB-0005S0-SA for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:52:07 -0400 Received: by mail-wm0-f45.google.com with SMTP id b130so155837291wmc.0 for ; Thu, 22 Sep 2016 08:52:07 -0700 (PDT) References: <1473678761-8885-1-git-send-email-pbonzini@redhat.com> <1473678761-8885-7-git-send-email-pbonzini@redhat.com> <87bmzgarel.fsf@linaro.org> <9b5c24ae-f956-2bff-6a8a-ce5e77a0bfd5@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <9b5c24ae-f956-2bff-6a8a-ce5e77a0bfd5@redhat.com> Date: Thu, 22 Sep 2016 16:51:05 +0100 Message-ID: <878tukaq6u.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 06/16] cpus-common: move CPU list management to common code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, sergey.fedorov@linaro.org Paolo Bonzini writes: > On 22/09/2016 17:24, Alex Bennée wrote: >> I see this is code moved from elsewhere but I feel a little comment >> about this should probably accompany the variable. I think it means once >> you have added a CPU without an explicit index all future CPUs will be >> auto assigned and you can no longer add CPUs with a specific index? >> >> Does this mean you can't hotplug additional CPUs without having >> specified a CPU topology at start-up? > > I honestly have no idea. Well never mind, as the code already exits my r-b still stands. -- Alex Bennée