From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [PATCH v2 02/10] userns: Add per user namespace sysctls. Date: Mon, 25 Jul 2016 19:02:01 -0500 Message-ID: <878twp6zd2.fsf@x220.int.ebiederm.org> References: <87d1m754jc.fsf@x220.int.ebiederm.org> <20160721164014.17534-1-ebiederm@xmission.com> <20160721164014.17534-2-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160721164014.17534-2-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> (Eric W. Biederman's message of "Thu, 21 Jul 2016 11:40:06 -0500") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Linux Containers Cc: Kees Cook , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andy Lutomirski , Seth Forshee , Nikolay Borisov , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jann Horn List-Id: containers.vger.kernel.org "Eric W. Biederman" writes: > Limit per userns sysctls to only be opened for write by a holder > of CAP_SYS_RESOURCE. > > Add all of the necessary boilerplate for having per user namespace > sysctls. > @@ -141,6 +215,7 @@ void free_user_ns(struct user_namespace *ns) > > do { > parent = ns->parent; > + retire_userns_sysctls(ns); ^^^^^^^^^^ Unfortunately it is not safe to call a sleeping function here so this part needs to be taken back to the drawing board. Which means this change gets has to wait for next cycle. > #ifdef CONFIG_PERSISTENT_KEYRINGS > key_put(ns->persistent_keyring_register); > #endif Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754827AbcGZAPL (ORCPT ); Mon, 25 Jul 2016 20:15:11 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:38219 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754372AbcGZAPH (ORCPT ); Mon, 25 Jul 2016 20:15:07 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Linux Containers Cc: Kees Cook , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Seth Forshee , Nikolay Borisov , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jann Horn References: <87d1m754jc.fsf@x220.int.ebiederm.org> <20160721164014.17534-1-ebiederm@xmission.com> <20160721164014.17534-2-ebiederm@xmission.com> Date: Mon, 25 Jul 2016 19:02:01 -0500 In-Reply-To: <20160721164014.17534-2-ebiederm@xmission.com> (Eric W. Biederman's message of "Thu, 21 Jul 2016 11:40:06 -0500") Message-ID: <878twp6zd2.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1bRq1V-0004ue-3x;;;mid=<878twp6zd2.fsf@x220.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=67.3.204.119;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/Dp3+fTKdKY1w8eK0KefB/foSbSobqQC8= X-SA-Exim-Connect-IP: 67.3.204.119 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 BAYES_20 BODY: Bayes spam probability is 5 to 20% * [score: 0.0892] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Linux Containers X-Spam-Relay-Country: X-Spam-Timing: total 218 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 7 (3.1%), b_tie_ro: 5 (2.4%), parse: 0.99 (0.5%), extract_message_metadata: 14 (6.4%), get_uri_detail_list: 0.90 (0.4%), tests_pri_-1000: 7 (3.1%), tests_pri_-950: 1.38 (0.6%), tests_pri_-900: 1.11 (0.5%), tests_pri_-400: 19 (8.7%), check_bayes: 18 (8.2%), b_tokenize: 4.9 (2.2%), b_tok_get_all: 6 (2.7%), b_comp_prob: 1.75 (0.8%), b_tok_touch_all: 2.8 (1.3%), b_finish: 0.82 (0.4%), tests_pri_0: 142 (65.4%), check_dkim_signature: 0.79 (0.4%), check_dkim_adsp: 3.8 (1.7%), tests_pri_500: 22 (10.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v2 02/10] userns: Add per user namespace sysctls. X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Eric W. Biederman" writes: > Limit per userns sysctls to only be opened for write by a holder > of CAP_SYS_RESOURCE. > > Add all of the necessary boilerplate for having per user namespace > sysctls. > @@ -141,6 +215,7 @@ void free_user_ns(struct user_namespace *ns) > > do { > parent = ns->parent; > + retire_userns_sysctls(ns); ^^^^^^^^^^ Unfortunately it is not safe to call a sleeping function here so this part needs to be taken back to the drawing board. Which means this change gets has to wait for next cycle. > #ifdef CONFIG_PERSISTENT_KEYRINGS > key_put(ns->persistent_keyring_register); > #endif Eric