From: Kalle Valo <kvalo@codeaurora.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Jia-Ju Bai <baijiaju1990@163.com>,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
ilw@linux.intel.com, linuxwifi@intel.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up
Date: Mon, 11 Jan 2016 14:44:31 +0200 [thread overview]
Message-ID: <878u3wi8uo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20160111121610.GF25015@redhat.com> (Stanislaw Gruszka's message of "Mon, 11 Jan 2016 13:16:10 +0100")
Stanislaw Gruszka <sgruszka@redhat.com> writes:
> On Sun, Jan 10, 2016 at 10:19:23AM +0800, Jia-Ju Bai wrote:
>> diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
>> index 6656215..fd7b5c7 100644
>> --- a/drivers/net/wireless/iwlegacy/4965-mac.c
>> +++ b/drivers/net/wireless/iwlegacy/4965-mac.c
>> @@ -5577,6 +5577,7 @@ __il4965_up(struct il_priv *il)
>> ret = il4965_hw_nic_init(il);
>> if (ret) {
>> IL_ERR("Unable to init nic\n");
>> + il_dealloc_bcast_stations(il);
>> return ret;
>> }
>
> Please do not repost patches so frequent and if you repost
> the unchanged patch mark it so i.e. [PATCH repost].
"repost" just confuses me and creates more work for me. Better to ping
on the original patch and even better is to check patchwork which shows
up-to-date status of wireless patches:
https://patchwork.kernel.org/project/linux-wireless/list/
--
Kalle Valo
next prev parent reply other threads:[~2016-01-11 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 2:19 [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up Jia-Ju Bai
2016-01-10 2:19 ` Jia-Ju Bai
2016-01-11 12:16 ` Stanislaw Gruszka
2016-01-11 12:16 ` Stanislaw Gruszka
2016-01-11 12:44 ` Kalle Valo [this message]
2016-01-11 13:41 ` Jia-Ju Bai
-- strict thread matches above, loose matches on Subject: below --
2016-01-07 12:17 Jia-Ju Bai
2016-01-11 12:13 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u3wi8uo.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=baijiaju1990@163.com \
--cc=emmanuel.grumbach@intel.com \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.