From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:49690 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752814AbbGAKjH (ORCPT ); Wed, 1 Jul 2015 06:39:07 -0400 From: Kalle Valo To: Raja Mani CC: , Subject: Re: [PATCH v2 5/8] ath10k: add 10.4 fw specific htt msg definitions References: <1434984747-24294-1-git-send-email-rmani@qti.qualcomm.com> <1434984747-24294-6-git-send-email-rmani@qti.qualcomm.com> Date: Wed, 1 Jul 2015 13:38:58 +0300 In-Reply-To: <1434984747-24294-6-git-send-email-rmani@qti.qualcomm.com> (Raja Mani's message of "Mon, 22 Jun 2015 20:22:24 +0530") Message-ID: <878ub0xiv1.fsf@kamboji.qca.qualcomm.com> (sfid-20150701_123912_660935_F4F57CD0) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Raja Mani writes: > New htt event table is added for 10.4 firmware. Following new htt > events are available only 10.4. adding this to generic htt event > table, > HTT_T2H_MSG_TYPE_EN_STATS, > HTT_T2H_MSG_TYPE_TX_FETCH_IND, > HTT_T2H_MSG_TYPE_TX_FETCH_CONF, > HTT_T2H_MSG_TYPE_TX_LOW_LATENCY_IND > > Signed-off-by: Raja Mani [...] > @@ -1146,6 +1147,8 @@ static int ath10k_core_init_firmware_features(struct ath10k *ar) > ar->htt.op_version = ATH10K_FW_HTT_OP_VERSION_TLV; > break; > case ATH10K_FW_WMI_OP_VERSION_10_4: > + ar->htt.op_version = ATH10K_FW_HTT_OP_VERSION_10_4; > + break; > case ATH10K_FW_WMI_OP_VERSION_UNSET: > case ATH10K_FW_WMI_OP_VERSION_MAX: > WARN_ON(1); So this switch block is only to support older firmware versions which do not have ATH10K_FW_IE_HTT_OP_VERSION yet. 10.4 firmware will always have it set so we don't need to have any backwards compatibility code for 10.4. I changed this part with the diff below. Please review. --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -1147,8 +1147,6 @@ static int ath10k_core_init_firmware_features(struct ath10k *ar) ar->htt.op_version = ATH10K_FW_HTT_OP_VERSION_TLV; break; case ATH10K_FW_WMI_OP_VERSION_10_4: - ar->htt.op_version = ATH10K_FW_HTT_OP_VERSION_10_4; - break; case ATH10K_FW_WMI_OP_VERSION_UNSET: case ATH10K_FW_WMI_OP_VERSION_MAX: WARN_ON(1); -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZAFQQ-0005Vs-Ik for ath10k@lists.infradead.org; Wed, 01 Jul 2015 10:39:30 +0000 From: Kalle Valo Subject: Re: [PATCH v2 5/8] ath10k: add 10.4 fw specific htt msg definitions References: <1434984747-24294-1-git-send-email-rmani@qti.qualcomm.com> <1434984747-24294-6-git-send-email-rmani@qti.qualcomm.com> Date: Wed, 1 Jul 2015 13:38:58 +0300 In-Reply-To: <1434984747-24294-6-git-send-email-rmani@qti.qualcomm.com> (Raja Mani's message of "Mon, 22 Jun 2015 20:22:24 +0530") Message-ID: <878ub0xiv1.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Raja Mani Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Raja Mani writes: > New htt event table is added for 10.4 firmware. Following new htt > events are available only 10.4. adding this to generic htt event > table, > HTT_T2H_MSG_TYPE_EN_STATS, > HTT_T2H_MSG_TYPE_TX_FETCH_IND, > HTT_T2H_MSG_TYPE_TX_FETCH_CONF, > HTT_T2H_MSG_TYPE_TX_LOW_LATENCY_IND > > Signed-off-by: Raja Mani [...] > @@ -1146,6 +1147,8 @@ static int ath10k_core_init_firmware_features(struct ath10k *ar) > ar->htt.op_version = ATH10K_FW_HTT_OP_VERSION_TLV; > break; > case ATH10K_FW_WMI_OP_VERSION_10_4: > + ar->htt.op_version = ATH10K_FW_HTT_OP_VERSION_10_4; > + break; > case ATH10K_FW_WMI_OP_VERSION_UNSET: > case ATH10K_FW_WMI_OP_VERSION_MAX: > WARN_ON(1); So this switch block is only to support older firmware versions which do not have ATH10K_FW_IE_HTT_OP_VERSION yet. 10.4 firmware will always have it set so we don't need to have any backwards compatibility code for 10.4. I changed this part with the diff below. Please review. --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -1147,8 +1147,6 @@ static int ath10k_core_init_firmware_features(struct ath10k *ar) ar->htt.op_version = ATH10K_FW_HTT_OP_VERSION_TLV; break; case ATH10K_FW_WMI_OP_VERSION_10_4: - ar->htt.op_version = ATH10K_FW_HTT_OP_VERSION_10_4; - break; case ATH10K_FW_WMI_OP_VERSION_UNSET: case ATH10K_FW_WMI_OP_VERSION_MAX: WARN_ON(1); -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k