Re: perf: aux area related crash and warnings

From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Stephane Eranian <eranian@gmail.com>
Subject: Re: perf: aux area related crash and warnings
Date: Thu, 18 Jun 2015 16:11:03 +0300	[thread overview]
Message-ID: <878ubh2mc8.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20150618103249.GK19282@twins.programming.kicks-ass.net>

Peter Zijlstra <peterz@infradead.org> writes:

> On Tue, Jun 16, 2015 at 02:37:06PM +0300, Alexander Shishkin wrote:
>> Ok, here's what I propose for this one.
>
> As discussed yesterday, I think we want to change to how we do reference
> counting for the regular buffers, but that will require quite a bit of
> work.
>
> For the interim we can avoid the issue by something like the below;
> compile tested only.

Looks good and works fine on my tests. Only I'd maybe add a small
comment on why reusing rcu_head.next doesn't set off call_rcu()
debugging. Other than that, fwiw,

Reviewed-and-tested-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>

Thanks,
--
Alex