Hi Antara,

On 01/31/2019 12:18 AM, Antara Borwankar wrote:
> Made changes in xmm7modem plugin to allow mutiple PDP context
> activation and to assign correct network interface to the
> activated PDP context.
> ---
>   plugins/udevng.c  |  2 ++
>   plugins/xmm7xxx.c | 12 ++++++++++++
>   2 files changed, 14 insertions(+)
> 
> diff --git a/plugins/udevng.c b/plugins/udevng.c
> index ff6e1fc..353a7dd 100644
> --- a/plugins/udevng.c
> +++ b/plugins/udevng.c
> @@ -1219,6 +1219,8 @@ static gboolean setup_xmm7xxx(struct modem_info *modem)
>   
>   	ofono_modem_set_string(modem->modem, "Modem", mdm);
>   	ofono_modem_set_string(modem->modem, "NetworkInterface", net);
> +	ofono_modem_set_string(modem->modem, "CtrlPath", "/USBCDC/0");
> +	ofono_modem_set_string(modem->modem, "DataPath", "/USBHS/NCM/");

These seem hard-coded.  What happens if you plug in multiple XMM7xxx usb 
modems into a system?

>   
>   	return TRUE;
>   }
> diff --git a/plugins/xmm7xxx.c b/plugins/xmm7xxx.c
> index 237c62c..8b775e0 100644
> --- a/plugins/xmm7xxx.c
> +++ b/plugins/xmm7xxx.c
> @@ -1282,6 +1282,18 @@ static void xmm7xxx_post_online(struct ofono_modem *modem)
>   	if (gprs && gc)
>   		ofono_gprs_add_context(gprs, gc);
>   
> +	gc = ofono_gprs_context_create(modem, OFONO_VENDOR_XMM, "ifxmodem",
> +					data->chat);
> +
> +	if (gprs && gc)
> +		ofono_gprs_add_context(gprs, gc);
> +
> +	gc = ofono_gprs_context_create(modem, OFONO_VENDOR_XMM, "ifxmodem",
> +					data->chat);
> +
> +	if (gprs && gc)
> +		ofono_gprs_add_context(gprs, gc);
> +

Okay, but how does a context driver know which interface to use?  For 
ifxmodem we used a different DLC for each context driver for example. 
It is unclear how things would work under your setup?

>   	ofono_ims_create(modem, "xmm7modem", data->chat);
>   	ofono_netmon_create(modem, 0, "xmm7modem", data->chat);
>   }
> 

Regards,
-Denis