From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EAF6C433E0 for ; Wed, 1 Jul 2020 09:19:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF5672078B for ; Wed, 1 Jul 2020 09:19:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729181AbgGAJTn (ORCPT ); Wed, 1 Jul 2020 05:19:43 -0400 Received: from mail.loongson.cn ([114.242.206.163]:57150 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726715AbgGAJTl (ORCPT ); Wed, 1 Jul 2020 05:19:41 -0400 Received: from [10.130.0.52] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Axb+ggVfxe8p1NAA--.11813S3; Wed, 01 Jul 2020 17:19:29 +0800 (CST) Subject: Re: [PATCH v4 04/14] irqchip/davinci-aintc: Fix potential resource leaks To: Markus Elfring , Thomas Gleixner , Jason Cooper , Marc Zyngier References: <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn> <1593569786-11500-5-git-send-email-yangtiezhu@loongson.cn> <08cad331-0a17-586c-07a7-6e3843cb61a1@web.de> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Tiezhu Yang Message-ID: <879ce976-042d-b8d7-676e-304e02e7c965@loongson.cn> Date: Wed, 1 Jul 2020 17:19:28 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <08cad331-0a17-586c-07a7-6e3843cb61a1@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf9Axb+ggVfxe8p1NAA--.11813S3 X-Coremail-Antispam: 1UD129KBjvdXoWrGr1fuF1kZw1DGr15ZryUGFg_yoWxWrgEgF y2gry7Gw4DG345Ja4jgrWvyFsFg3y7u3WxJryxZa13K3y3XwnxJrWkGF9xZa47KFZ3ur4D CFZIvrWYy343ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbc8YjsxI4VWDJwAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r4j6F4UMc vjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487MxAI w28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr 4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxG rwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8Jw CI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY 6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUc9mRUUUUU X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2020 04:15 PM, Markus Elfring wrote: > … >> +++ b/drivers/irqchip/irq-davinci-aintc.c >> @@ -96,7 +96,7 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config) >> resource_size(&config->reg)); >> if (!davinci_aintc_base) { >> pr_err("%s: unable to ioremap register range\n", __func__); >> - return; >> + goto err_release; >> } > … > > Can it help to return any error codes? > Would you like to reconsider the function return type? No, the initial aim of this patch is just to fix the potential resource leaks, so I think maybe no need to consider the function return type now. > > Regards, > Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tiezhu Yang Date: Wed, 01 Jul 2020 09:19:28 +0000 Subject: Re: [PATCH v4 04/14] irqchip/davinci-aintc: Fix potential resource leaks Message-Id: <879ce976-042d-b8d7-676e-304e02e7c965@loongson.cn> List-Id: References: <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn> <1593569786-11500-5-git-send-email-yangtiezhu@loongson.cn> <08cad331-0a17-586c-07a7-6e3843cb61a1@web.de> In-Reply-To: <08cad331-0a17-586c-07a7-6e3843cb61a1@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Markus Elfring , Thomas Gleixner , Jason Cooper , Marc Zyngier Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 07/01/2020 04:15 PM, Markus Elfring wrote: > … >> +++ b/drivers/irqchip/irq-davinci-aintc.c >> @@ -96,7 +96,7 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config) >> resource_size(&config->reg)); >> if (!davinci_aintc_base) { >> pr_err("%s: unable to ioremap register range\n", __func__); >> - return; >> + goto err_release; >> } > … > > Can it help to return any error codes? > Would you like to reconsider the function return type? No, the initial aim of this patch is just to fix the potential resource leaks, so I think maybe no need to consider the function return type now. > > Regards, > Markus