All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kubascik <jeff.kubascik@dornerworks.com>
To: Richard Henderson <richard.henderson@linaro.org>,
	Peter Maydell <peter.maydell@linaro.org>, <qemu-arm@nongnu.org>,
	<qemu-devel@nongnu.org>
Cc: Stewart Hildebrand <Stewart.Hildebrand@dornerworks.com>,
	Jarvis Roach <Jarvis.Roach@dornerworks.com>
Subject: Re: [PATCH] target/arm: adjust program counter for wfi exception in AArch32
Date: Tue, 14 Jan 2020 08:22:40 -0500	[thread overview]
Message-ID: <879fa44b-a405-e1d6-eb3f-90216f5d3385@dornerworks.com> (raw)
In-Reply-To: <7f45c4a2-0192-aaaa-8d0f-7ea7890ca448@linaro.org>

On 1/13/2020 9:41 PM, Richard Henderson wrote:
> On 1/10/20 8:02 AM, Jeff Kubascik wrote:
>> -        env->pc -= insn_len;
>> +        if (env->aarch64)
>> +            env->pc -= insn_len;
>> +        else
>> +            env->regs[15] -= insn_len;
> 
> QEMU requires all braces.  See CODING_STYLE.

I received an automated email from Patchew regarding the coding style issue. I
have submitted a v2 of the patch with this correction yesterday.

> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> 
> r~
> 

Thanks!
Jeff Kubascik


      reply	other threads:[~2020-01-14 13:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 18:02 [PATCH] target/arm: adjust program counter for wfi exception in AArch32 Jeff Kubascik
2020-01-10 19:19 ` no-reply
2020-01-14  2:41 ` Richard Henderson
2020-01-14 13:22   ` Jeff Kubascik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=879fa44b-a405-e1d6-eb3f-90216f5d3385@dornerworks.com \
    --to=jeff.kubascik@dornerworks.com \
    --cc=Jarvis.Roach@dornerworks.com \
    --cc=Stewart.Hildebrand@dornerworks.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.