From: Michio Honda <micchie@sfc.wide.ad.jp>
To: linux-sctp@vger.kernel.org
Subject: Re: sctp: Add ASCONF operation on the single-homed host
Date: Wed, 08 Jun 2011 06:57:50 +0000 [thread overview]
Message-ID: <87E26258-BFE2-474F-928B-410D22B2AD4F@sfc.wide.ad.jp> (raw)
In-Reply-To: <20110608065302.GF3846@shale.localdomain>
Exactly, thanks.
I will post a patch to fix it in a few days.
Best regards
- Michio
On Jun 8, 2011, at 15:53 , Dan Carpenter wrote:
> This code was added in 8a07eb0a50a "sctp: Add ASCONF operation on
> the single-homed host".
>
> 784 if ((laddr = NULL) && (addrcnt = 1)) {
> 785 if (asoc->asconf_addr_del_pending)
> 786 continue;
> 787 asoc->asconf_addr_del_pending > 788 kzalloc(sizeof(union sctp_addr), GFP_ATOMIC);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> We need some error handling here if the allocation fails.
>
> 789 asoc->asconf_addr_del_pending->sa.sa_family > 790 addrs->sa_family;
> 791 asoc->asconf_addr_del_pending->v4.sin_port > 792 htons(bp->port);
>
> regards,
> dan carpenter
next prev parent reply other threads:[~2011-06-08 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 6:53 sctp: Add ASCONF operation on the single-homed host Dan Carpenter
2011-06-08 6:57 ` Michio Honda [this message]
2013-02-25 7:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87E26258-BFE2-474F-928B-410D22B2AD4F@sfc.wide.ad.jp \
--to=micchie@sfc.wide.ad.jp \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.