From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9045BC433FE for ; Fri, 5 Nov 2021 09:59:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7204D61265 for ; Fri, 5 Nov 2021 09:59:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232960AbhKEKBm (ORCPT ); Fri, 5 Nov 2021 06:01:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56710 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232955AbhKEKBj (ORCPT ); Fri, 5 Nov 2021 06:01:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636106340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PAYCTLIu4BclXd+cEViyuoXMMG/fW8iPDkQUaON6iK4=; b=CqULCLW89Y0wGu31R3NUuP46hlTKi/ghcATCHNKGuooAnf92HOGa8RXgcCxZ7jMVY7MDMR sNt21nF/zwsGfTM6PA4W+NdhHnmvNHRXR1BAkrCY50jmLQnDewAPk9nPFk95630/4EDhy+ Zs8nlZ3hvna5oSB9/r6GShAM+II7NZU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-550-7578yrBzNcSfM7ZRhBZXQg-1; Fri, 05 Nov 2021 05:58:58 -0400 X-MC-Unique: 7578yrBzNcSfM7ZRhBZXQg-1 Received: by mail-wr1-f72.google.com with SMTP id d13-20020adf9b8d000000b00160a94c235aso2149127wrc.2 for ; Fri, 05 Nov 2021 02:58:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PAYCTLIu4BclXd+cEViyuoXMMG/fW8iPDkQUaON6iK4=; b=UVoWtaXQhpRKpqJCX2NRz2MDHc8RheelZO8u/rcPkfPcFUSnyoglSkE5u/1z5//QMF z8a7Rsb13aAeb4DSUmhmpy7a24hMf9OY10fSQOZVR9xcytETtH0mRtAbNKuH2fGbb7cf CkOp7fHTxJJ1OFRCs99VBqNgyLBg5hi2xpQs2Pgu3neElX555Avkdr8G4X9oZgxxBw1a +ACLSLXrRA//mM5r52wATnstHWLPTieKHwbJ5IEdn+dCng19He/TBcJRegAIoLMnf+70 eK5iCkpWKwwkpPxSGKIyoeQcO2DHzM0rpiNwgTY+r18SL23MD4uhVXKs3p8DqABnsKFH Bduw== X-Gm-Message-State: AOAM532bjmiGA4Y6yGrszKnyCKHh6VNzqf0hdwMAHSGhYc0RvrNIGPi3 03gv/qAxn3/jC9QnnDIXQwSH6fzenGJVSq7GBfZFdAP02CJu3XpVjkQmCniad13asSf9OXyd6sB DDL+XGyRJ3QRRdd32tFIJTTnH X-Received: by 2002:adf:ec90:: with SMTP id z16mr46047438wrn.247.1636106336897; Fri, 05 Nov 2021 02:58:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVMn64qcflGLedLN5EhsNM7GWU6o/3vwDL3aOoAYuCZV9//84CDnDeN1gsW9919fwpqQaOmg== X-Received: by 2002:adf:ec90:: with SMTP id z16mr46047414wrn.247.1636106336738; Fri, 05 Nov 2021 02:58:56 -0700 (PDT) Received: from [192.168.1.128] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id c17sm7678095wmk.23.2021.11.05.02.58.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 02:58:56 -0700 (PDT) Message-ID: <87a6bb4a-01ef-4979-f5c2-c0bb0d0a29f9@redhat.com> Date: Fri, 5 Nov 2021 10:58:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem Content-Language: en-US To: Thomas Zimmermann , Jani Nikula , linux-kernel@vger.kernel.org Cc: =?UTF-8?Q?Michel_D=c3=a4nzer?= , Daniel Vetter , Peter Robinson , Pekka Paalanen , Alex Deucher , Ben Skeggs , Chia-I Wu , =?UTF-8?Q?Christian_K=c3=b6nig?= , Daniel Vetter , Dave Airlie , David Airlie , Gerd Hoffmann , Greg Kroah-Hartman , Gurchetan Singh , Hans de Goede , Joonas Lahtinen , Maarten Lankhorst , Maxime Ripard , "Pan, Xinhui" , Rodrigo Vivi , VMware Graphics , Zack Rusin , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-fbdev@vger.kernel.org, nouveau@lists.freedesktop.org, spice-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org References: <20211104160707.1407052-1-javierm@redhat.com> <20211104160707.1407052-3-javierm@redhat.com> <87cznf9cty.fsf@intel.com> <2698c680-6d05-f58d-d7c2-ea76aeb0bb47@suse.de> From: Javier Martinez Canillas In-Reply-To: <2698c680-6d05-f58d-d7c2-ea76aeb0bb47@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/21 10:39, Thomas Zimmermann wrote: [snip] >>>> >>>> +obj-$(CONFIG_VGA_CONSOLE) += drm_nomodeset.o >>>> + >>> >>> This now depends on the VGA textmode console. Even if you have no VGA >>> console, you'd want drm_nomodeset.o. Simpledrm might be built-in and can >>> provide graphics. Non-PC systems don't even have a VGA device. >> >> This was discussed in an earlier version, which had this builtin but the >> header still had a stub for CONFIG_VGA_CONSOLE=n. >> >>> I think we really want a separate boolean config option that gets >>> selected by CONFIG_DRM. >> >> Perhaps that should be a separate change on top. > > Sure, make it a separate patch. > Agreed. I was planning to do it as a follow-up as well and drop the #ifdef CONFIG_VGA_CONSOLE guard in the header. > We want to make this work on ARM systems. I even have a request to > replace offb on Power architecture by simpledrm. So the final config has > to be system agnostic. > Same, since we want to drop the fbdev drivers in Fedora, for all arches. > Best regards > Thomas > Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7987C433F5 for ; Fri, 5 Nov 2021 09:59:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 843DA6126A for ; Fri, 5 Nov 2021 09:59:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 843DA6126A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E54686E0DE; Fri, 5 Nov 2021 09:59:01 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 832F96E116 for ; Fri, 5 Nov 2021 09:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636106339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PAYCTLIu4BclXd+cEViyuoXMMG/fW8iPDkQUaON6iK4=; b=C/8KnzySkruZmAcItDg1eTEOWfaUZnWXHfXZHiwjp9nm/iWNZRRnIpI0tAozKCZ4D834ra 1dedv/ow0D6x/6/8UyLtVGwPOELbgurlFwBtkQ9CuVmjA1KfHmU3sekBW3W2iU/EDhhX3M m2NO4u4yTXu1L0/TRLxeOftJmWKkHOI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-rEEJQMeTNGGXUS8P4VA6ug-1; Fri, 05 Nov 2021 05:58:58 -0400 X-MC-Unique: rEEJQMeTNGGXUS8P4VA6ug-1 Received: by mail-wm1-f70.google.com with SMTP id z138-20020a1c7e90000000b003319c5f9164so5470902wmc.7 for ; Fri, 05 Nov 2021 02:58:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PAYCTLIu4BclXd+cEViyuoXMMG/fW8iPDkQUaON6iK4=; b=Qi52CBq+BOAQCUVir9Ylx2PX+jujJ8CmO2e7ZIwBCayG6oASSpIrGQLxCi3dQEcs6F q/YDtPrA0+k0Na79JKovebEWOjCEUtZvpiAY0dFx1FMSAyRprIstncSymxeSlsVblNwk ug1D6ECsVZZu/tFl9xy+UBwyiYA1f3BEPKY2799TIz1TtSSUPVRq0++PxCsgZre2NGz+ A7Ar01zs1BTE15S9bNpQB/XbjpeiPIgdupL0mutfaUouTf8We1vyUf5o/D6dfwULtBRt vdNi1Ky7vNaeZBa20FwahW8YqF+z49OWSNtXl94asmhfyVFZtJK+ZlwnTA4iO2fR5nDj O3eQ== X-Gm-Message-State: AOAM531KNuHqKskZG1gofV6u7VDj5AWzbXxK4mI+phBai59sX7JzqJLO zopYLjd/AwYjVMwUWIaww8JjRc7Z6+zv1EmyNt6xQerLi5O2cfhJRn36zd8ere/My5+hB3bgGwI 1R/1nh3ySLS4wWbpXWcEQLMs1A8J8 X-Received: by 2002:adf:ec90:: with SMTP id z16mr46047451wrn.247.1636106336899; Fri, 05 Nov 2021 02:58:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVMn64qcflGLedLN5EhsNM7GWU6o/3vwDL3aOoAYuCZV9//84CDnDeN1gsW9919fwpqQaOmg== X-Received: by 2002:adf:ec90:: with SMTP id z16mr46047414wrn.247.1636106336738; Fri, 05 Nov 2021 02:58:56 -0700 (PDT) Received: from [192.168.1.128] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id c17sm7678095wmk.23.2021.11.05.02.58.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 02:58:56 -0700 (PDT) Message-ID: <87a6bb4a-01ef-4979-f5c2-c0bb0d0a29f9@redhat.com> Date: Fri, 5 Nov 2021 10:58:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem To: Thomas Zimmermann , Jani Nikula , linux-kernel@vger.kernel.org References: <20211104160707.1407052-1-javierm@redhat.com> <20211104160707.1407052-3-javierm@redhat.com> <87cznf9cty.fsf@intel.com> <2698c680-6d05-f58d-d7c2-ea76aeb0bb47@suse.de> From: Javier Martinez Canillas In-Reply-To: <2698c680-6d05-f58d-d7c2-ea76aeb0bb47@suse.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Gurchetan Singh , Gerd Hoffmann , amd-gfx@lists.freedesktop.org, VMware Graphics , Peter Robinson , nouveau@lists.freedesktop.org, Dave Airlie , Ben Skeggs , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Hans de Goede , Rodrigo Vivi , virtualization@lists.linux-foundation.org, Pekka Paalanen , Greg Kroah-Hartman , "Pan, Xinhui" , spice-devel@lists.freedesktop.org, Alex Deucher , intel-gfx@lists.freedesktop.org, =?UTF-8?Q?Christian_K=c3=b6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 11/5/21 10:39, Thomas Zimmermann wrote: [snip] >>>> >>>> +obj-$(CONFIG_VGA_CONSOLE) += drm_nomodeset.o >>>> + >>> >>> This now depends on the VGA textmode console. Even if you have no VGA >>> console, you'd want drm_nomodeset.o. Simpledrm might be built-in and can >>> provide graphics. Non-PC systems don't even have a VGA device. >> >> This was discussed in an earlier version, which had this builtin but the >> header still had a stub for CONFIG_VGA_CONSOLE=n. >> >>> I think we really want a separate boolean config option that gets >>> selected by CONFIG_DRM. >> >> Perhaps that should be a separate change on top. > > Sure, make it a separate patch. > Agreed. I was planning to do it as a follow-up as well and drop the #ifdef CONFIG_VGA_CONSOLE guard in the header. > We want to make this work on ARM systems. I even have a request to > replace offb on Power architecture by simpledrm. So the final config has > to be system agnostic. > Same, since we want to drop the fbdev drivers in Fedora, for all arches. > Best regards > Thomas > Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09130C433F5 for ; Fri, 5 Nov 2021 09:59:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC9876135F for ; Fri, 5 Nov 2021 09:59:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BC9876135F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 69A576E10B; Fri, 5 Nov 2021 09:59:02 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 75BF26E10B for ; Fri, 5 Nov 2021 09:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636106339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PAYCTLIu4BclXd+cEViyuoXMMG/fW8iPDkQUaON6iK4=; b=C/8KnzySkruZmAcItDg1eTEOWfaUZnWXHfXZHiwjp9nm/iWNZRRnIpI0tAozKCZ4D834ra 1dedv/ow0D6x/6/8UyLtVGwPOELbgurlFwBtkQ9CuVmjA1KfHmU3sekBW3W2iU/EDhhX3M m2NO4u4yTXu1L0/TRLxeOftJmWKkHOI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-552-PsDuo8naNuODaiZSREYHaw-1; Fri, 05 Nov 2021 05:58:58 -0400 X-MC-Unique: PsDuo8naNuODaiZSREYHaw-1 Received: by mail-wr1-f71.google.com with SMTP id w14-20020adfbace000000b001884bf6e902so1447677wrg.3 for ; Fri, 05 Nov 2021 02:58:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PAYCTLIu4BclXd+cEViyuoXMMG/fW8iPDkQUaON6iK4=; b=j2qeCz/4yui9PpvW0APLqfFvmy7mzhP3NboiExDwFbEjVSooZS38zoRd6+zudICr0X z8J3+HkjXIzDsKF4k9cPYRAUcC5WW+waVGuFr7oPWMOoyH9BgyH9/dQ0cudRdXQdiAxB nrI2jgZjcEhfDPrmSNhNp9ms34UDONIgawwklG2hywEZvJlXXavNDcTMhBgiaNiWYEdu 1XvpFFxw1mgCSx+eAFHqDxMS9b6odSVPfhJTEqjNswKm8NuKzF9yDTlHI+faMU5wpRq5 Pl0k+uY2luYpZe/MsErYj7qwdFDCQSdoUaXSh/tXMsNgzn+bdtLKt7QxTLHl1+vkpnHZ 18LA== X-Gm-Message-State: AOAM530puY3cd9UjAGwL9/dtFr/UinczpM5va/qpDm0/8kKByyoymJ1W nsixuAqNWNjLm9vwBSocSPmM673hr5PcuwOw05Ea8p8kOZ/pYBih8NRk/CkL/HpAgpqHSGwM6hp 8MMMfWRlU6uf1v+57zI4OxwxViRs1 X-Received: by 2002:adf:ec90:: with SMTP id z16mr46047444wrn.247.1636106336898; Fri, 05 Nov 2021 02:58:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVMn64qcflGLedLN5EhsNM7GWU6o/3vwDL3aOoAYuCZV9//84CDnDeN1gsW9919fwpqQaOmg== X-Received: by 2002:adf:ec90:: with SMTP id z16mr46047414wrn.247.1636106336738; Fri, 05 Nov 2021 02:58:56 -0700 (PDT) Received: from [192.168.1.128] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id c17sm7678095wmk.23.2021.11.05.02.58.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 02:58:56 -0700 (PDT) Message-ID: <87a6bb4a-01ef-4979-f5c2-c0bb0d0a29f9@redhat.com> Date: Fri, 5 Nov 2021 10:58:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: Thomas Zimmermann , Jani Nikula , linux-kernel@vger.kernel.org References: <20211104160707.1407052-1-javierm@redhat.com> <20211104160707.1407052-3-javierm@redhat.com> <87cznf9cty.fsf@intel.com> <2698c680-6d05-f58d-d7c2-ea76aeb0bb47@suse.de> From: Javier Martinez Canillas In-Reply-To: <2698c680-6d05-f58d-d7c2-ea76aeb0bb47@suse.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Gurchetan Singh , Gerd Hoffmann , amd-gfx@lists.freedesktop.org, VMware Graphics , Peter Robinson , nouveau@lists.freedesktop.org, Dave Airlie , Chia-I Wu , Ben Skeggs , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Maxime Ripard , virtualization@lists.linux-foundation.org, Pekka Paalanen , Greg Kroah-Hartman , "Pan, Xinhui" , spice-devel@lists.freedesktop.org, Alex Deucher , intel-gfx@lists.freedesktop.org, =?UTF-8?Q?Christian_K=c3=b6nig?= , Zack Rusin Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 11/5/21 10:39, Thomas Zimmermann wrote: [snip] >>>> >>>> +obj-$(CONFIG_VGA_CONSOLE) += drm_nomodeset.o >>>> + >>> >>> This now depends on the VGA textmode console. Even if you have no VGA >>> console, you'd want drm_nomodeset.o. Simpledrm might be built-in and can >>> provide graphics. Non-PC systems don't even have a VGA device. >> >> This was discussed in an earlier version, which had this builtin but the >> header still had a stub for CONFIG_VGA_CONSOLE=n. >> >>> I think we really want a separate boolean config option that gets >>> selected by CONFIG_DRM. >> >> Perhaps that should be a separate change on top. > > Sure, make it a separate patch. > Agreed. I was planning to do it as a follow-up as well and drop the #ifdef CONFIG_VGA_CONSOLE guard in the header. > We want to make this work on ARM systems. I even have a request to > replace offb on Power architecture by simpledrm. So the final config has > to be system agnostic. > Same, since we want to drop the fbdev drivers in Fedora, for all arches. > Best regards > Thomas > Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E940CC4332F for ; Fri, 5 Nov 2021 13:49:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D6A0611AE for ; Fri, 5 Nov 2021 13:49:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8D6A0611AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 915826E5B2; Fri, 5 Nov 2021 13:48:55 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id E686C6E10B for ; Fri, 5 Nov 2021 09:59:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636106341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PAYCTLIu4BclXd+cEViyuoXMMG/fW8iPDkQUaON6iK4=; b=G3u+TK+LPXSkwKEF+Pb4QZVkzMMb7v4Gct3YcN1jEAr9e3VfmzaQ/rD5BV0PHsgnsb9gla SJZ05WGvyTQepU6mH8lfaqKLFpBfU+CVAQoosU+09ccrbBcxO73dc+sPUnTWdVWKjDN3cx Tbs6rYUynzy+Rlrg1Ms8yL+amz57NSw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-425-qjQ8fEGnOECrWugc7_XsBQ-1; Fri, 05 Nov 2021 05:58:58 -0400 X-MC-Unique: qjQ8fEGnOECrWugc7_XsBQ-1 Received: by mail-wm1-f70.google.com with SMTP id n189-20020a1c27c6000000b00322f2e380f2so5465877wmn.6 for ; Fri, 05 Nov 2021 02:58:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PAYCTLIu4BclXd+cEViyuoXMMG/fW8iPDkQUaON6iK4=; b=sKk/+3c2zW7bHgm3wS/31jN26uUeUlF88VnPbyuxoMSFKwH83JeSOaAtE22cm75HzA zgP4uEkz8k62Y/R2u+D6xKNudr0TO7Uee2yhYcYyCf07nuMB2n0ir2GCF3fjMUM7mbwq kKBqmyFHnd3nXM4unKyqsHY3JG+jGD46imUsMyXNNTIOjQqV13bdwjSArC9mlm0k9eAJ 6S6+tJuWFwBF6lfyr2JbR+OisHKjuDH/KjVbkTcV8a/qo9Yt4QsG1kweuIa/IiBz7i0Z 7uvcCBCXtLD5wBXMMBfEEba/s3r1JPSw01Mqh0JtSmgBaCEeo6AmVsXLku4sRlnwVUm1 6Low== X-Gm-Message-State: AOAM531SfB5VmtnjtybuqWGTzibrqWELWcYIKaafYQg7y3dLD6tHZeAR YY/ZPKAYPB+ThDUpf08RqsiOq9/QReup4PEuX7juGCpzwOe8JYa4lwpBDxH1OHJLqWjF1zvUauJ 8r2kE+QkMatQnOzUUXhFa2G1ALg== X-Received: by 2002:adf:ec90:: with SMTP id z16mr46047453wrn.247.1636106336899; Fri, 05 Nov 2021 02:58:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVMn64qcflGLedLN5EhsNM7GWU6o/3vwDL3aOoAYuCZV9//84CDnDeN1gsW9919fwpqQaOmg== X-Received: by 2002:adf:ec90:: with SMTP id z16mr46047414wrn.247.1636106336738; Fri, 05 Nov 2021 02:58:56 -0700 (PDT) Received: from [192.168.1.128] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id c17sm7678095wmk.23.2021.11.05.02.58.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 02:58:56 -0700 (PDT) Message-ID: <87a6bb4a-01ef-4979-f5c2-c0bb0d0a29f9@redhat.com> Date: Fri, 5 Nov 2021 10:58:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem To: Thomas Zimmermann , Jani Nikula , linux-kernel@vger.kernel.org References: <20211104160707.1407052-1-javierm@redhat.com> <20211104160707.1407052-3-javierm@redhat.com> <87cznf9cty.fsf@intel.com> <2698c680-6d05-f58d-d7c2-ea76aeb0bb47@suse.de> From: Javier Martinez Canillas In-Reply-To: <2698c680-6d05-f58d-d7c2-ea76aeb0bb47@suse.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 05 Nov 2021 13:48:53 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, David Airlie , Daniel Vetter , Joonas Lahtinen , dri-devel@lists.freedesktop.org, Gurchetan Singh , Gerd Hoffmann , amd-gfx@lists.freedesktop.org, VMware Graphics , Peter Robinson , nouveau@lists.freedesktop.org, Dave Airlie , Chia-I Wu , Ben Skeggs , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Maarten Lankhorst , Maxime Ripard , Hans de Goede , Rodrigo Vivi , virtualization@lists.linux-foundation.org, Pekka Paalanen , Greg Kroah-Hartman , "Pan, Xinhui" , spice-devel@lists.freedesktop.org, Daniel Vetter , Alex Deucher , intel-gfx@lists.freedesktop.org, =?UTF-8?Q?Christian_K=c3=b6nig?= , Zack Rusin Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 11/5/21 10:39, Thomas Zimmermann wrote: [snip] >>>> >>>> +obj-$(CONFIG_VGA_CONSOLE) += drm_nomodeset.o >>>> + >>> >>> This now depends on the VGA textmode console. Even if you have no VGA >>> console, you'd want drm_nomodeset.o. Simpledrm might be built-in and can >>> provide graphics. Non-PC systems don't even have a VGA device. >> >> This was discussed in an earlier version, which had this builtin but the >> header still had a stub for CONFIG_VGA_CONSOLE=n. >> >>> I think we really want a separate boolean config option that gets >>> selected by CONFIG_DRM. >> >> Perhaps that should be a separate change on top. > > Sure, make it a separate patch. > Agreed. I was planning to do it as a follow-up as well and drop the #ifdef CONFIG_VGA_CONSOLE guard in the header. > We want to make this work on ARM systems. I even have a request to > replace offb on Power architecture by simpledrm. So the final config has > to be system agnostic. > Same, since we want to drop the fbdev drivers in Fedora, for all arches. > Best regards > Thomas > Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BECAFC433EF for ; Fri, 5 Nov 2021 14:25:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A11761183 for ; Fri, 5 Nov 2021 14:25:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8A11761183 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 407AF6E8E5; Fri, 5 Nov 2021 14:25:40 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7067B6E0DE for ; Fri, 5 Nov 2021 09:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636106339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PAYCTLIu4BclXd+cEViyuoXMMG/fW8iPDkQUaON6iK4=; b=C/8KnzySkruZmAcItDg1eTEOWfaUZnWXHfXZHiwjp9nm/iWNZRRnIpI0tAozKCZ4D834ra 1dedv/ow0D6x/6/8UyLtVGwPOELbgurlFwBtkQ9CuVmjA1KfHmU3sekBW3W2iU/EDhhX3M m2NO4u4yTXu1L0/TRLxeOftJmWKkHOI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-550-jxnK9PCEPLiHPj9Z9mhR8A-1; Fri, 05 Nov 2021 05:58:58 -0400 X-MC-Unique: jxnK9PCEPLiHPj9Z9mhR8A-1 Received: by mail-wm1-f69.google.com with SMTP id b133-20020a1c808b000000b0032cdd691994so5481162wmd.1 for ; Fri, 05 Nov 2021 02:58:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PAYCTLIu4BclXd+cEViyuoXMMG/fW8iPDkQUaON6iK4=; b=zAdgyNgUiODuGJrqWSOZkMEOn175bRAI3kNFZuq8ge7yO9IQitGNMNRIVdu7TbTaLC AdYocXpGry0Uxz/GRefX7wWhkrf4WPPOx1Bed4khULhis/XkkIDqRuneomFcmkWhv+oK 0iCWyt0jdlmRqiIiI4QVb7QFaoHB8siPJzXNFXYPWMxwO5TUgoPsYC3yGUlRfWNAiMYn P+0ytEDXAnHXoqNT8DGHuzLRSpfRk20/FU88KkNuQjSCZDS8qjPv4xuk9o0jcXd9fgS9 ISiemZxvyU9RWE5VVnxq4wC4lcYPpph7ZAVyK8QYlX128DW6zv+EDhQ6jD60dI8OA/qv 6B2A== X-Gm-Message-State: AOAM533mO53O5HWb9s4O89vgzCgLDdBLesgm2LuDUOVjI9k45XUmXLXe XT4Vnw206tnrLt7QbT6h9ok15+YjlLbw25qZhENYHUoNrBlGigJM9RavHoke8yZNKszA6GMOXDY 3ZjHspoW8EHPYc55z4Y8vBthFqQ== X-Received: by 2002:adf:ec90:: with SMTP id z16mr46047443wrn.247.1636106336898; Fri, 05 Nov 2021 02:58:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVMn64qcflGLedLN5EhsNM7GWU6o/3vwDL3aOoAYuCZV9//84CDnDeN1gsW9919fwpqQaOmg== X-Received: by 2002:adf:ec90:: with SMTP id z16mr46047414wrn.247.1636106336738; Fri, 05 Nov 2021 02:58:56 -0700 (PDT) Received: from [192.168.1.128] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id c17sm7678095wmk.23.2021.11.05.02.58.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 02:58:56 -0700 (PDT) Message-ID: <87a6bb4a-01ef-4979-f5c2-c0bb0d0a29f9@redhat.com> Date: Fri, 5 Nov 2021 10:58:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: Thomas Zimmermann , Jani Nikula , linux-kernel@vger.kernel.org References: <20211104160707.1407052-1-javierm@redhat.com> <20211104160707.1407052-3-javierm@redhat.com> <87cznf9cty.fsf@intel.com> <2698c680-6d05-f58d-d7c2-ea76aeb0bb47@suse.de> From: Javier Martinez Canillas In-Reply-To: <2698c680-6d05-f58d-d7c2-ea76aeb0bb47@suse.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 05 Nov 2021 14:25:39 +0000 Subject: Re: [Nouveau] [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, David Airlie , Joonas Lahtinen , dri-devel@lists.freedesktop.org, Gurchetan Singh , Gerd Hoffmann , amd-gfx@lists.freedesktop.org, VMware Graphics , Peter Robinson , nouveau@lists.freedesktop.org, Dave Airlie , Chia-I Wu , Ben Skeggs , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Maarten Lankhorst , Maxime Ripard , Hans de Goede , Rodrigo Vivi , virtualization@lists.linux-foundation.org, Pekka Paalanen , Greg Kroah-Hartman , "Pan, Xinhui" , spice-devel@lists.freedesktop.org, Daniel Vetter , Alex Deucher , intel-gfx@lists.freedesktop.org, =?UTF-8?Q?Christian_K=c3=b6nig?= , Zack Rusin Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On 11/5/21 10:39, Thomas Zimmermann wrote: [snip] >>>> >>>> +obj-$(CONFIG_VGA_CONSOLE) += drm_nomodeset.o >>>> + >>> >>> This now depends on the VGA textmode console. Even if you have no VGA >>> console, you'd want drm_nomodeset.o. Simpledrm might be built-in and can >>> provide graphics. Non-PC systems don't even have a VGA device. >> >> This was discussed in an earlier version, which had this builtin but the >> header still had a stub for CONFIG_VGA_CONSOLE=n. >> >>> I think we really want a separate boolean config option that gets >>> selected by CONFIG_DRM. >> >> Perhaps that should be a separate change on top. > > Sure, make it a separate patch. > Agreed. I was planning to do it as a follow-up as well and drop the #ifdef CONFIG_VGA_CONSOLE guard in the header. > We want to make this work on ARM systems. I even have a request to > replace offb on Power architecture by simpledrm. So the final config has > to be system agnostic. > Same, since we want to drop the fbdev drivers in Fedora, for all arches. > Best regards > Thomas > Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat