From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C03BEC433F5 for ; Fri, 11 Feb 2022 21:10:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353525AbiBKVK0 (ORCPT ); Fri, 11 Feb 2022 16:10:26 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231329AbiBKVKW (ORCPT ); Fri, 11 Feb 2022 16:10:22 -0500 Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B9A4BF7 for ; Fri, 11 Feb 2022 13:10:21 -0800 (PST) Received: from in01.mta.xmission.com ([166.70.13.51]:37100) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nIdBK-00E2Bx-SL; Fri, 11 Feb 2022 14:10:18 -0700 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:53086 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nIdBI-001IMe-Qe; Fri, 11 Feb 2022 14:10:18 -0700 From: "Eric W. Biederman" To: Arnd Bergmann Cc: Linus Torvalds , Stafford Horne , Michal Simek , Linux-Arch , LKML , Christoph Hellwig , Al Viro , Arnd Bergmann , Geert Uytterhoeven , "Peter Zijlstra (Intel)" , Catalin Marinas , Mark Rutland In-Reply-To: (Arnd Bergmann's message of "Fri, 11 Feb 2022 21:57:43 +0100") References: <20220117132757.1881981-1-arnd@kernel.org> <126ae5ee-342c-334c-9c07-c00213dd7b7e@xilinx.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Fri, 11 Feb 2022 15:10:10 -0600 Message-ID: <87a6exxg7h.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1nIdBI-001IMe-Qe;;;mid=<87a6exxg7h.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+UdMlaxxlAx0910DUy08LRd/8gtAunb88= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] microblaze: remove CONFIG_SET_FS X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > On Fri, Feb 11, 2022 at 6:46 PM Linus Torvalds > wrote: >> On Fri, Feb 11, 2022 at 9:00 AM Arnd Bergmann wrote: >> > >> > I have now uploaded a cleanup series to >> > https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=set_fs >> > >> > This uses the same access_ok() function across almost all >> > architectures, with the exception of those that need something else, >> > and I then I went further and killed off set_fs for everything other >> > than ia64. >> >> Thanks, looks good to me. >> >> Can you say why you didn't convert ia64? I don't see any set_fs() use >> there, except for the unaligned handler, which looks trivial to >> remove. It looks like the only reason for it is kernel-mode unaligned >> exceptions, which we should just turn fatal, I suspect (they already >> get logged). >> >> And ia64 people could make the unaligned handling do the kernel mode >> case in emulate_load/store_int() - it doesn't look *that* painful. >> >> But maybe you noticed something else? >> >> It would be really good to just be able to say that set_fs() no longer >> exists at all. > > I had previously gotten stuck at ia64, but gave it another go now > and uploaded an updated branch with ia64 taken care of and another > patch to clean up bits afterwards. > > I only gave it light testing so far, mainly building the defconfig for every > architecture. I'll post the series once the build bots are happy with the > branch overall. > Thank you so much for doing this work. Eric