All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tobias Waldekranz <tobias@waldekranz.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, kuba@kernel.org, madalin.bucur@nxp.com,
	robh+dt@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org,
	paulus@samba.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH net 4/4] net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module
Date: Mon, 17 Jan 2022 08:26:49 +0100	[thread overview]
Message-ID: <87a6fuddqe.fsf@waldekranz.com> (raw)
In-Reply-To: <YeST+TAREKIh2RXp@lunn.ch>

On Sun, Jan 16, 2022 at 22:54, Andrew Lunn <andrew@lunn.ch> wrote:
> On Sun, Jan 16, 2022 at 10:15:29PM +0100, Tobias Waldekranz wrote:
>> As reported by sparse: In the remove path, the driver would attempt to
>> unmap its own priv pointer - instead of the io memory that it mapped
>> in probe.
>
> Hi Tobias
>
> The change itself is O.K.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> But you could also change to devm_ so the core will handle the unmap,
> it is very unlikely to unmap the wrong thing.

Good idea. I have some more changes I want to include in this driver,
but they are more net-next material. Will try to work in this change as
well.

WARNING: multiple messages have this Message-ID (diff)
From: Tobias Waldekranz <tobias@waldekranz.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: devicetree@vger.kernel.org, madalin.bucur@nxp.com,
	robh+dt@kernel.org, paulus@samba.org, kuba@kernel.org,
	netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	davem@davemloft.net
Subject: Re: [PATCH net 4/4] net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module
Date: Mon, 17 Jan 2022 08:26:49 +0100	[thread overview]
Message-ID: <87a6fuddqe.fsf@waldekranz.com> (raw)
In-Reply-To: <YeST+TAREKIh2RXp@lunn.ch>

On Sun, Jan 16, 2022 at 22:54, Andrew Lunn <andrew@lunn.ch> wrote:
> On Sun, Jan 16, 2022 at 10:15:29PM +0100, Tobias Waldekranz wrote:
>> As reported by sparse: In the remove path, the driver would attempt to
>> unmap its own priv pointer - instead of the io memory that it mapped
>> in probe.
>
> Hi Tobias
>
> The change itself is O.K.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> But you could also change to devm_ so the core will handle the unmap,
> it is very unlikely to unmap the wrong thing.

Good idea. I have some more changes I want to include in this driver,
but they are more net-next material. Will try to work in this change as
well.

  reply	other threads:[~2022-01-17  7:26 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-16 21:15 [PATCH net 0/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885 Tobias Waldekranz
2022-01-16 21:15 ` Tobias Waldekranz
2022-01-16 21:15 ` [PATCH net 1/4] " Tobias Waldekranz
2022-01-16 21:15   ` Tobias Waldekranz
2022-01-16 22:02   ` Andrew Lunn
2022-01-16 22:02     ` Andrew Lunn
2022-01-17  7:24     ` Tobias Waldekranz
2022-01-17  7:24       ` Tobias Waldekranz
2022-01-17 14:00       ` Andrew Lunn
2022-01-17 14:00         ` Andrew Lunn
2022-01-18 20:34         ` Jakub Kicinski
2022-01-18 20:34           ` Jakub Kicinski
2022-01-18  8:40   ` Tobias Waldekranz
2022-01-18  8:40     ` Tobias Waldekranz
2022-01-16 21:15 ` [PATCH net 2/4] dt-bindings: net: Document fsl,erratum-a009885 Tobias Waldekranz
2022-01-16 21:15   ` Tobias Waldekranz
2022-01-16 21:56   ` Andrew Lunn
2022-01-16 21:56     ` Andrew Lunn
2022-01-16 21:15 ` [PATCH net 3/4] powerpc/fsl/dts: Enable WA for erratum A-009885 on fman3l MDIO buses Tobias Waldekranz
2022-01-16 21:15   ` Tobias Waldekranz
2022-01-18  8:41   ` Tobias Waldekranz
2022-01-18  8:41     ` Tobias Waldekranz
2022-01-16 21:15 ` [PATCH net 4/4] net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module Tobias Waldekranz
2022-01-16 21:15   ` Tobias Waldekranz
2022-01-16 21:54   ` Andrew Lunn
2022-01-16 21:54     ` Andrew Lunn
2022-01-17  7:26     ` Tobias Waldekranz [this message]
2022-01-17  7:26       ` Tobias Waldekranz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6fuddqe.fsf@waldekranz.com \
    --to=tobias@waldekranz.com \
    --cc=andrew@lunn.ch \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=madalin.bucur@nxp.com \
    --cc=mpe@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.