From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD5FC433EF for ; Tue, 11 Jan 2022 10:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237832AbiAKKaY (ORCPT ); Tue, 11 Jan 2022 05:30:24 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:48068 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236960AbiAKKaY (ORCPT ); Tue, 11 Jan 2022 05:30:24 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 013ED61577 for ; Tue, 11 Jan 2022 10:30:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65D2CC36AE3; Tue, 11 Jan 2022 10:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641897023; bh=gNqCMZ11UpYCH8D1vh+lSGQHiNJW0YuBO0Zbglzt9Jg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KlqD/LwnppBFjQL0vN1u+quxTAwVeJK57X0z2ilY36TjIpKvdqMpssewdLn1iXhbX SfpFg3/2D7Y+qmkX6UGgvsv4K+NMWKy/PO+qgyPFO4rX1y+n3DUWdw7AeFRPwrBN0p dDEJQ8kBII2lBY8Vw9s3u+Ura5m0z+xWYtcVnAouse5SProFAHYMdRgAo94CZmIRlP Jt0MeAG2DKSDAfdO0kxyNJRzxVxmnsVn1+DbhU5kKVA5MEuqjkCytkqpr2VBneq9BX qZYkk6oo1hi4TUDNuAEXBYFgNWgD/9pvt7i6IyS9Z02Ls07sh0Lntm9vHF7Mb+jSvG aB8fvaN2a7FnA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n7EQ1-00HM7n-HI; Tue, 11 Jan 2022 10:30:21 +0000 Date: Tue, 11 Jan 2022 10:30:21 +0000 Message-ID: <87a6g2tvia.wl-maz@kernel.org> From: Marc Zyngier To: Jing Zhang Cc: KVM , KVMARM , Will Deacon , Paolo Bonzini , David Matlack , Oliver Upton , Reiji Watanabe Subject: Re: [RFC PATCH 3/3] KVM: selftests: Add vgic initialization for dirty log perf test for ARM In-Reply-To: <20220110210441.2074798-4-jingzhangos@google.com> References: <20220110210441.2074798-1-jingzhangos@google.com> <20220110210441.2074798-4-jingzhangos@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jingzhangos@google.com, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, will@kernel.org, pbonzini@redhat.com, dmatlack@google.com, oupton@google.com, reijiw@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 10 Jan 2022 21:04:41 +0000, Jing Zhang wrote: > > For ARM64, if no vgic is setup before the dirty log perf test, the > userspace irqchip would be used, which would affect the dirty log perf > test result. Doesn't it affect *all* performance tests? How much does this change contributes to the performance numbers you give in the cover letter? > > Signed-off-by: Jing Zhang > --- > tools/testing/selftests/kvm/dirty_log_perf_test.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c > index 1954b964d1cf..b501338d9430 100644 > --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c > +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c > @@ -18,6 +18,12 @@ > #include "test_util.h" > #include "perf_test_util.h" > #include "guest_modes.h" > +#ifdef __aarch64__ > +#include "aarch64/vgic.h" > + > +#define GICD_BASE_GPA 0x8000000ULL > +#define GICR_BASE_GPA 0x80A0000ULL How did you pick these values? Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4197DC433F5 for ; Tue, 11 Jan 2022 10:30:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9D9A84B274; Tue, 11 Jan 2022 05:30:32 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JF5uNKnJXLEY; Tue, 11 Jan 2022 05:30:31 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 61B394B1F5; Tue, 11 Jan 2022 05:30:31 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3025D4B1F5 for ; Tue, 11 Jan 2022 05:30:30 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AOVFl4Ui2WxA for ; Tue, 11 Jan 2022 05:30:25 -0500 (EST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 444054B1E7 for ; Tue, 11 Jan 2022 05:30:25 -0500 (EST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 00BC361575; Tue, 11 Jan 2022 10:30:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65D2CC36AE3; Tue, 11 Jan 2022 10:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641897023; bh=gNqCMZ11UpYCH8D1vh+lSGQHiNJW0YuBO0Zbglzt9Jg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KlqD/LwnppBFjQL0vN1u+quxTAwVeJK57X0z2ilY36TjIpKvdqMpssewdLn1iXhbX SfpFg3/2D7Y+qmkX6UGgvsv4K+NMWKy/PO+qgyPFO4rX1y+n3DUWdw7AeFRPwrBN0p dDEJQ8kBII2lBY8Vw9s3u+Ura5m0z+xWYtcVnAouse5SProFAHYMdRgAo94CZmIRlP Jt0MeAG2DKSDAfdO0kxyNJRzxVxmnsVn1+DbhU5kKVA5MEuqjkCytkqpr2VBneq9BX qZYkk6oo1hi4TUDNuAEXBYFgNWgD/9pvt7i6IyS9Z02Ls07sh0Lntm9vHF7Mb+jSvG aB8fvaN2a7FnA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n7EQ1-00HM7n-HI; Tue, 11 Jan 2022 10:30:21 +0000 Date: Tue, 11 Jan 2022 10:30:21 +0000 Message-ID: <87a6g2tvia.wl-maz@kernel.org> From: Marc Zyngier To: Jing Zhang Subject: Re: [RFC PATCH 3/3] KVM: selftests: Add vgic initialization for dirty log perf test for ARM In-Reply-To: <20220110210441.2074798-4-jingzhangos@google.com> References: <20220110210441.2074798-1-jingzhangos@google.com> <20220110210441.2074798-4-jingzhangos@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jingzhangos@google.com, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, will@kernel.org, pbonzini@redhat.com, dmatlack@google.com, oupton@google.com, reijiw@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: KVM , David Matlack , Paolo Bonzini , Will Deacon , KVMARM X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, 10 Jan 2022 21:04:41 +0000, Jing Zhang wrote: > > For ARM64, if no vgic is setup before the dirty log perf test, the > userspace irqchip would be used, which would affect the dirty log perf > test result. Doesn't it affect *all* performance tests? How much does this change contributes to the performance numbers you give in the cover letter? > > Signed-off-by: Jing Zhang > --- > tools/testing/selftests/kvm/dirty_log_perf_test.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c > index 1954b964d1cf..b501338d9430 100644 > --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c > +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c > @@ -18,6 +18,12 @@ > #include "test_util.h" > #include "perf_test_util.h" > #include "guest_modes.h" > +#ifdef __aarch64__ > +#include "aarch64/vgic.h" > + > +#define GICD_BASE_GPA 0x8000000ULL > +#define GICR_BASE_GPA 0x80A0000ULL How did you pick these values? Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm