All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] usb: phy: isp1301: Deduplicate of_find_i2c_device_by_node()
@ 2021-05-21 14:52 Andy Shevchenko
  2021-06-03 14:33 ` Felipe Balbi
  0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2021-05-21 14:52 UTC (permalink / raw)
  To: Andy Shevchenko, linux-usb, linux-kernel; +Cc: Felipe Balbi, Greg Kroah-Hartman

The driver is using open-coded variant of of_find_i2c_device_by_node().
Replace it by the actual call to the above mentioned API.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/usb/phy/phy-isp1301.c | 25 +++++++++----------------
 1 file changed, 9 insertions(+), 16 deletions(-)

diff --git a/drivers/usb/phy/phy-isp1301.c b/drivers/usb/phy/phy-isp1301.c
index 6cf6fbd39237..ad3d57f1c273 100644
--- a/drivers/usb/phy/phy-isp1301.c
+++ b/drivers/usb/phy/phy-isp1301.c
@@ -142,24 +142,17 @@ static struct i2c_driver isp1301_driver = {
 
 module_i2c_driver(isp1301_driver);
 
-static int match(struct device *dev, const void *data)
-{
-	const struct device_node *node = (const struct device_node *)data;
-	return (dev->of_node == node) &&
-		(dev->driver == &isp1301_driver.driver);
-}
-
 struct i2c_client *isp1301_get_client(struct device_node *node)
 {
-	if (node) { /* reference of ISP1301 I2C node via DT */
-		struct device *dev = bus_find_device(&i2c_bus_type, NULL,
-						     node, match);
-		if (!dev)
-			return NULL;
-		return to_i2c_client(dev);
-	} else { /* non-DT: only one ISP1301 chip supported */
-		return isp1301_i2c_client;
-	}
+	struct i2c_client *client;
+
+	/* reference of ISP1301 I2C node via DT */
+	client = of_find_i2c_device_by_node(node);
+	if (client)
+		return client;
+
+	/* non-DT: only one ISP1301 chip supported */
+	return isp1301_i2c_client;
 }
 EXPORT_SYMBOL_GPL(isp1301_get_client);
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v1 1/1] usb: phy: isp1301: Deduplicate of_find_i2c_device_by_node()
  2021-05-21 14:52 [PATCH v1 1/1] usb: phy: isp1301: Deduplicate of_find_i2c_device_by_node() Andy Shevchenko
@ 2021-06-03 14:33 ` Felipe Balbi
  0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2021-06-03 14:33 UTC (permalink / raw)
  To: Andy Shevchenko, Andy Shevchenko, linux-usb, linux-kernel
  Cc: Greg Kroah-Hartman

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> The driver is using open-coded variant of of_find_i2c_device_by_node().
> Replace it by the actual call to the above mentioned API.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Felipe Balbi <balbi@kernel.org>

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-03 14:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 14:52 [PATCH v1 1/1] usb: phy: isp1301: Deduplicate of_find_i2c_device_by_node() Andy Shevchenko
2021-06-03 14:33 ` Felipe Balbi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.