From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E03EC433ED for ; Tue, 20 Apr 2021 13:04:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3911E613C8 for ; Tue, 20 Apr 2021 13:04:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231422AbhDTNEj (ORCPT ); Tue, 20 Apr 2021 09:04:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:57106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230408AbhDTNEj (ORCPT ); Tue, 20 Apr 2021 09:04:39 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9FE4060233; Tue, 20 Apr 2021 13:04:07 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lYq2u-008UgK-76; Tue, 20 Apr 2021 14:04:04 +0100 Date: Tue, 20 Apr 2021 14:04:03 +0100 Message-ID: <87a6ptqf98.wl-maz@kernel.org> From: Marc Zyngier To: Jon Hunter Cc: Thierry Reding , Lorenzo Pieralisi , Bjorn Helgaas , , Subject: Re: [PATCH] PCI: tegra: Don't rename the Tegra MSI interrupt In-Reply-To: <20210420125545.1315970-1-jonathanh@nvidia.com> References: <20210420125545.1315970-1-jonathanh@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: jonathanh@nvidia.com, thierry.reding@gmail.com, lorenzo.pieralisi@arm.com, bhelgaas@google.com, linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, 20 Apr 2021 13:55:45 +0100, Jon Hunter wrote: > > Commit 973a28677e39 ("PCI: tegra: Convert to MSI domains") renamed the > Tegra PCIe MSI interrupt from 'Tegra PCIe MSI' to 'tegra PCIe MSI'. This > is breaking a PCIe sanity test that we are running on Tegra124 Jetson > TK1 because it is looking for an interrupt called 'Tegra PCIe MSI' which > is no longer found. Although we could update the test to fix this, at > the same time it does not seem necessary to rename the interrupt. > Therefore, change the name of the interrupt back to 'Tegra PCIe MSI'. > > Fixes: 973a28677e39 ("PCI: tegra: Convert to MSI domains") > Signed-off-by: Jon Hunter > --- > drivers/pci/controller/pci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c > index eaba7b2fab4a..32ca16c87092 100644 > --- a/drivers/pci/controller/pci-tegra.c > +++ b/drivers/pci/controller/pci-tegra.c > @@ -1593,7 +1593,7 @@ static void tegra_msi_top_irq_unmask(struct irq_data *d) > } > > static struct irq_chip tegra_msi_top_chip = { > - .name = "tegra PCIe MSI", > + .name = "Tegra PCIe MSI", > .irq_ack = tegra_msi_top_irq_ack, > .irq_mask = tegra_msi_top_irq_mask, > .irq_unmask = tegra_msi_top_irq_unmask, Ah, apologies for the spurious renaming. I always wondered if userspace would actually be parsing this, and it turns out that it is indeed the case. Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.