From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C898DC43381 for ; Fri, 12 Mar 2021 11:26:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2503C64F6D for ; Fri, 12 Mar 2021 11:26:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2503C64F6D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKfve-0001FJ-6z for qemu-devel@archiver.kernel.org; Fri, 12 Mar 2021 06:26:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKfuF-0000a5-B4 for qemu-devel@nongnu.org; Fri, 12 Mar 2021 06:24:35 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:39563) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKfuD-0004FI-Mp for qemu-devel@nongnu.org; Fri, 12 Mar 2021 06:24:35 -0500 Received: by mail-ed1-x532.google.com with SMTP id bf3so7423615edb.6 for ; Fri, 12 Mar 2021 03:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=jdrERCIId53JZOmbF/W+6yOqQeKiCLJGK0R9ZuscgJc=; b=n0c966vgojfYkIBr9pbnsU1wVasOtU9V6dqqI9lTWaY8H1RHE8ZWDxKeluMDCBt9lL d8TNpiQ5cZJo6nCo6DUiAny3lKbja0mYK1Gp3E/1wL1H28KmIqWzxjdMZO8XDGWqbBMX vGIq0Xfwiy0SAcDnuwfI9qWArrev590dDPdSp0032mV4qI93nTN+NkVUT64g7JmgwFRY pR62iFp8RxTSXBUfsGpE2TJLeggZI598n2rxkWBXBloQfyAY6np2xy1DfX05ydlDySdt lMCahzkH1nBQkny0CIZSXcAdcY8eN/vA2Ri7Kdi4oOlZEgJwFk37ezdNBomXN5B5rcC1 Tz3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=jdrERCIId53JZOmbF/W+6yOqQeKiCLJGK0R9ZuscgJc=; b=ad2owQBkhQYSNIorNVLrYuvCxbQM2Ia2XgNQ4Z/BFttnTeBiHnjLtYy0v59oi1E31L mylNcL8Oq6c7SYin2+/1MN/4VUz8L3kDfw9AVNaIaYBuUBTj4u28v8ku6lTtfpu3dGE9 xXVZ0yWRIEmrZlJ5NO0s02XkoozgbuWcRfvHvCgG8xnZGoM4TfwJDWIo0Hi0ivQiLmTj K/duCLUWgN9thLfre8N9sD+4SScsKuizTaVkEU+d6FVXCh0zST90iqLJGnPzPsRm3F9q v0JTUGZ1fnixw+8R8+riZlmetjwwTkLgG71WoVQKhZTaus76lydmwS5lLbu84m7YQczs cYKQ== X-Gm-Message-State: AOAM531c/lL+2FYc1v8aedfoBlMsm4WChq0cd/Qwp8lldjAX9Ln/38LJ 9b1+7CEjbbi/NplPvgWHNuQulw== X-Google-Smtp-Source: ABdhPJwj5/uZJnuk9PypIlzMwzaGxeqLqotY+U1lF5MRaSko59hSrWbo7cH+oyy9ENuPg49w5+KfaA== X-Received: by 2002:aa7:d588:: with SMTP id r8mr13467295edq.88.1615548271754; Fri, 12 Mar 2021 03:24:31 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id c19sm2772387edu.20.2021.03.12.03.24.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 03:24:31 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 350231FF7E; Fri, 12 Mar 2021 11:24:30 +0000 (GMT) References: <20210312102029.17017-1-alex.bennee@linaro.org> <20210312102029.17017-6-alex.bennee@linaro.org> User-agent: mu4e 1.5.10; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Peter Maydell Subject: Re: [PATCH v5 5/5] tests/tcg: add HeapInfo checking to semihosting test Date: Fri, 12 Mar 2021 11:23:05 +0000 In-reply-to: Message-ID: <87a6r8ehsi.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Packard , qemu-arm , "open list:RISC-V" , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Maydell writes: > On Fri, 12 Mar 2021 at 10:31, Alex Benn=3DC3=3DA9e wro=3D > te: >> >> Query the SYS_HEAPINFO semicall and do some basic verification of the >> information via libc calls. > > Are we both testing system emulation and linux-user, or just one of the t= wo=3D > ? Currently just linux-user. There is no inherent reason we couldn't add a system emulation test but I felt that was already reasonably exercised by your semihosting tests. > (Not that I want to hold this up if we're only testing one, but coverage > of both, including M-profile, seems like it would be useful; cf also > https://bugs.launchpad.net/qemu/+bug/1918302 which is M-profile system-em= ul=3D > ation > SYS_HEAPINFO being broken in 5.2.) > > thanks > -- PMM --=20 Alex Benn=C3=A9e From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lKfuG-0000b9-W3 for mharc-qemu-riscv@gnu.org; Fri, 12 Mar 2021 06:24:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKfuF-0000a4-A4 for qemu-riscv@nongnu.org; Fri, 12 Mar 2021 06:24:35 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:45593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKfuD-0004FJ-Ll for qemu-riscv@nongnu.org; Fri, 12 Mar 2021 06:24:34 -0500 Received: by mail-ed1-x536.google.com with SMTP id bx7so7420887edb.12 for ; Fri, 12 Mar 2021 03:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=jdrERCIId53JZOmbF/W+6yOqQeKiCLJGK0R9ZuscgJc=; b=n0c966vgojfYkIBr9pbnsU1wVasOtU9V6dqqI9lTWaY8H1RHE8ZWDxKeluMDCBt9lL d8TNpiQ5cZJo6nCo6DUiAny3lKbja0mYK1Gp3E/1wL1H28KmIqWzxjdMZO8XDGWqbBMX vGIq0Xfwiy0SAcDnuwfI9qWArrev590dDPdSp0032mV4qI93nTN+NkVUT64g7JmgwFRY pR62iFp8RxTSXBUfsGpE2TJLeggZI598n2rxkWBXBloQfyAY6np2xy1DfX05ydlDySdt lMCahzkH1nBQkny0CIZSXcAdcY8eN/vA2Ri7Kdi4oOlZEgJwFk37ezdNBomXN5B5rcC1 Tz3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=jdrERCIId53JZOmbF/W+6yOqQeKiCLJGK0R9ZuscgJc=; b=XGYiFQbgJNjc4IketWPCnA18DTjlZ0o/9cKdhtnzj0nJFjuG/UoA4xPrGYN5Rw9Oyv 9meMu6EDsJPD7eHVIU3FnmhW10aX9bJZBuGxE/ondHtiHVeefAJ2BDZANvdJg7iT5VM5 GqKkU53ir5YHHzST480IY0kq/l9BYDKRt3oU9gDn4MfJvHHssIbP/lHudGBosvoq/M2Q ttBeRRVtKH1kAkFE6wgWhaWhucAvTq6yXcnR8uHKIxfJpTuSCvarNi4eVw4/GMYLmZ2d 09vBQncLk+tCoyeS4YrLWH2DXsI+j8w489Wlu3vWMKPgNo64URW3aYhOfEgh9WElHNky s5jQ== X-Gm-Message-State: AOAM530dmZoOVDe0oWZTk/CTpw+GBS29InfQ8FHtvNZWfCKUFJzMyRC5 5Cod+RYpsJt3f3F1Mp2JyF/k+A== X-Google-Smtp-Source: ABdhPJwj5/uZJnuk9PypIlzMwzaGxeqLqotY+U1lF5MRaSko59hSrWbo7cH+oyy9ENuPg49w5+KfaA== X-Received: by 2002:aa7:d588:: with SMTP id r8mr13467295edq.88.1615548271754; Fri, 12 Mar 2021 03:24:31 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id c19sm2772387edu.20.2021.03.12.03.24.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 03:24:31 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 350231FF7E; Fri, 12 Mar 2021 11:24:30 +0000 (GMT) References: <20210312102029.17017-1-alex.bennee@linaro.org> <20210312102029.17017-6-alex.bennee@linaro.org> User-agent: mu4e 1.5.10; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Peter Maydell Cc: QEMU Developers , Keith Packard , qemu-arm , "open list:RISC-V" Subject: Re: [PATCH v5 5/5] tests/tcg: add HeapInfo checking to semihosting test Date: Fri, 12 Mar 2021 11:23:05 +0000 In-reply-to: Message-ID: <87a6r8ehsi.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2021 11:24:35 -0000 Peter Maydell writes: > On Fri, 12 Mar 2021 at 10:31, Alex Benn=3DC3=3DA9e wro=3D > te: >> >> Query the SYS_HEAPINFO semicall and do some basic verification of the >> information via libc calls. > > Are we both testing system emulation and linux-user, or just one of the t= wo=3D > ? Currently just linux-user. There is no inherent reason we couldn't add a system emulation test but I felt that was already reasonably exercised by your semihosting tests. > (Not that I want to hold this up if we're only testing one, but coverage > of both, including M-profile, seems like it would be useful; cf also > https://bugs.launchpad.net/qemu/+bug/1918302 which is M-profile system-em= ul=3D > ation > SYS_HEAPINFO being broken in 5.2.) > > thanks > -- PMM --=20 Alex Benn=C3=A9e