All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aurélien Aptel" <aaptel@suse.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-sparse@vger.kernel.org
Subject: Re: using sparse to catch refcount leaks
Date: Mon, 13 Jul 2020 12:50:44 +0200	[thread overview]
Message-ID: <87a703eliz.fsf@suse.com> (raw)
In-Reply-To: <20200710085927.GN2549@kadam>

Dan Carpenter <dan.carpenter@oracle.com> writes:
> In this CIFS case, the leak is on the success path (as well as the
> failure path) so my theory would be that it would be caught in testing
> and will only cause false positives for static analysis.  I can't see
> any automated way to know which success paths should take a reference
> and which should not.

Ah, I see. I guess with extra annotations and more sophisticated
analysis we could have something but it seems out of scope.

Anyway, thanks for looking into it.

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

      reply	other threads:[~2020-07-13 10:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 15:50 using sparse to catch refcount leaks Aurélien Aptel
2020-07-09 18:48 ` Luc Van Oostenryck
2020-07-10  8:59 ` Dan Carpenter
2020-07-13 10:50   ` Aurélien Aptel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a703eliz.fsf@suse.com \
    --to=aaptel@suse.com \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-sparse@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.