From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C60FC2D0C6 for ; Wed, 11 Dec 2019 23:11:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 413DF2073D for ; Wed, 11 Dec 2019 23:11:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726986AbfLKXL6 (ORCPT ); Wed, 11 Dec 2019 18:11:58 -0500 Received: from mga14.intel.com ([192.55.52.115]:60021 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbfLKXL6 (ORCPT ); Wed, 11 Dec 2019 18:11:58 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 15:05:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,303,1571727600"; d="scan'208";a="238734369" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by fmsmga004.fm.intel.com with ESMTP; 11 Dec 2019 15:05:48 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id 608573002C5; Wed, 11 Dec 2019 15:05:48 -0800 (PST) From: Andi Kleen To: Waiman Long Cc: Mike Kravetz , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH v2] hugetlbfs: Disable softIRQ when taking hugetlb_lock References: <20191211194615.18502-1-longman@redhat.com> Date: Wed, 11 Dec 2019 15:05:48 -0800 In-Reply-To: <20191211194615.18502-1-longman@redhat.com> (Waiman Long's message of "Wed, 11 Dec 2019 14:46:15 -0500") Message-ID: <87a77yv4xf.fsf@linux.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Waiman Long writes: > > Currently, only free_huge_page() is known to be called from softIRQ > context. Called from a timer? Perhaps just move that to a work queue instead. That seems preferable than to increase softirq latency. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A9D2C43603 for ; Wed, 11 Dec 2019 23:05:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6FE3222C4 for ; Wed, 11 Dec 2019 23:05:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6FE3222C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 70D246B3464; Wed, 11 Dec 2019 18:05:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BCF56B3465; Wed, 11 Dec 2019 18:05:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F90D6B3466; Wed, 11 Dec 2019 18:05:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 4CA366B3464 for ; Wed, 11 Dec 2019 18:05:51 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 01D1F2480 for ; Wed, 11 Dec 2019 23:05:51 +0000 (UTC) X-FDA: 76254394902.02.sea14_5010eea21114e X-HE-Tag: sea14_5010eea21114e X-Filterd-Recvd-Size: 1747 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Dec 2019 23:05:49 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 15:05:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,303,1571727600"; d="scan'208";a="238734369" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by fmsmga004.fm.intel.com with ESMTP; 11 Dec 2019 15:05:48 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id 608573002C5; Wed, 11 Dec 2019 15:05:48 -0800 (PST) From: Andi Kleen To: Waiman Long Cc: Mike Kravetz , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH v2] hugetlbfs: Disable softIRQ when taking hugetlb_lock References: <20191211194615.18502-1-longman@redhat.com> Date: Wed, 11 Dec 2019 15:05:48 -0800 In-Reply-To: <20191211194615.18502-1-longman@redhat.com> (Waiman Long's message of "Wed, 11 Dec 2019 14:46:15 -0500") Message-ID: <87a77yv4xf.fsf@linux.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Waiman Long writes: > > Currently, only free_huge_page() is known to be called from softIRQ > context. Called from a timer? Perhaps just move that to a work queue instead. That seems preferable than to increase softirq latency. -Andi