From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Chuang <yhchuang@realtek.com>
Cc: Brian Norris <briannorris@chromium.org>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"g.schlmm\@googlemail.com" <g.schlmm@googlemail.com>
Subject: Re: [PATCH 3/6] rtw88: use a module parameter to control LPS enter
Date: Fri, 01 Nov 2019 10:35:53 +0200 [thread overview]
Message-ID: <87a79g0z9y.fsf@codeaurora.org> (raw)
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D19159DA@RTITMBSVM04.realtek.com.tw> (Tony Chuang's message of "Fri, 1 Nov 2019 03:13:41 +0000")
Tony Chuang <yhchuang@realtek.com> writes:
>> On Thu, Oct 31, 2019 at 1:17 AM Tony Chuang <yhchuang@realtek.com>
>> wrote:
>> > Or I should just change the
>> > value to a better one. By our experience, set this to 50 is a more reasonable
>> > value, such that some web surfing or background traffic wouldn't make the
>> > driver to leave PS mode.
>>
>> FWIW, I think choosing a more reasonable default is definitely a good
>> start, as long as this choice doesn't have huge downsides.
>>
>> @Kalle: FYI, this (set to 50) is exactly the change that Tony is
>> recommending to me for my distro, and I have the same qualms about
>> supporting a growing number of module parameter tweaks like this. So,
>> thanks for pushing back :)
>>
>> Brian
>>
>
> I was afraid of you thinking that setting this to 50 is a strange thing.
> But it seems like you'd prefer to change the default value instead of adding a
> module parameter to control it. I think we can drop this one and I will send
> a patch to change the default value to 50.
Yeah, as the first step changing to 50 sounds good to me. Later, if
needed, we can extend it to make it configurable from user space, either
via the QoS framework or something else.
--
Kalle Valo
next prev parent reply other threads:[~2019-11-01 8:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 9:33 [PATCH 0/6] rtw88: minor driver updates yhchuang
2019-10-25 9:33 ` [PATCH 1/6] rtw88: 8822b: add RFE type 3 support yhchuang
2019-10-31 8:04 ` Kalle Valo
2019-10-25 9:33 ` [PATCH 2/6] rtw88: use rtw_phy_pg_cfg_pair struct, not arrays yhchuang
2019-10-25 9:33 ` [PATCH 3/6] rtw88: use a module parameter to control LPS enter yhchuang
2019-10-25 10:51 ` Chris Chiu
2019-10-28 3:12 ` Tony Chuang
2019-10-29 4:01 ` Chris Chiu
2019-10-31 7:59 ` Kalle Valo
[not found] ` <20191031075911.3CCB86079C@smtp.codeaurora.org>
2019-10-31 8:17 ` Tony Chuang
2019-10-31 20:01 ` Brian Norris
2019-11-01 3:13 ` Tony Chuang
2019-11-01 8:35 ` Kalle Valo [this message]
2019-11-01 8:30 ` Kalle Valo
2019-10-25 9:33 ` [PATCH 4/6] rtw88: rearrange if..else statements for rx rate indexes yhchuang
2019-10-25 9:33 ` [PATCH 5/6] rtw88: fix potential read outside array boundary yhchuang
2019-10-25 9:33 ` [PATCH 6/6] rtw88: avoid FW info flood yhchuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a79g0z9y.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=g.schlmm@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.