From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3205ECA9EA0 for ; Fri, 18 Oct 2019 14:22:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03A2021897 for ; Fri, 18 Oct 2019 14:22:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hif1k7pL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408010AbfJROWU (ORCPT ); Fri, 18 Oct 2019 10:22:20 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:35445 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731923AbfJROWU (ORCPT ); Fri, 18 Oct 2019 10:22:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571408538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CZJB5jgfqOkbA3pAcKVegphLG5lxMMLqppKUI+v+NT0=; b=Hif1k7pLT/Gx/6uJe+02IFcuD8dU10UkQf4Tq2vEJAIcAHnqB5ol0oYS4CqcJdCWYFgGYB k3owWmsGa7cl6S0CNP6qTwU191yNMjhkUXwDQGt5iQtVV+2+dGaKxR6nALtIF7r2wqSEAd A4xcSjkn8gXpmDfqpO8DeqcYlb78Rrw= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-YOiv59G4MtS3su_oRgnoVg-1; Fri, 18 Oct 2019 10:22:17 -0400 Received: by mail-lj1-f197.google.com with SMTP id p14so1105432ljh.22 for ; Fri, 18 Oct 2019 07:22:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=WFSLNDo34e/hQ4mMaXqwSinumGcSHTA3VPI9PdShktc=; b=mYiq6iZLjQoxtXXyUQC2O68BbBPvOsP+PKAKdit2sTrsxyr9YQX28t3fTQ54fT8aTD 8MJLavEii2HuP1l47GYxDottiV03d4Kuf06Yq5TS07H3xpbNC9Qk2y6am56ZPTlx1itl bsJASdZhEEPMQo7Yw1B3AiJN+dE7QDkUMMKjUgLIjq2ijnl49I6qltuFA8BQmvHlCMVn I1GuTLqWA8SSJKgoPMpnqTHo5qVHvvUG71CpMGz9rmmHZwea4P8dPsUaed76UgHSFnBA ntQIXga0AA6fzhikizIz4eYTmIgZmIToW3+Uoxved8zV59WcUU3epWKZa2AkMibV9XdT LJ6Q== X-Gm-Message-State: APjAAAWap8kMd+jBdXZwlgjoO+x84t1Jx1F4/9DRG3OJLT7fSzxdP+Fr tu9D6QazhUS8Qsh8uzfsNMj0eGx2FzbCsNNRH3vx0tsIeAl37WEjVzEra22c4RuYKjAgXZasKn0 piSokQTLYIN7olGaU9V8/ClvYWI8= X-Received: by 2002:a19:22c4:: with SMTP id i187mr5926913lfi.152.1571408535630; Fri, 18 Oct 2019 07:22:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxqkwQ+FzoYv6pBFiWwEhgsIA1mrDfY6EuiAaZf0ZL91B2Z9tof0t8W9lR0jkYi1be643oQ1Q== X-Received: by 2002:a19:22c4:: with SMTP id i187mr5926898lfi.152.1571408535451; Fri, 18 Oct 2019 07:22:15 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id g3sm2667601lja.61.2019.10.18.07.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 07:22:14 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 0FF491804B6; Fri, 18 Oct 2019 16:22:14 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg , Kan Yan Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes Subject: Re: [PATCH v2 1/4] mac80211: Rearrange ieee80211_tx_info to make room for tx_time_est In-Reply-To: References: <157115993755.2500430.12214017471129215800.stgit@toke.dk> <157115993866.2500430.13989567853855880476.stgit@toke.dk> <87sgnqe4wg.fsf@toke.dk> <10b885b3238cede2d99c6134bebcc0c8ba6f6b10.camel@sipsolutions.net> <87imomdvsj.fsf@toke.dk> <9fc60b546b54b40357264d67536733251cf39ebe.camel@sipsolutions.net> <87d0eudufu.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 18 Oct 2019 16:22:14 +0200 Message-ID: <87a79ydtgp.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: YOiv59G4MtS3su_oRgnoVg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: > On Fri, 2019-10-18 at 16:01 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote= : > >> Right. Well in that case, let's try it. As long as we fail in a >> reasonable way, we can just see if we run into anything that breaks? I >> guess in this case that means rejecting requests from userspace if we >> run out of IDs rather than silently wrapping and returning wrong data :) > > We can't reject due to how this works, but if the idr_alloc() fails then > we'll just not give a status back to userspace later. OK, I guess someone will notice if that suddenly starts happening all the time ;) >> > > We could also split 5/11. That would support up to 32 ACK IDs, and w= e >> > > can just truncate the airtime at 2048 us, which is not a big deal I'= d >> > > say. >> >=20 >> > We can also play with the units of the airtime, e.g. making that a >> > multiple of 2 or 4 us? Seems unlikely to matter much? >>=20 >> Sure, that's a good point! Increments of 4us means we can fit 4ms is 10 >> bits, leaving plenty of space for ACK IDs (hopefully). >>=20 >> I'll rework the series to use that instead :) > > OK. > > There are two places that call idr_alloc() with a hardcoded limit of > 0x10000, you'll have to fix those to have the right limit according to > the bits you leave for the ACK id. Yup, found those. Will send a new version of the series in a bit. -Toke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-1.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLT91-0000IE-Ui for ath10k@lists.infradead.org; Fri, 18 Oct 2019 14:22:21 +0000 Received: by mail-lf1-f71.google.com with SMTP id m17so1314726lfl.11 for ; Fri, 18 Oct 2019 07:22:16 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH v2 1/4] mac80211: Rearrange ieee80211_tx_info to make room for tx_time_est In-Reply-To: References: <157115993755.2500430.12214017471129215800.stgit@toke.dk> <157115993866.2500430.13989567853855880476.stgit@toke.dk> <87sgnqe4wg.fsf@toke.dk> <10b885b3238cede2d99c6134bebcc0c8ba6f6b10.camel@sipsolutions.net> <87imomdvsj.fsf@toke.dk> <9fc60b546b54b40357264d67536733251cf39ebe.camel@sipsolutions.net> <87d0eudufu.fsf@toke.dk> Date: Fri, 18 Oct 2019 16:22:14 +0200 Message-ID: <87a79ydtgp.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg , Kan Yan Cc: Rajkumar Manoharan , Kevin Hayes , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau Sm9oYW5uZXMgQmVyZyA8am9oYW5uZXNAc2lwc29sdXRpb25zLm5ldD4gd3JpdGVzOgoKPiBPbiBG cmksIDIwMTktMTAtMTggYXQgMTY6MDEgKzAyMDAsIFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiB3 cm90ZToKPgo+PiBSaWdodC4gV2VsbCBpbiB0aGF0IGNhc2UsIGxldCdzIHRyeSBpdC4gQXMgbG9u ZyBhcyB3ZSBmYWlsIGluIGEKPj4gcmVhc29uYWJsZSB3YXksIHdlIGNhbiBqdXN0IHNlZSBpZiB3 ZSBydW4gaW50byBhbnl0aGluZyB0aGF0IGJyZWFrcz8gSQo+PiBndWVzcyBpbiB0aGlzIGNhc2Ug dGhhdCBtZWFucyByZWplY3RpbmcgcmVxdWVzdHMgZnJvbSB1c2Vyc3BhY2UgaWYgd2UKPj4gcnVu IG91dCBvZiBJRHMgcmF0aGVyIHRoYW4gc2lsZW50bHkgd3JhcHBpbmcgYW5kIHJldHVybmluZyB3 cm9uZyBkYXRhIDopCj4KPiBXZSBjYW4ndCByZWplY3QgZHVlIHRvIGhvdyB0aGlzIHdvcmtzLCBi dXQgaWYgdGhlIGlkcl9hbGxvYygpIGZhaWxzIHRoZW4KPiB3ZSdsbCBqdXN0IG5vdCBnaXZlIGEg c3RhdHVzIGJhY2sgdG8gdXNlcnNwYWNlIGxhdGVyLgoKT0ssIEkgZ3Vlc3Mgc29tZW9uZSB3aWxs IG5vdGljZSBpZiB0aGF0IHN1ZGRlbmx5IHN0YXJ0cyBoYXBwZW5pbmcgYWxsCnRoZSB0aW1lIDsp Cgo+PiA+ID4gV2UgY291bGQgYWxzbyBzcGxpdCA1LzExLiBUaGF0IHdvdWxkIHN1cHBvcnQgdXAg dG8gMzIgQUNLIElEcywgYW5kIHdlCj4+ID4gPiBjYW4ganVzdCB0cnVuY2F0ZSB0aGUgYWlydGlt ZSBhdCAyMDQ4IHVzLCB3aGljaCBpcyBub3QgYSBiaWcgZGVhbCBJJ2QKPj4gPiA+IHNheS4KPj4g PiAKPj4gPiBXZSBjYW4gYWxzbyBwbGF5IHdpdGggdGhlIHVuaXRzIG9mIHRoZSBhaXJ0aW1lLCBl LmcuIG1ha2luZyB0aGF0IGEKPj4gPiBtdWx0aXBsZSBvZiAyIG9yIDQgdXM/IFNlZW1zIHVubGlr ZWx5IHRvIG1hdHRlciBtdWNoPwo+PiAKPj4gU3VyZSwgdGhhdCdzIGEgZ29vZCBwb2ludCEgSW5j cmVtZW50cyBvZiA0dXMgbWVhbnMgd2UgY2FuIGZpdCA0bXMgaXMgMTAKPj4gYml0cywgbGVhdmlu ZyBwbGVudHkgb2Ygc3BhY2UgZm9yIEFDSyBJRHMgKGhvcGVmdWxseSkuCj4+IAo+PiBJJ2xsIHJl d29yayB0aGUgc2VyaWVzIHRvIHVzZSB0aGF0IGluc3RlYWQgOikKPgo+IE9LLgo+Cj4gVGhlcmUg YXJlIHR3byBwbGFjZXMgdGhhdCBjYWxsIGlkcl9hbGxvYygpIHdpdGggYSBoYXJkY29kZWQgbGlt aXQgb2YKPiAweDEwMDAwLCB5b3UnbGwgaGF2ZSB0byBmaXggdGhvc2UgdG8gaGF2ZSB0aGUgcmln aHQgbGltaXQgYWNjb3JkaW5nIHRvCj4gdGhlIGJpdHMgeW91IGxlYXZlIGZvciB0aGUgQUNLIGlk LgoKWXVwLCBmb3VuZCB0aG9zZS4gV2lsbCBzZW5kIGEgbmV3IHZlcnNpb24gb2YgdGhlIHNlcmll cyBpbiBhIGJpdC4KCi1Ub2tlCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo=