From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DDFCC73C68 for ; Wed, 10 Jul 2019 04:12:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9D9520645 for ; Wed, 10 Jul 2019 04:12:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9D9520645 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl3yP-00026I-NF for qemu-devel@archiver.kernel.org; Wed, 10 Jul 2019 00:12:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56112) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl3xO-0001ZZ-Pb for qemu-devel@nongnu.org; Wed, 10 Jul 2019 00:11:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hl3xM-0001yH-S9 for qemu-devel@nongnu.org; Wed, 10 Jul 2019 00:11:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50774) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hl3xH-0001rC-3n; Wed, 10 Jul 2019 00:11:44 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 12C7C308210D; Wed, 10 Jul 2019 04:11:39 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-111.ams2.redhat.com [10.36.116.111]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B9A0B60852; Wed, 10 Jul 2019 04:11:33 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3648E1138648; Wed, 10 Jul 2019 06:11:32 +0200 (CEST) From: Markus Armbruster To: John Snow References: <20190709232550.10724-1-jsnow@redhat.com> <20190709232550.10724-2-jsnow@redhat.com> Date: Wed, 10 Jul 2019 06:11:32 +0200 In-Reply-To: (John Snow's message of "Tue, 9 Jul 2019 21:36:19 -0400") Message-ID: <87a7dmy1e3.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 10 Jul 2019 04:11:39 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v4 01/18] qapi/block-core: Introduce BackupCommon X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , vsementsov@virtuozzo.com, qemu-block@nongnu.org, Juan Quintela , Wen Congyang , Xie Changlong , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Stefan Hajnoczi , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > On 7/9/19 7:25 PM, John Snow wrote: >> drive-backup and blockdev-backup have an awful lot of things in common >> that are the same. Let's fix that. >> >> I don't deduplicate 'target', because the semantics actually did change >> between each structure. Leave that one alone so it can be documented >> separately. > > Sorry Markus, I forgot to adjust this. Pretend I wrote: > > Where documentation was not identical, use the most up-to-date version. > For "speed", use Blockdev-Backup's version. For "sync", use > Drive-Backup's version. With that: Reviewed-by: Markus Armbruster [...]