From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 07/12] drm/i915: Use dram_dimm_info more Date: Mon, 04 Mar 2019 21:13:17 +0200 Message-ID: <87a7iae9ma.fsf@intel.com> References: <20190225202907.731-1-ville.syrjala@linux.intel.com> <20190225202907.731-8-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id B905289DB8 for ; Mon, 4 Mar 2019 19:11:10 +0000 (UTC) In-Reply-To: <20190225202907.731-8-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyNSBGZWIgMjAxOSwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4KPiBSZWR1Y2UgdGhlIGNvZGUgZHVwbGljYXRpb24gYSBiaXQgYnkg c2hhcmluZyB0aGUgc2FtZQo+IGNvZGUgZm9yIHBhcnNpbmcgYm90aCBESU1NcyBvbiBhIGNoYW5u ZWwuCj4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIHwg NDQgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAy NCBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu Ywo+IGluZGV4IDljMWZmM2ViNTc3NS4uM2Q2YTA4ZTkwN2UzIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5jCj4gQEAgLTExMTIsMjUgKzExMTIsMzAgQEAgc2tsX2lzXzE2Z2JfZGltbShjb25z dCBzdHJ1Y3QgZHJhbV9kaW1tX2luZm8gKmRpbW0pCj4gIAlyZXR1cm4gZGltbS0+c2l6ZSAqIGRp bW0tPndpZHRoIC8gKDggKiBkaW1tLT5yYW5rcyA/OiAxKSA9PSAxNjsKPiAgfQo+ICAKPiAtc3Rh dGljIGludAo+IC1za2xfZHJhbV9nZXRfY2hhbm5lbF9pbmZvKHN0cnVjdCBkcmFtX2NoYW5uZWxf aW5mbyAqY2gsIHUzMiB2YWwpCj4gK3N0YXRpYyB2b2lkCj4gK3NrbF9kcmFtX2dldF9kaW1tX2lu Zm8oc3RydWN0IGRyYW1fZGltbV9pbmZvICpkaW1tLAo+ICsJCSAgICAgICBpbnQgY2hhbm5lbCwg Y2hhciBkaW1tX25hbWUsIHUxNiB2YWwpCgpQZXJzb25hbGx5IEkgdGhpbmsgdXNpbmcgY2hhcnMg bGlrZSB0aGlzIGZvciBkaW1tX25hbWUgaXMgYW4gdW5uZWNlc3NhcnkKbWljcm8tb3B0aW1pemF0 aW9uIGZvciBjb25zdCBjaGFyICogb2YgbGVuZ3RoIDEuIEJ1dCAqc2hydWcqLgoKUmV2aWV3ZWQt Ynk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgpQUy4gV2hhdCBhIGhvcnJp YmxlLCBob3JyaWJsZSBkaWZmIHRvIHJldmlldyB0aGlzIGNoYW5nZSBwcm9kdWNlZCEKCgo+ICB7 Cj4gLQl1MTYgdG1wX2wsIHRtcF9zOwo+ICsJZGltbS0+c2l6ZSA9IHNrbF9nZXRfZGltbV9zaXpl KHZhbCk7Cj4gKwlkaW1tLT53aWR0aCA9IHNrbF9nZXRfZGltbV93aWR0aCh2YWwpOwo+ICsJZGlt bS0+cmFua3MgPSBza2xfZ2V0X2RpbW1fcmFua3ModmFsKTsKPiAgCj4gLQl0bXBfbCA9IHZhbCAm IDB4ZmZmZjsKPiAtCXRtcF9zID0gdmFsID4+IDE2Owo+ICsJRFJNX0RFQlVHX0tNUygiQ0glZCBE SU1NICVjIHNpemU6ICVkIEdCLCB3aWR0aDogWCVkLCByYW5rczogJWQsIDE2R2IgRElNTXM6ICVz XG4iLAo+ICsJCSAgICAgIGNoYW5uZWwsIGRpbW1fbmFtZSwgZGltbS0+c2l6ZSwgZGltbS0+d2lk dGgsIGRpbW0tPnJhbmtzLAo+ICsJCSAgICAgIHllc25vKHNrbF9pc18xNmdiX2RpbW0oZGltbSkp KTsKPiArfQo+ICAKPiAtCWNoLT5sX2luZm8uc2l6ZSA9IHNrbF9nZXRfZGltbV9zaXplKHRtcF9s KTsKPiAtCWNoLT5zX2luZm8uc2l6ZSA9IHNrbF9nZXRfZGltbV9zaXplKHRtcF9zKTsKPiArc3Rh dGljIGludAo+ICtza2xfZHJhbV9nZXRfY2hhbm5lbF9pbmZvKHN0cnVjdCBkcmFtX2NoYW5uZWxf aW5mbyAqY2gsCj4gKwkJCSAgaW50IGNoYW5uZWwsIHUzMiB2YWwpCj4gK3sKPiArCXNrbF9kcmFt X2dldF9kaW1tX2luZm8oJmNoLT5sX2luZm8sIGNoYW5uZWwsICdMJywgdmFsICYgMHhmZmZmKTsK PiArCXNrbF9kcmFtX2dldF9kaW1tX2luZm8oJmNoLT5zX2luZm8sIGNoYW5uZWwsICdTJywgdmFs ID4+IDE2KTsKPiAgCj4gLQlpZiAoY2gtPmxfaW5mby5zaXplID09IDAgJiYgY2gtPnNfaW5mby5z aXplID09IDApCj4gKwlpZiAoY2gtPmxfaW5mby5zaXplID09IDAgJiYgY2gtPnNfaW5mby5zaXpl ID09IDApIHsKPiArCQlEUk1fREVCVUdfS01TKCJDSCVkIG5vdCBwb3B1bGF0ZWRcbiIsIGNoYW5u ZWwpOwo+ICAJCXJldHVybiAtRUlOVkFMOwo+IC0KPiAtCWNoLT5sX2luZm8ud2lkdGggPSBza2xf Z2V0X2RpbW1fd2lkdGgodG1wX2wpOwo+IC0JY2gtPnNfaW5mby53aWR0aCA9IHNrbF9nZXRfZGlt bV93aWR0aCh0bXBfcyk7Cj4gLQo+IC0JY2gtPmxfaW5mby5yYW5rcyA9IHNrbF9nZXRfZGltbV9y YW5rcyh0bXBfbCk7Cj4gLQljaC0+c19pbmZvLnJhbmtzID0gc2tsX2dldF9kaW1tX3JhbmtzKHRt cF9zKTsKPiArCX0KPiAgCj4gIAlpZiAoY2gtPmxfaW5mby5yYW5rcyA9PSAyIHx8IGNoLT5zX2lu Zm8ucmFua3MgPT0gMikKPiAgCQljaC0+cmFua3MgPSAyOwo+IEBAIC0xMTQzLDkgKzExNDgsOCBA QCBza2xfZHJhbV9nZXRfY2hhbm5lbF9pbmZvKHN0cnVjdCBkcmFtX2NoYW5uZWxfaW5mbyAqY2gs IHUzMiB2YWwpCj4gIAkJc2tsX2lzXzE2Z2JfZGltbSgmY2gtPmxfaW5mbykgfHwKPiAgCQlza2xf aXNfMTZnYl9kaW1tKCZjaC0+c19pbmZvKTsKPiAgCj4gLQlEUk1fREVCVUdfS01TKCIoc2l6ZTp3 aWR0aDpyYW5rcykgTCglZEdCOlglZDolZCkgUyglZEdCOlglZDolZClcbiIsCj4gLQkJICAgICAg Y2gtPmxfaW5mby5zaXplLCBjaC0+bF9pbmZvLndpZHRoLCBjaC0+bF9pbmZvLnJhbmtzLAo+IC0J CSAgICAgIGNoLT5zX2luZm8uc2l6ZSwgY2gtPnNfaW5mby53aWR0aCwgY2gtPnNfaW5mby5yYW5r cyk7Cj4gKwlEUk1fREVCVUdfS01TKCJDSCVkIHJhbmtzOiAlZCwgMTZHYiBESU1NczogJXNcbiIs Cj4gKwkJICAgICAgY2hhbm5lbCwgY2gtPnJhbmtzLCB5ZXNubyhjaC0+aXNfMTZnYl9kaW1tKSk7 Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiBAQCAtMTE2NSwxNyArMTE2OSwxNyBAQCBzdGF0aWMg aW50Cj4gIHNrbF9kcmFtX2dldF9jaGFubmVsc19pbmZvKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiAgewo+ICAJc3RydWN0IGRyYW1faW5mbyAqZHJhbV9pbmZvID0gJmRldl9w cml2LT5kcmFtX2luZm87Cj4gLQlzdHJ1Y3QgZHJhbV9jaGFubmVsX2luZm8gY2gwLCBjaDE7Cj4g KwlzdHJ1Y3QgZHJhbV9jaGFubmVsX2luZm8gY2gwID0ge30sIGNoMSA9IHt9Owo+ICAJdTMyIHZh bF9jaDAsIHZhbF9jaDE7Cj4gIAlpbnQgcmV0Owo+ICAKPiAgCXZhbF9jaDAgPSBJOTE1X1JFQUQo U0tMX01BRF9ESU1NX0NIMF8wXzBfMF9NQ0hCQVJfTUNNQUlOKTsKPiAtCXJldCA9IHNrbF9kcmFt X2dldF9jaGFubmVsX2luZm8oJmNoMCwgdmFsX2NoMCk7Cj4gKwlyZXQgPSBza2xfZHJhbV9nZXRf Y2hhbm5lbF9pbmZvKCZjaDAsIDAsIHZhbF9jaDApOwo+ICAJaWYgKHJldCA9PSAwKQo+ICAJCWRy YW1faW5mby0+bnVtX2NoYW5uZWxzKys7Cj4gIAo+ICAJdmFsX2NoMSA9IEk5MTVfUkVBRChTS0xf TUFEX0RJTU1fQ0gxXzBfMF8wX01DSEJBUl9NQ01BSU4pOwo+IC0JcmV0ID0gc2tsX2RyYW1fZ2V0 X2NoYW5uZWxfaW5mbygmY2gxLCB2YWxfY2gxKTsKPiArCXJldCA9IHNrbF9kcmFtX2dldF9jaGFu bmVsX2luZm8oJmNoMSwgMSwgdmFsX2NoMSk7Cj4gIAlpZiAocmV0ID09IDApCj4gIAkJZHJhbV9p bmZvLT5udW1fY2hhbm5lbHMrKzsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2Ug R3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeA==