From: Grygorii Tertychnyi <gtertych@cisco.com>
To: Changqing Li <changqing.li@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: ✗ patchtest: failure for curl: fix for CVE-2018-16839/CVE-2018-16840/CVE-2018-16842
Date: Mon, 05 Nov 2018 19:39:27 +0200 [thread overview]
Message-ID: <87a7mn2zlc.fsf@cisco.com> (raw)
In-Reply-To: <f8c4a061-f2d2-9c04-1885-647f98a222ea@windriver.com>
On Fri Nov02 2018 @ 06:48, Changqing Li
<changqing.li@windriver.com> wrote:
> I have add CVE tag in the patch file, is this test result
> incorrect?
My guess is it was fooled by (well, "incorrect") "CVE-YYYY-XXXX"
lines. Even thouhg it is followed by the (correct) "CVE:
CVE-YYYY-XXXX" in your CVE patches
43 # first match is lax but second strict
44 if
self.re_cve_payload_pattern.match(line):
45 if not
self.re_cve_payload_tag.match(line):
46 self.fail('Missing or incorrectly
formatted CVE tag in included patch file',
47 'Correct or include the
CVE tag on cve patch with format: "CVE: CVE-YYYY-XXXX"',
48 commit)
Do you really need "incorrect" lines?
> On 11/2/18 2:41 PM, Patchwork wrote:
>> == Series Details ==
>>
>> Series: curl: fix for
>> CVE-2018-16839/CVE-2018-16840/CVE-2018-16842
>> Revision: 1
>> URL : https://patchwork.openembedded.org/series/14764/
>> State : failure
>>
>> == Summary ==
>>
>>
>> Thank you for submitting this patch series to OpenEmbedded
>> Core. This is
>> an automated response. Several tests have been executed on the
>> proposed
>> series by patchtest resulting in the following failures:
>>
>>
>>
>> * Patch curl: fix for
>> CVE-2018-16839/CVE-2018-16840/CVE-2018-16842
>> Issue Missing or incorrectly formatted CVE tag in
>> included patch file [test_cve_tag_format]
>> Suggested fix Correct or include the CVE tag on cve patch
>> with format: "CVE: CVE-YYYY-XXXX"
>>
>>
>>
>> If you believe any of these test results are incorrect, please
>> reply to the
>> mailing list (openembedded-core@lists.openembedded.org) raising
>> your concerns.
>> Otherwise we would appreciate you correcting the issues and
>> submitting a new
>> version of the patchset if applicable. Please ensure you
>> add/increment the
>> version number when sending the new version (i.e. [PATCH] ->
>> [PATCH v2] ->
>> [PATCH v3] -> ...).
>>
>> ---
>> Guidelines:
>> https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
>> Test framework:
>> http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
>> Test suite:
>> http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
>>
>>
> --
> BRs
>
> Sandy(Li Changqing)
next prev parent reply other threads:[~2018-11-05 17:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 6:07 [PATCH] curl: fix for CVE-2018-16839/CVE-2018-16840/CVE-2018-16842 changqing.li
2018-11-02 6:41 ` ✗ patchtest: failure for " Patchwork
2018-11-02 6:48 ` Changqing Li
2018-11-05 17:39 ` Grygorii Tertychnyi [this message]
2018-11-06 2:09 ` Changqing Li
2018-11-02 16:05 ` [PATCH] " akuster808
2018-11-05 2:32 ` Changqing Li
2018-11-09 16:36 ` akuster808
2018-11-12 1:46 ` Changqing Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7mn2zlc.fsf@cisco.com \
--to=gtertych@cisco.com \
--cc=changqing.li@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.