All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Lyude <cpaul@redhat.com>,
	Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [RFC] drm/i915/dp: Remove i915.enable_dp_mst module parameter
Date: Thu, 04 Oct 2018 10:03:39 +0300	[thread overview]
Message-ID: <87a7nuqjlg.fsf@intel.com> (raw)
In-Reply-To: <20181003193601.16260-1-dhinakaran.pandiyan@intel.com>

On Wed, 03 Oct 2018, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> wrote:
> MST is enabled by default on all platforms that support it. I don't think
> we should be providing a switch to work around MST issues as the feature
> has been supported for a while now. Let's kill this module parameter
> that we also do not test in CI.

I agree we don't want to provide this to users to *work around*
issues. But maybe we want something like this to *debug* issues?

We have a plethora of unsafe/debug module parameters mainly because
they're convenient and take effect from the beginning of the probe. If
there was anything comparable for debugfs, I'd be all in.

Should we have this in debugfs instead?

Cc: Lyude for insights too.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-10-04  7:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 19:36 [RFC] drm/i915/dp: Remove i915.enable_dp_mst module parameter Dhinakaran Pandiyan
2018-10-03 20:04 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-03 20:29 ` [RFC] " Rodrigo Vivi
2018-10-04  7:03 ` Jani Nikula [this message]
2018-10-04 10:59   ` Ville Syrjälä
2018-10-04 15:54     ` Rodrigo Vivi
2018-10-04 17:36       ` Dhinakaran Pandiyan
2018-10-04  8:58 ` ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7nuqjlg.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=cpaul@redhat.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.