Fabio Estevam writes: > Hi Julia, > > On Thu, Mar 29, 2018 at 4:12 PM, Julia Lawall wrote: >> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE >> for debugfs files. >> >> Semantic patch information: >> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() >> imposes some significant overhead as compared to >> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Just curious: could you please expand on what "imposes some > significant overhead" means? > Probably negligible given that this code will only be run once at system boot and then never used again in production systems. But I guess the micro-optimization doesn't hurt either. > Thanks