All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Berger <stefanb@linux.vnet.ibm.com>,
	Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] qapi: Rename QMP and QGA schema files
Date: Sun, 11 Feb 2018 10:49:25 +0100	[thread overview]
Message-ID: <87a7wfj1p6.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20180211004013.10784-3-eblake@redhat.com> (Eric Blake's message of "Sat, 10 Feb 2018 18:40:12 -0600")

Eric Blake <eblake@redhat.com> writes:

> Having two files in the tree both named qapi-schema.json just adds
> confusion.  Rename these files, and relocate them into the common
> qapi/ subdirectory.  Update all build rules that refer to the file
> names, and adjust other documentation and comment references to
> either track the new name or be rewritten so as to not mention
> the file name.
>
> Maintainer-wise, this means that qapi/qga-schema.json continues
> to belong to Michael as QGA maintainer, but now also notifies
> Markus and Eric as QAPI maintainers, alongside all the other
> QMP QAPI files, matching how other .json QAPI modules belong
> to multiple maintainer blurbs.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  docs/devel/writing-qmp-commands.txt          | 13 ++++++-----
>  docs/interop/qmp-intro.txt                   |  3 ++-
>  Makefile                                     | 10 ++++----
>  qga/qapi-schema.json => qapi/qga-schema.json |  0

This move is up to the QGA maintainer.  My usual argument for keeping
the schema in one place is weak for the QGA schema: it's maintained
separately, and ususuall grepped separately, too.

>  qapi-schema.json => qapi/qmp-schema.json     | 34 ++++++++++++++--------------

While it was certainly created for QMP, it's now used for non-QMP stuff,
too.  Do we mind?

>  tpm.c                                        |  2 +-
>  MAINTAINERS                                  |  2 +-
>  7 files changed, 33 insertions(+), 31 deletions(-)
>  rename qga/qapi-schema.json => qapi/qga-schema.json (100%)
>  rename qapi-schema.json => qapi/qmp-schema.json (99%)

  reply	other threads:[~2018-02-11  9:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-11  0:40 [Qemu-devel] [PATCH 0/3] QAPI file renames Eric Blake
2018-02-11  0:40 ` [Qemu-devel] [PATCH 1/3] qapi: Pass '-u' when doing non-silent diff Eric Blake
2018-02-11  4:11   ` Philippe Mathieu-Daudé
2018-02-11 12:04   ` Markus Armbruster
2018-02-12 16:10     ` Eric Blake
2018-02-11  0:40 ` [Qemu-devel] [PATCH 2/3] qapi: Rename QMP and QGA schema files Eric Blake
2018-02-11  9:49   ` Markus Armbruster [this message]
2018-02-12 16:12     ` Eric Blake
2018-02-15 19:03       ` Michael Roth
2018-02-11  0:40 ` [Qemu-devel] [PATCH 3/3] qapi: Rename .json to .qapi Eric Blake
2018-02-12  9:52   ` Daniel P. Berrangé
2018-02-12 10:17     ` Marc-André Lureau
2018-02-23 17:15       ` Markus Armbruster
2018-02-11  9:44 ` [Qemu-devel] [PATCH 0/3] QAPI file renames Markus Armbruster
2018-02-12 16:13   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7wfj1p6.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.